diff options
| author | deraadt <> | 2019-06-27 18:03:37 +0000 |
|---|---|---|
| committer | deraadt <> | 2019-06-27 18:03:37 +0000 |
| commit | 2e39f4f9ad2b7c91dccfb7b2fb1b6237fef520f5 (patch) | |
| tree | 92b40794826688cb27bb73875716314a6af3fb0c /src/usr.bin/nc | |
| parent | 7428bb5ee53696fd7fb6e551a60b65c715f0b64f (diff) | |
| download | openbsd-2e39f4f9ad2b7c91dccfb7b2fb1b6237fef520f5.tar.gz openbsd-2e39f4f9ad2b7c91dccfb7b2fb1b6237fef520f5.tar.bz2 openbsd-2e39f4f9ad2b7c91dccfb7b2fb1b6237fef520f5.zip | |
Some asprintf() calls were checked < 0, rather than the precise == -1.
ok millert nicm tb, etc
Diffstat (limited to 'src/usr.bin/nc')
| -rw-r--r-- | src/usr.bin/nc/netcat.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/usr.bin/nc/netcat.c b/src/usr.bin/nc/netcat.c index 048502bd1e..26288560b0 100644 --- a/src/usr.bin/nc/netcat.c +++ b/src/usr.bin/nc/netcat.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: netcat.c,v 1.203 2019/02/26 17:32:47 jsing Exp $ */ | 1 | /* $OpenBSD: netcat.c,v 1.204 2019/06/27 18:03:37 deraadt Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Copyright (c) 2001 Eric Jackson <ericj@monkey.org> | 3 | * Copyright (c) 2001 Eric Jackson <ericj@monkey.org> |
| 4 | * Copyright (c) 2015 Bob Beck. All rights reserved. | 4 | * Copyright (c) 2015 Bob Beck. All rights reserved. |
| @@ -1453,12 +1453,12 @@ build_ports(char *p) | |||
| 1453 | for (x = 0; x <= hi - lo; x++) { | 1453 | for (x = 0; x <= hi - lo; x++) { |
| 1454 | cp = arc4random_uniform(x + 1); | 1454 | cp = arc4random_uniform(x + 1); |
| 1455 | portlist[x] = portlist[cp]; | 1455 | portlist[x] = portlist[cp]; |
| 1456 | if (asprintf(&portlist[cp], "%d", x + lo) < 0) | 1456 | if (asprintf(&portlist[cp], "%d", x + lo) == -1) |
| 1457 | err(1, "asprintf"); | 1457 | err(1, "asprintf"); |
| 1458 | } | 1458 | } |
| 1459 | } else { /* Load ports sequentially. */ | 1459 | } else { /* Load ports sequentially. */ |
| 1460 | for (cp = lo; cp <= hi; cp++) { | 1460 | for (cp = lo; cp <= hi; cp++) { |
| 1461 | if (asprintf(&portlist[x], "%d", cp) < 0) | 1461 | if (asprintf(&portlist[x], "%d", cp) == -1) |
| 1462 | err(1, "asprintf"); | 1462 | err(1, "asprintf"); |
| 1463 | x++; | 1463 | x++; |
| 1464 | } | 1464 | } |