snprintf/vsnprintf return < 0 on error, rather than -1.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/usr.bin/openssl/apps.c b/src/usr.bin/openssl/apps.c
index 47e21265af..39ce7a5f34 100644
--- a/src/usr.bin/openssl/apps.c
+++ b/src/usr.bin/openssl/apps.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: apps.c,v 1.52 2019/06/28 13:35:02 deraadt Exp $ */
+/* $OpenBSD: apps.c,v 1.53 2019/07/03 03:24:02 deraadt Exp $ */
 /*
  * Copyright (c) 2014 Joel Sing <jsing@openbsd.org>
  *
@@ -1328,7 +1328,7 @@ save_serial(char *serialfile, char *suffix, BIGNUM *serial,
         else
                 n = snprintf(serialpath, sizeof serialpath, "%s.%s",
                     serialfile, suffix);
-        if (n == -1 || n >= sizeof(serialpath)) {
+        if (n < 0 || n >= sizeof(serialpath)) {
                 BIO_printf(bio_err, "serial too long\n");
                 goto err;
         }