sprintf: bad.

snprintf: good.
snprintf with a correct size: better!
(harmless in this case)

2 files changed, 2 insertions, 2 deletions

diff --git a/src/lib/libcrypto/asn1/a_strex.c b/src/lib/libcrypto/asn1/a_strex.c
index 713b3cb028..65f95532a3 100644
--- a/src/lib/libcrypto/asn1/a_strex.c
+++ b/src/lib/libcrypto/asn1/a_strex.c
@@ -149,7 +149,7 @@ static int do_esc_char(unsigned long c, unsigned char flags, char *do_quotes, ch
                 return 2;
         }
         if(chflgs & (ASN1_STRFLGS_ESC_CTRL|ASN1_STRFLGS_ESC_MSB)) {
-                (void) snprintf(tmphex, 11, "\\%02X", chtmp);
+                (void) snprintf(tmphex, sizeof tmphex, "\\%02X", chtmp);
                 if(!io_ch(arg, tmphex, 3)) return -1;
                 return 3;
         }
diff --git a/src/lib/libssl/src/crypto/asn1/a_strex.c b/src/lib/libssl/src/crypto/asn1/a_strex.c
index 713b3cb028..65f95532a3 100644
--- a/src/lib/libssl/src/crypto/asn1/a_strex.c
+++ b/src/lib/libssl/src/crypto/asn1/a_strex.c
@@ -149,7 +149,7 @@ static int do_esc_char(unsigned long c, unsigned char flags, char *do_quotes, ch
                 return 2;
         }
         if(chflgs & (ASN1_STRFLGS_ESC_CTRL|ASN1_STRFLGS_ESC_MSB)) {
-                (void) snprintf(tmphex, 11, "\\%02X", chtmp);
+                (void) snprintf(tmphex, sizeof tmphex, "\\%02X", chtmp);
                 if(!io_ch(arg, tmphex, 3)) return -1;
                 return 3;
         }