diff options
| author | miod <> | 2014-10-12 20:47:12 +0000 |
|---|---|---|
| committer | miod <> | 2014-10-12 20:47:12 +0000 |
| commit | dff42a49d6915f3ecaa9bacc7657970e73aa7443 (patch) | |
| tree | 9c3008e895dddc5c8439683d0f7c4e795f152692 /src | |
| parent | 78332233d01faa45e0bb0b1583d47cb5ad1ddc19 (diff) | |
| download | openbsd-dff42a49d6915f3ecaa9bacc7657970e73aa7443.tar.gz openbsd-dff42a49d6915f3ecaa9bacc7657970e73aa7443.tar.bz2 openbsd-dff42a49d6915f3ecaa9bacc7657970e73aa7443.zip | |
Paranoia: in ASN1_mbstring_ncopy(), check for len < 0 instead of len == -1,
in order to catch all negative sizes.
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib/libcrypto/asn1/a_mbstr.c | 4 | ||||
| -rw-r--r-- | src/lib/libssl/src/crypto/asn1/a_mbstr.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/lib/libcrypto/asn1/a_mbstr.c b/src/lib/libcrypto/asn1/a_mbstr.c index 985d29824d..9ce0a000fe 100644 --- a/src/lib/libcrypto/asn1/a_mbstr.c +++ b/src/lib/libcrypto/asn1/a_mbstr.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: a_mbstr.c,v 1.20 2014/09/21 12:14:34 miod Exp $ */ | 1 | /* $OpenBSD: a_mbstr.c,v 1.21 2014/10/12 20:47:12 miod Exp $ */ |
| 2 | /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL | 2 | /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL |
| 3 | * project 1999. | 3 | * project 1999. |
| 4 | */ | 4 | */ |
| @@ -104,7 +104,7 @@ ASN1_mbstring_ncopy(ASN1_STRING **out, const unsigned char *in, int len, | |||
| 104 | int nchar; | 104 | int nchar; |
| 105 | int (*cpyfunc)(unsigned long, void *) = NULL; | 105 | int (*cpyfunc)(unsigned long, void *) = NULL; |
| 106 | 106 | ||
| 107 | if (len == -1) | 107 | if (len < 0) |
| 108 | len = strlen((const char *)in); | 108 | len = strlen((const char *)in); |
| 109 | if (!mask) | 109 | if (!mask) |
| 110 | mask = DIRSTRING_TYPE; | 110 | mask = DIRSTRING_TYPE; |
diff --git a/src/lib/libssl/src/crypto/asn1/a_mbstr.c b/src/lib/libssl/src/crypto/asn1/a_mbstr.c index 985d29824d..9ce0a000fe 100644 --- a/src/lib/libssl/src/crypto/asn1/a_mbstr.c +++ b/src/lib/libssl/src/crypto/asn1/a_mbstr.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: a_mbstr.c,v 1.20 2014/09/21 12:14:34 miod Exp $ */ | 1 | /* $OpenBSD: a_mbstr.c,v 1.21 2014/10/12 20:47:12 miod Exp $ */ |
| 2 | /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL | 2 | /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL |
| 3 | * project 1999. | 3 | * project 1999. |
| 4 | */ | 4 | */ |
| @@ -104,7 +104,7 @@ ASN1_mbstring_ncopy(ASN1_STRING **out, const unsigned char *in, int len, | |||
| 104 | int nchar; | 104 | int nchar; |
| 105 | int (*cpyfunc)(unsigned long, void *) = NULL; | 105 | int (*cpyfunc)(unsigned long, void *) = NULL; |
| 106 | 106 | ||
| 107 | if (len == -1) | 107 | if (len < 0) |
| 108 | len = strlen((const char *)in); | 108 | len = strlen((const char *)in); |
| 109 | if (!mask) | 109 | if (!mask) |
| 110 | mask = DIRSTRING_TYPE; | 110 | mask = DIRSTRING_TYPE; |
