summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/pem
diff options
context:
space:
mode:
Diffstat (limited to 'src/lib/libcrypto/pem')
-rw-r--r--src/lib/libcrypto/pem/pem_lib.c15
-rw-r--r--src/lib/libcrypto/pem/pem_pkey.c5
-rw-r--r--src/lib/libcrypto/pem/pvkfmt.c7
3 files changed, 8 insertions, 19 deletions
diff --git a/src/lib/libcrypto/pem/pem_lib.c b/src/lib/libcrypto/pem/pem_lib.c
index b2c72e1d76..0f7c36d21c 100644
--- a/src/lib/libcrypto/pem/pem_lib.c
+++ b/src/lib/libcrypto/pem/pem_lib.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: pem_lib.c,v 1.44 2017/01/29 17:49:23 beck Exp $ */ 1/* $OpenBSD: pem_lib.c,v 1.45 2017/05/02 03:59:44 deraadt Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -425,10 +425,7 @@ err:
425 explicit_bzero(iv, sizeof(iv)); 425 explicit_bzero(iv, sizeof(iv));
426 explicit_bzero((char *)&ctx, sizeof(ctx)); 426 explicit_bzero((char *)&ctx, sizeof(ctx));
427 explicit_bzero(buf, PEM_BUFSIZE); 427 explicit_bzero(buf, PEM_BUFSIZE);
428 if (data != NULL) { 428 freezero(data, (unsigned int)dsize);
429 explicit_bzero(data, (unsigned int)dsize);
430 free(data);
431 }
432 return (ret); 429 return (ret);
433} 430}
434 431
@@ -626,8 +623,7 @@ PEM_write_bio(BIO *bp, const char *name, char *header, unsigned char *data,
626 EVP_EncodeFinal(&ctx, buf, &outl); 623 EVP_EncodeFinal(&ctx, buf, &outl);
627 if ((outl > 0) && (BIO_write(bp, (char *)buf, outl) != outl)) 624 if ((outl > 0) && (BIO_write(bp, (char *)buf, outl) != outl))
628 goto err; 625 goto err;
629 explicit_bzero(buf, PEM_BUFSIZE * 8); 626 freezero(buf, PEM_BUFSIZE * 8);
630 free(buf);
631 buf = NULL; 627 buf = NULL;
632 if ((BIO_write(bp, "-----END ", 9) != 9) || 628 if ((BIO_write(bp, "-----END ", 9) != 9) ||
633 (BIO_write(bp, name, nlen) != nlen) || 629 (BIO_write(bp, name, nlen) != nlen) ||
@@ -636,10 +632,7 @@ PEM_write_bio(BIO *bp, const char *name, char *header, unsigned char *data,
636 return (i + outl); 632 return (i + outl);
637 633
638err: 634err:
639 if (buf) { 635 freezero(buf, PEM_BUFSIZE * 8);
640 explicit_bzero(buf, PEM_BUFSIZE * 8);
641 free(buf);
642 }
643 PEMerror(reason); 636 PEMerror(reason);
644 return (0); 637 return (0);
645} 638}
diff --git a/src/lib/libcrypto/pem/pem_pkey.c b/src/lib/libcrypto/pem/pem_pkey.c
index 6651ef9419..89181a25f7 100644
--- a/src/lib/libcrypto/pem/pem_pkey.c
+++ b/src/lib/libcrypto/pem/pem_pkey.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: pem_pkey.c,v 1.22 2017/01/29 17:49:23 beck Exp $ */ 1/* $OpenBSD: pem_pkey.c,v 1.23 2017/05/02 03:59:44 deraadt Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -143,8 +143,7 @@ p8err:
143 PEMerror(ERR_R_ASN1_LIB); 143 PEMerror(ERR_R_ASN1_LIB);
144err: 144err:
145 free(nm); 145 free(nm);
146 explicit_bzero(data, len); 146 freezero(data, len);
147 free(data);
148 return (ret); 147 return (ret);
149} 148}
150 149
diff --git a/src/lib/libcrypto/pem/pvkfmt.c b/src/lib/libcrypto/pem/pvkfmt.c
index 5ed8df585f..18de5d52a4 100644
--- a/src/lib/libcrypto/pem/pvkfmt.c
+++ b/src/lib/libcrypto/pem/pvkfmt.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: pvkfmt.c,v 1.18 2017/01/29 17:49:23 beck Exp $ */ 1/* $OpenBSD: pvkfmt.c,v 1.19 2017/05/02 03:59:44 deraadt Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2005. 3 * project 2005.
4 */ 4 */
@@ -828,10 +828,7 @@ b2i_PVK_bio(BIO *in, pem_password_cb *cb, void *u)
828 ret = do_PVK_body(&p, saltlen, keylen, cb, u); 828 ret = do_PVK_body(&p, saltlen, keylen, cb, u);
829 829
830err: 830err:
831 if (buf) { 831 freezero(buf, buflen);
832 explicit_bzero(buf, buflen);
833 free(buf);
834 }
835 return ret; 832 return ret;
836} 833}
837 834