4 files changed, 26 insertions, 13 deletions

diff --git a/src/lib/libcrypto/pkcs12/p12_decr.c b/src/lib/libcrypto/pkcs12/p12_decr.c
index ba77dbbe32..9d3557e8d7 100644
--- a/src/lib/libcrypto/pkcs12/p12_decr.c
+++ b/src/lib/libcrypto/pkcs12/p12_decr.c
@@ -89,7 +89,14 @@ unsigned char * PKCS12_pbe_crypt(X509_ALGOR *algor, const char *pass,
                 goto err;
         }
 
-        EVP_CipherUpdate(&ctx, out, &i, in, inlen);
+        if (!EVP_CipherUpdate(&ctx, out, &i, in, inlen))
+                {
+                OPENSSL_free(out);
+                out = NULL;
+                PKCS12err(PKCS12_F_PKCS12_PBE_CRYPT,ERR_R_EVP_LIB);
+                goto err;
+                }
+
         outlen = i;
         if(!EVP_CipherFinal_ex(&ctx, out + i, &i)) {
                 OPENSSL_free(out);
diff --git a/src/lib/libcrypto/pkcs12/p12_key.c b/src/lib/libcrypto/pkcs12/p12_key.c
index 424203f648..c55c7b60b3 100644
--- a/src/lib/libcrypto/pkcs12/p12_key.c
+++ b/src/lib/libcrypto/pkcs12/p12_key.c
@@ -152,14 +152,16 @@ int PKCS12_key_gen_uni(unsigned char *pass, int passlen, unsigned char *salt,
         for (i = 0; i < Slen; i++) *p++ = salt[i % saltlen];
         for (i = 0; i < Plen; i++) *p++ = pass[i % passlen];
         for (;;) {
-                EVP_DigestInit_ex(&ctx, md_type, NULL);
-                EVP_DigestUpdate(&ctx, D, v);
-                EVP_DigestUpdate(&ctx, I, Ilen);
-                EVP_DigestFinal_ex(&ctx, Ai, NULL);
+                if (!EVP_DigestInit_ex(&ctx, md_type, NULL)
+                        || !EVP_DigestUpdate(&ctx, D, v)
+                        || !EVP_DigestUpdate(&ctx, I, Ilen)
+                        || !EVP_DigestFinal_ex(&ctx, Ai, NULL))
+                        goto err;
                 for (j = 1; j < iter; j++) {
-                        EVP_DigestInit_ex(&ctx, md_type, NULL);
-                        EVP_DigestUpdate(&ctx, Ai, u);
-                        EVP_DigestFinal_ex(&ctx, Ai, NULL);
+                        if (!EVP_DigestInit_ex(&ctx, md_type, NULL)
+                                || !EVP_DigestUpdate(&ctx, Ai, u)
+                                || !EVP_DigestFinal_ex(&ctx, Ai, NULL))
+                        goto err;
                 }
                 memcpy (out, Ai, min (n, u));
                 if (u >= n) {
diff --git a/src/lib/libcrypto/pkcs12/p12_kiss.c b/src/lib/libcrypto/pkcs12/p12_kiss.c
index 292cc3ed4a..206b1b0b18 100644
--- a/src/lib/libcrypto/pkcs12/p12_kiss.c
+++ b/src/lib/libcrypto/pkcs12/p12_kiss.c
@@ -167,7 +167,7 @@ int PKCS12_parse(PKCS12 *p12, const char *pass, EVP_PKEY **pkey, X509 **cert,
         if (cert && *cert)
                 X509_free(*cert);
         if (x)
-                X509_free(*cert);
+                X509_free(x);
         if (ocerts)
                 sk_X509_pop_free(ocerts, X509_free);
         return 0;
diff --git a/src/lib/libcrypto/pkcs12/p12_mutl.c b/src/lib/libcrypto/pkcs12/p12_mutl.c
index 9ab740d51f..96de1bd11e 100644
--- a/src/lib/libcrypto/pkcs12/p12_mutl.c
+++ b/src/lib/libcrypto/pkcs12/p12_mutl.c
@@ -97,10 +97,14 @@ int PKCS12_gen_mac(PKCS12 *p12, const char *pass, int passlen,
                 return 0;
         }
         HMAC_CTX_init(&hmac);
-        HMAC_Init_ex(&hmac, key, md_size, md_type, NULL);
-        HMAC_Update(&hmac, p12->authsafes->d.data->data,
-                                         p12->authsafes->d.data->length);
-        HMAC_Final(&hmac, mac, maclen);
+        if (!HMAC_Init_ex(&hmac, key, md_size, md_type, NULL)
+                || !HMAC_Update(&hmac, p12->authsafes->d.data->data,
+                                         p12->authsafes->d.data->length)
+                || !HMAC_Final(&hmac, mac, maclen))
+                {
+                HMAC_CTX_cleanup(&hmac);
+                return 0;
+                }
         HMAC_CTX_cleanup(&hmac);
         return 1;
 }