1 files changed, 11 insertions, 60 deletions

diff --git a/src/lib/libcrypto/rand/rand_win.c b/src/lib/libcrypto/rand/rand_win.c
index 5d134e186b..00dbe4232c 100644
--- a/src/lib/libcrypto/rand/rand_win.c
+++ b/src/lib/libcrypto/rand/rand_win.c
@@ -463,7 +463,7 @@ int RAND_poll(void)
                 PROCESSENTRY32 p;
                 THREADENTRY32 t;
                 MODULEENTRY32 m;
-                DWORD starttime = 0;
+                DWORD stoptime = 0;
 
                 snap = (CREATETOOLHELP32SNAPSHOT)
                         GetProcAddress(kernel, "CreateToolhelp32Snapshot");
@@ -494,29 +494,12 @@ int RAND_poll(void)
                          * each entry.  Consider each field a source of 1 byte
                          * of entropy.
                          */
-                        ZeroMemory(&hlist, sizeof(HEAPLIST32));
                         hlist.dwSize = sizeof(HEAPLIST32);              
-                        if (good) starttime = GetTickCount();
-#ifdef _MSC_VER
+                        if (good) stoptime = GetTickCount() + MAXDELAY;
                         if (heaplist_first(handle, &hlist))
-                                {
-                                /*
-                                   following discussion on dev ML, exception on WinCE (or other Win
-                                   platform) is theoretically of unknown origin; prevent infinite
-                                   loop here when this theoretical case occurs; otherwise cope with
-                                   the expected (MSDN documented) exception-throwing behaviour of
-                                   Heap32Next() on WinCE.
-
-                                   based on patch in original message by Tanguy Fautré (2009/03/02)
-                                   Subject: RAND_poll() and CreateToolhelp32Snapshot() stability
-                             */
-                                int ex_cnt_limit = 42; 
                                 do
                                         {
                                         RAND_add(&hlist, hlist.dwSize, 3);
-                                        __try
-                                                {
-                                                ZeroMemory(&hentry, sizeof(HEAPENTRY32));
                                         hentry.dwSize = sizeof(HEAPENTRY32);
                                         if (heap_first(&hentry,
                                                 hlist.th32ProcessID,
@@ -527,42 +510,10 @@ int RAND_poll(void)
                                                         RAND_add(&hentry,
                                                                 hentry.dwSize, 5);
                                                 while (heap_next(&hentry)
-                                                && (!good || (GetTickCount()-starttime)<MAXDELAY)
                                                         && --entrycnt > 0);
                                                 }
-                                                }
-                                        __except (EXCEPTION_EXECUTE_HANDLER)
-                                                {
-                                                        /* ignore access violations when walking the heap list */
-                                                        ex_cnt_limit--;
-                                                }
-                                        } while (heaplist_next(handle, &hlist) 
-                                                && (!good || (GetTickCount()-starttime)<MAXDELAY)
-                                                && ex_cnt_limit > 0);
-                                }
-
-#else
-                        if (heaplist_first(handle, &hlist))
-                                {
-                                do
-                                        {
-                                        RAND_add(&hlist, hlist.dwSize, 3);
-                                        hentry.dwSize = sizeof(HEAPENTRY32);
-                                        if (heap_first(&hentry,
-                                                hlist.th32ProcessID,
-                                                hlist.th32HeapID))
-                                                {
-                                                int entrycnt = 80;
-                                                do
-                                                        RAND_add(&hentry,
-                                                                hentry.dwSize, 5);
-                                                while (heap_next(&hentry)
-                                                        && --entrycnt > 0);
-                                                }
-                                        } while (heaplist_next(handle, &hlist) 
-                                                && (!good || (GetTickCount()-starttime)<MAXDELAY));
-                                }
-#endif
+                                        } while (heaplist_next(handle,
+                                                &hlist) && GetTickCount() < stoptime);
 
                         /* process walking */
                         /* PROCESSENTRY32 contains 9 fields that will change
@@ -571,11 +522,11 @@ int RAND_poll(void)
                          */
                         p.dwSize = sizeof(PROCESSENTRY32);
                 
-                        if (good) starttime = GetTickCount();
+                        if (good) stoptime = GetTickCount() + MAXDELAY;
                         if (process_first(handle, &p))
                                 do
                                         RAND_add(&p, p.dwSize, 9);
-                                while (process_next(handle, &p) && (!good || (GetTickCount()-starttime)<MAXDELAY));
+                                while (process_next(handle, &p) && GetTickCount() < stoptime);
 
                         /* thread walking */
                         /* THREADENTRY32 contains 6 fields that will change
@@ -583,11 +534,11 @@ int RAND_poll(void)
                          * 1 byte of entropy.
                          */
                         t.dwSize = sizeof(THREADENTRY32);
-                        if (good) starttime = GetTickCount();
+                        if (good) stoptime = GetTickCount() + MAXDELAY;
                         if (thread_first(handle, &t))
                                 do
                                         RAND_add(&t, t.dwSize, 6);
-                                while (thread_next(handle, &t) && (!good || (GetTickCount()-starttime)<MAXDELAY));
+                                while (thread_next(handle, &t) && GetTickCount() < stoptime);
 
                         /* module walking */
                         /* MODULEENTRY32 contains 9 fields that will change
@@ -595,12 +546,12 @@ int RAND_poll(void)
                          * 1 byte of entropy.
                          */
                         m.dwSize = sizeof(MODULEENTRY32);
-                        if (good) starttime = GetTickCount();
+                        if (good) stoptime = GetTickCount() + MAXDELAY;
                         if (module_first(handle, &m))
                                 do
                                         RAND_add(&m, m.dwSize, 9);
                                 while (module_next(handle, &m)
-                                                && (!good || (GetTickCount()-starttime)<MAXDELAY));
+                                                && (GetTickCount() < stoptime));
                         if (close_snap)
                                 close_snap(handle);
                         else
@@ -750,7 +701,7 @@ static void readscreen(void)
   int           y;              /* y-coordinate of screen lines to grab */
   int           n = 16;         /* number of screen lines to grab at a time */
 
-  if (GetVersion() < 0x80000000 && OPENSSL_isservice()>0)
+  if (GetVersion() >= 0x80000000 || !OPENSSL_isservice())
     return;
 
   /* Create a screen DC and a memory DC compatible to screen DC */