3 files changed, 13 insertions, 35 deletions

diff --git a/src/lib/libcrypto/rsa/rsa_eay.c b/src/lib/libcrypto/rsa/rsa_eay.c
index f9f620ae23..6c3da0d656 100644
--- a/src/lib/libcrypto/rsa/rsa_eay.c
+++ b/src/lib/libcrypto/rsa/rsa_eay.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: rsa_eay.c,v 1.48 2017/04/28 22:46:40 beck Exp $ */
+/* $OpenBSD: rsa_eay.c,v 1.49 2017/05/02 03:59:45 deraadt Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -244,10 +244,7 @@ err:
                 BN_CTX_end(ctx);
                 BN_CTX_free(ctx);
         }
-        if (buf != NULL) {
-                explicit_bzero(buf, num);
-                free(buf);
-        }
+        freezero(buf, num);
         return r;
 }
 
@@ -468,10 +465,7 @@ err:
                 BN_CTX_end(ctx);
                 BN_CTX_free(ctx);
         }
-        if (buf != NULL) {
-                explicit_bzero(buf, num);
-                free(buf);
-        }
+        freezero(buf, num);
         return r;
 }
 
@@ -597,10 +591,7 @@ err:
                 BN_CTX_end(ctx);
                 BN_CTX_free(ctx);
         }
-        if (buf != NULL) {
-                explicit_bzero(buf, num);
-                free(buf);
-        }
+        freezero(buf, num);
         return r;
 }
 
@@ -700,10 +691,7 @@ err:
                 BN_CTX_end(ctx);
                 BN_CTX_free(ctx);
         }
-        if (buf != NULL) {
-                explicit_bzero(buf, num);
-                free(buf);
-        }
+        freezero(buf, num);
         return r;
 }
 
diff --git a/src/lib/libcrypto/rsa/rsa_saos.c b/src/lib/libcrypto/rsa/rsa_saos.c
index 10184b6c18..e1fbdcb5df 100644
--- a/src/lib/libcrypto/rsa/rsa_saos.c
+++ b/src/lib/libcrypto/rsa/rsa_saos.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: rsa_saos.c,v 1.22 2017/04/28 22:46:40 beck Exp $ */
+/* $OpenBSD: rsa_saos.c,v 1.23 2017/05/02 03:59:45 deraadt Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -96,8 +96,7 @@ RSA_sign_ASN1_OCTET_STRING(int type, const unsigned char *m, unsigned int m_len,
         else
                 *siglen = i;
 
-        explicit_bzero(s, (unsigned int)j + 1);
-        free(s);
+        freezero(s, (unsigned int)j + 1);
         return ret;
 }
 
@@ -137,9 +136,6 @@ RSA_verify_ASN1_OCTET_STRING(int dtype, const unsigned char *m,
                 ret = 1;
 err:
         ASN1_OCTET_STRING_free(sig);
-        if (s != NULL) {
-                explicit_bzero(s, (unsigned int)siglen);
-                free(s);
-        }
+        freezero(s, (unsigned int)siglen);
         return ret;
 }
diff --git a/src/lib/libcrypto/rsa/rsa_sign.c b/src/lib/libcrypto/rsa/rsa_sign.c
index 818b88c604..6e9e869f0a 100644
--- a/src/lib/libcrypto/rsa/rsa_sign.c
+++ b/src/lib/libcrypto/rsa/rsa_sign.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: rsa_sign.c,v 1.28 2017/04/28 22:46:40 beck Exp $ */
+/* $OpenBSD: rsa_sign.c,v 1.29 2017/05/02 03:59:45 deraadt Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -135,10 +135,8 @@ RSA_sign(int type, const unsigned char *m, unsigned int m_len,
         else
                 *siglen = i;
 
-        if (type != NID_md5_sha1) {
-                explicit_bzero(tmps, (unsigned int)j + 1);
-                free(tmps);
-        }
+        if (type != NID_md5_sha1)
+                freezero(tmps, (unsigned int)j + 1);
         return (ret);
 }
 
@@ -232,12 +230,8 @@ int_rsa_verify(int dtype, const unsigned char *m, unsigned int m_len,
                         ret = 1;
         }
 err:
-        if (sig != NULL)
-                X509_SIG_free(sig);
-        if (s != NULL) {
-                explicit_bzero(s, (unsigned int)siglen);
-                free(s);
-        }
+        X509_SIG_free(sig);
+        freezero(s, (unsigned int)siglen);
         return ret;
 }