summaryrefslogtreecommitdiff
path: root/src/lib/libssl/s3_both.c
diff options
context:
space:
mode:
Diffstat (limited to 'src/lib/libssl/s3_both.c')
-rw-r--r--src/lib/libssl/s3_both.c15
1 files changed, 9 insertions, 6 deletions
diff --git a/src/lib/libssl/s3_both.c b/src/lib/libssl/s3_both.c
index ed0fcfc532..53b9390fdd 100644
--- a/src/lib/libssl/s3_both.c
+++ b/src/lib/libssl/s3_both.c
@@ -206,10 +206,10 @@ int ssl3_send_finished(SSL *s, int a, int b, const char *sender, int slen)
206 206
207#ifndef OPENSSL_NO_NEXTPROTONEG 207#ifndef OPENSSL_NO_NEXTPROTONEG
208/* ssl3_take_mac calculates the Finished MAC for the handshakes messages seen to far. */ 208/* ssl3_take_mac calculates the Finished MAC for the handshakes messages seen to far. */
209static void ssl3_take_mac(SSL *s) { 209static void ssl3_take_mac(SSL *s)
210 {
210 const char *sender; 211 const char *sender;
211 int slen; 212 int slen;
212
213 /* If no new cipher setup return immediately: other functions will 213 /* If no new cipher setup return immediately: other functions will
214 * set the appropriate error. 214 * set the appropriate error.
215 */ 215 */
@@ -228,7 +228,7 @@ static void ssl3_take_mac(SSL *s) {
228 228
229 s->s3->tmp.peer_finish_md_len = s->method->ssl3_enc->final_finish_mac(s, 229 s->s3->tmp.peer_finish_md_len = s->method->ssl3_enc->final_finish_mac(s,
230 sender,slen,s->s3->tmp.peer_finish_md); 230 sender,slen,s->s3->tmp.peer_finish_md);
231} 231 }
232#endif 232#endif
233 233
234int ssl3_get_finished(SSL *s, int a, int b) 234int ssl3_get_finished(SSL *s, int a, int b)
@@ -238,8 +238,9 @@ int ssl3_get_finished(SSL *s, int a, int b)
238 unsigned char *p; 238 unsigned char *p;
239 239
240#ifdef OPENSSL_NO_NEXTPROTONEG 240#ifdef OPENSSL_NO_NEXTPROTONEG
241 /* the mac has already been generated when we received the change 241 /* the mac has already been generated when we received the
242 * cipher spec message and is in s->s3->tmp.peer_finish_md. */ 242 * change cipher spec message and is in s->s3->tmp.peer_finish_md.
243 */
243#endif 244#endif
244 245
245 n=s->method->ssl_get_message(s, 246 n=s->method->ssl_get_message(s,
@@ -270,7 +271,7 @@ int ssl3_get_finished(SSL *s, int a, int b)
270 goto f_err; 271 goto f_err;
271 } 272 }
272 273
273 if (timingsafe_bcmp(p, s->s3->tmp.peer_finish_md, i) != 0) 274 if (CRYPTO_memcmp(p, s->s3->tmp.peer_finish_md, i) != 0)
274 { 275 {
275 al=SSL_AD_DECRYPT_ERROR; 276 al=SSL_AD_DECRYPT_ERROR;
276 SSLerr(SSL_F_SSL3_GET_FINISHED,SSL_R_DIGEST_CHECK_FAILED); 277 SSLerr(SSL_F_SSL3_GET_FINISHED,SSL_R_DIGEST_CHECK_FAILED);
@@ -544,12 +545,14 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, long max, int *ok)
544 s->init_num += i; 545 s->init_num += i;
545 n -= i; 546 n -= i;
546 } 547 }
548
547#ifndef OPENSSL_NO_NEXTPROTONEG 549#ifndef OPENSSL_NO_NEXTPROTONEG
548 /* If receiving Finished, record MAC of prior handshake messages for 550 /* If receiving Finished, record MAC of prior handshake messages for
549 * Finished verification. */ 551 * Finished verification. */
550 if (*s->init_buf->data == SSL3_MT_FINISHED) 552 if (*s->init_buf->data == SSL3_MT_FINISHED)
551 ssl3_take_mac(s); 553 ssl3_take_mac(s);
552#endif 554#endif
555
553 /* Feed this message into MAC computation. */ 556 /* Feed this message into MAC computation. */
554 ssl3_finish_mac(s, (unsigned char *)s->init_buf->data, s->init_num + 4); 557 ssl3_finish_mac(s, (unsigned char *)s->init_buf->data, s->init_num + 4);
555 if (s->msg_callback) 558 if (s->msg_callback)