1 files changed, 77 insertions, 206 deletions

diff --git a/src/lib/libssl/s3_pkt.c b/src/lib/libssl/s3_pkt.c
index e3f6050a26..515739c08c 100644
--- a/src/lib/libssl/s3_pkt.c
+++ b/src/lib/libssl/s3_pkt.c
@@ -129,113 +129,73 @@ int ssl3_read_n(SSL *s, int n, int max, int extend)
          * (If s->read_ahead is set, 'max' bytes may be stored in rbuf
          * [plus s->packet_length bytes if extend == 1].)
          */
-        int i,len,left;
-        long align=0;
-        unsigned char *pkt;
-        SSL3_BUFFER *rb;
-
-        if (n <= 0) return n;
-
-        rb    = &(s->s3->rbuf);
-        if (rb->buf == NULL)
-                if (!ssl3_setup_read_buffer(s))
-                        return -1;
-
-        left  = rb->left;
-#if defined(SSL3_ALIGN_PAYLOAD) && SSL3_ALIGN_PAYLOAD!=0
-        align = (long)rb->buf + SSL3_RT_HEADER_LENGTH;
-        align = (-align)&(SSL3_ALIGN_PAYLOAD-1);
-#endif
+        int i,off,newb;
 
         if (!extend)
                 {
                 /* start with empty packet ... */
-                if (left == 0)
-                        rb->offset = align;
-                else if (align != 0 && left >= SSL3_RT_HEADER_LENGTH)
-                        {
-                        /* check if next packet length is large
-                         * enough to justify payload alignment... */
-                        pkt = rb->buf + rb->offset;
-                        if (pkt[0] == SSL3_RT_APPLICATION_DATA
-                            && (pkt[3]<<8|pkt[4]) >= 128)
-                                {
-                                /* Note that even if packet is corrupted
-                                 * and its length field is insane, we can
-                                 * only be led to wrong decision about
-                                 * whether memmove will occur or not.
-                                 * Header values has no effect on memmove
-                                 * arguments and therefore no buffer
-                                 * overrun can be triggered. */
-                                memmove (rb->buf+align,pkt,left);
-                                rb->offset = align;
-                                }
-                        }
-                s->packet = rb->buf + rb->offset;
+                if (s->s3->rbuf.left == 0)
+                        s->s3->rbuf.offset = 0;
+                s->packet = s->s3->rbuf.buf + s->s3->rbuf.offset;
                 s->packet_length = 0;
                 /* ... now we can act as if 'extend' was set */
                 }
 
-        /* For DTLS/UDP reads should not span multiple packets
-         * because the read operation returns the whole packet
-         * at once (as long as it fits into the buffer). */
-        if (SSL_version(s) == DTLS1_VERSION || SSL_version(s) == DTLS1_BAD_VER)
+        /* extend reads should not span multiple packets for DTLS */
+        if ( SSL_version(s) == DTLS1_VERSION &&
+                extend)
                 {
-                if (left > 0 && n > left)
-                        n = left;
+                if ( s->s3->rbuf.left > 0 && n > s->s3->rbuf.left)
+                        n = s->s3->rbuf.left;
                 }
 
         /* if there is enough in the buffer from a previous read, take some */
-        if (left >= n)
+        if (s->s3->rbuf.left >= (int)n)
                 {
                 s->packet_length+=n;
-                rb->left=left-n;
-                rb->offset+=n;
+                s->s3->rbuf.left-=n;
+                s->s3->rbuf.offset+=n;
                 return(n);
                 }
 
         /* else we need to read more data */
+        if (!s->read_ahead)
+                max=n;
 
-        len = s->packet_length;
-        pkt = rb->buf+align;
-        /* Move any available bytes to front of buffer:
-         * 'len' bytes already pointed to by 'packet',
-         * 'left' extra ones at the end */
-        if (s->packet != pkt) /* len > 0 */
-                {
-                memmove(pkt, s->packet, len+left);
-                s->packet = pkt;
-                rb->offset = len + align;
-                }
-
-        if (n > (int)(rb->len - rb->offset)) /* does not happen */
+        {
+                /* avoid buffer overflow */
+                int max_max = s->s3->rbuf.len - s->packet_length;
+                if (max > max_max)
+                        max = max_max;
+        }
+        if (n > max) /* does not happen */
                 {
                 SSLerr(SSL_F_SSL3_READ_N,ERR_R_INTERNAL_ERROR);
                 return -1;
                 }
 
-        if (!s->read_ahead)
-                /* ignore max parameter */
-                max = n;
-        else
+        off = s->packet_length;
+        newb = s->s3->rbuf.left;
+        /* Move any available bytes to front of buffer:
+         * 'off' bytes already pointed to by 'packet',
+         * 'newb' extra ones at the end */
+        if (s->packet != s->s3->rbuf.buf)
                 {
-                if (max < n)
-                        max = n;
-                if (max > (int)(rb->len - rb->offset))
-                        max = rb->len - rb->offset;
+                /*  off > 0 */
+                memmove(s->s3->rbuf.buf, s->packet, off+newb);
+                s->packet = s->s3->rbuf.buf;
                 }
 
-        while (left < n)
+        while (newb < n)
                 {
-                /* Now we have len+left bytes at the front of s->s3->rbuf.buf
-                 * and need to read in more until we have len+n (up to
-                 * len+max if possible) */
+                /* Now we have off+newb bytes at the front of s->s3->rbuf.buf and need
+                 * to read in more until we have off+n (up to off+max if possible) */
 
                 clear_sys_error();
                 if (s->rbio != NULL)
                         {
                         s->rwstate=SSL_READING;
-                        i=BIO_read(s->rbio,pkt+len+left, max-left);
+                        i=BIO_read(s->rbio,     &(s->s3->rbuf.buf[off+newb]), max-newb);
                         }
                 else
                         {
@@ -245,26 +205,15 @@ int ssl3_read_n(SSL *s, int n, int max, int extend)
 
                 if (i <= 0)
                         {
-                        rb->left = left;
-                        if (s->mode & SSL_MODE_RELEASE_BUFFERS)
-                                if (len+left == 0)
-                                        ssl3_release_read_buffer(s);
+                        s->s3->rbuf.left = newb;
                         return(i);
                         }
-                left+=i;
-                /* reads should *never* span multiple packets for DTLS because
-                 * the underlying transport protocol is message oriented as opposed
-                 * to byte oriented as in the TLS case. */
-                if (SSL_version(s) == DTLS1_VERSION || SSL_version(s) == DTLS1_BAD_VER)
-                        {
-                        if (n > left)
-                                n = left; /* makes the while condition false */
-                        }
+                newb+=i;
                 }
 
         /* done reading, now the book-keeping */
-        rb->offset += n;
-        rb->left = left - n;
+        s->s3->rbuf.offset = off + n;
+        s->s3->rbuf.left = newb - n;
         s->packet_length += n;
         s->rwstate=SSL_NOTHING;
         return(n);
@@ -288,7 +237,7 @@ static int ssl3_get_record(SSL *s)
         unsigned char *p;
         unsigned char md[EVP_MAX_MD_SIZE];
         short version;
-        int mac_size;
+        unsigned int mac_size;
         int clear=0;
         size_t extra;
         int decryption_failed_or_bad_record_mac = 0;
@@ -301,9 +250,9 @@ static int ssl3_get_record(SSL *s)
                 extra=SSL3_RT_MAX_EXTRA;
         else
                 extra=0;
-        if (extra && !s->s3->init_extra)
+        if (extra != s->s3->rbuf.len - SSL3_RT_MAX_PACKET_SIZE)
                 {
-                /* An application error: SLS_OP_MICROSOFT_BIG_SSLV3_BUFFER
+                /* actually likely an application error: SLS_OP_MICROSOFT_BIG_SSLV3_BUFFER
                  * set after ssl3_setup_buffers() was done */
                 SSLerr(SSL_F_SSL3_GET_RECORD, ERR_R_INTERNAL_ERROR);
                 return -1;
@@ -326,9 +275,6 @@ again:
                 ssl_minor= *(p++);
                 version=(ssl_major<<8)|ssl_minor;
                 n2s(p,rr->length);
-#if 0
-fprintf(stderr, "Record type=%d, Length=%d\n", rr->type, rr->length);
-#endif
 
                 /* Lets check version */
                 if (!s->first_packet)
@@ -337,7 +283,8 @@ fprintf(stderr, "Record type=%d, Length=%d\n", rr->type, rr->length);
                                 {
                                 SSLerr(SSL_F_SSL3_GET_RECORD,SSL_R_WRONG_VERSION_NUMBER);
                                 if ((s->version & 0xFF00) == (version & 0xFF00))
-                                        /* Send back error using their minor version number :-) */
+                                        /* Send back error using their
+                                         * minor version number :-) */
                                         s->version = (unsigned short)version;
                                 al=SSL_AD_PROTOCOL_VERSION;
                                 goto f_err;
@@ -350,7 +297,7 @@ fprintf(stderr, "Record type=%d, Length=%d\n", rr->type, rr->length);
                         goto err;
                         }
 
-                if (rr->length > s->s3->rbuf.len - SSL3_RT_HEADER_LENGTH)
+                if (rr->length > SSL3_RT_MAX_ENCRYPTED_LENGTH+extra)
                         {
                         al=SSL_AD_RECORD_OVERFLOW;
                         SSLerr(SSL_F_SSL3_GET_RECORD,SSL_R_PACKET_LENGTH_TOO_LONG);
@@ -423,14 +370,12 @@ printf("\n");
         /* r->length is now the compressed data plus mac */
         if (    (sess == NULL) ||
                 (s->enc_read_ctx == NULL) ||
-                (EVP_MD_CTX_md(s->read_hash) == NULL))
+                (s->read_hash == NULL))
                 clear=1;
 
         if (!clear)
                 {
-                /* !clear => s->read_hash != NULL => mac_size != -1 */
-                mac_size=EVP_MD_CTX_size(s->read_hash);
-                OPENSSL_assert(mac_size >= 0);
+                mac_size=EVP_MD_size(s->read_hash);
 
                 if (rr->length > SSL3_RT_MAX_COMPRESSED_LENGTH+extra+mac_size)
                         {
@@ -443,7 +388,7 @@ printf("\n");
 #endif                  
                         }
                 /* check the MAC for rr->input (it's in mac_size bytes at the tail) */
-                if (rr->length >= (unsigned int)mac_size)
+                if (rr->length >= mac_size)
                         {
                         rr->length -= mac_size;
                         mac = &rr->data[rr->length];
@@ -461,7 +406,7 @@ printf("\n");
 #endif
                         }
                 i=s->method->ssl3_enc->mac(s,md,0);
-                if (i < 0 || mac == NULL || memcmp(md, mac, (size_t)mac_size) != 0)
+                if (mac == NULL || memcmp(md, mac, mac_size) != 0)
                         {
                         decryption_failed_or_bad_record_mac = 1;
                         }
@@ -518,10 +463,6 @@ printf("\n");
         /* just read a 0 length packet */
         if (rr->length == 0) goto again;
 
-#if 0
-fprintf(stderr, "Ultimate Record type=%d, Length=%d\n", rr->type, rr->length);
-#endif
-
         return(1);
 
 f_err:
@@ -595,8 +536,8 @@ int ssl3_write_bytes(SSL *s, int type, const void *buf_, int len)
         n=(len-tot);
         for (;;)
                 {
-                if (n > s->max_send_fragment)
-                        nw=s->max_send_fragment;
+                if (n > SSL3_RT_MAX_PLAIN_LENGTH)
+                        nw=SSL3_RT_MAX_PLAIN_LENGTH;
                 else
                         nw=n;
 
@@ -628,19 +569,14 @@ static int do_ssl3_write(SSL *s, int type, const unsigned char *buf,
         {
         unsigned char *p,*plen;
         int i,mac_size,clear=0;
-        int prefix_len=0;
-        long align=0;
+        int prefix_len = 0;
         SSL3_RECORD *wr;
-        SSL3_BUFFER *wb=&(s->s3->wbuf);
+        SSL3_BUFFER *wb;
         SSL_SESSION *sess;
 
-        if (wb->buf == NULL)
-                if (!ssl3_setup_write_buffer(s))
-                        return -1;
-
         /* first check if there is a SSL3_BUFFER still being written
          * out.  This will happen with non blocking IO */
-        if (wb->left != 0)
+        if (s->s3->wbuf.left != 0)
                 return(ssl3_write_pending(s,type,buf,len));
 
         /* If we have an alert to send, lets send it */
@@ -656,21 +592,18 @@ static int do_ssl3_write(SSL *s, int type, const unsigned char *buf,
                 return 0;
 
         wr= &(s->s3->wrec);
+        wb= &(s->s3->wbuf);
         sess=s->session;
 
         if (    (sess == NULL) ||
                 (s->enc_write_ctx == NULL) ||
-                (EVP_MD_CTX_md(s->write_hash) == NULL))
+                (s->write_hash == NULL))
                 clear=1;
 
         if (clear)
                 mac_size=0;
         else
-                {
-                mac_size=EVP_MD_CTX_size(s->write_hash);
-                if (mac_size < 0)
-                        goto err;
-                }
+                mac_size=EVP_MD_size(s->write_hash);
 
         /* 'create_empty_fragment' is true only when this function calls itself */
         if (!clear && !create_empty_fragment && !s->s3->empty_fragment_done)
@@ -688,8 +621,7 @@ static int do_ssl3_write(SSL *s, int type, const unsigned char *buf,
                         if (prefix_len <= 0)
                                 goto err;
 
-                        if (prefix_len >
-                (SSL3_RT_HEADER_LENGTH + SSL3_RT_SEND_MAX_ENCRYPTED_OVERHEAD))
+                        if (s->s3->wbuf.len < (size_t)prefix_len + SSL3_RT_MAX_PACKET_SIZE)
                                 {
                                 /* insufficient space */
                                 SSLerr(SSL_F_DO_SSL3_WRITE, ERR_R_INTERNAL_ERROR);
@@ -700,32 +632,7 @@ static int do_ssl3_write(SSL *s, int type, const unsigned char *buf,
                 s->s3->empty_fragment_done = 1;
                 }
 
-        if (create_empty_fragment)
-                {
-#if defined(SSL3_ALIGN_PAYLOAD) && SSL3_ALIGN_PAYLOAD!=0
-                /* extra fragment would be couple of cipher blocks,
-                 * which would be multiple of SSL3_ALIGN_PAYLOAD, so
-                 * if we want to align the real payload, then we can
-                 * just pretent we simply have two headers. */
-                align = (long)wb->buf + 2*SSL3_RT_HEADER_LENGTH;
-                align = (-align)&(SSL3_ALIGN_PAYLOAD-1);
-#endif
-                p = wb->buf + align;
-                wb->offset  = align;
-                }
-        else if (prefix_len)
-                {
-                p = wb->buf + wb->offset + prefix_len;
-                }
-        else
-                {
-#if defined(SSL3_ALIGN_PAYLOAD) && SSL3_ALIGN_PAYLOAD!=0
-                align = (long)wb->buf + SSL3_RT_HEADER_LENGTH;
-                align = (-align)&(SSL3_ALIGN_PAYLOAD-1);
-#endif
-                p = wb->buf + align;
-                wb->offset  = align;
-                }
+        p = wb->buf + prefix_len;
 
         /* write the header */
 
@@ -768,8 +675,7 @@ static int do_ssl3_write(SSL *s, int type, const unsigned char *buf,
 
         if (mac_size != 0)
                 {
-                if (s->method->ssl3_enc->mac(s,&(p[wr->length]),1) < 0)
-                        goto err;
+                s->method->ssl3_enc->mac(s,&(p[wr->length]),1);
                 wr->length+=mac_size;
                 wr->input=p;
                 wr->data=p;
@@ -797,6 +703,7 @@ static int do_ssl3_write(SSL *s, int type, const unsigned char *buf,
 
         /* now let's set up wb */
         wb->left = prefix_len + wr->length;
+        wb->offset = 0;
 
         /* memorize arguments so that ssl3_write_pending can detect bad write retries later */
         s->s3->wpend_tot=len;
@@ -815,7 +722,6 @@ int ssl3_write_pending(SSL *s, int type, const unsigned char *buf,
         unsigned int len)
         {
         int i;
-        SSL3_BUFFER *wb=&(s->s3->wbuf);
 
 /* XXXX */
         if ((s->s3->wpend_tot > (int)len)
@@ -834,20 +740,17 @@ int ssl3_write_pending(SSL *s, int type, const unsigned char *buf,
                         {
                         s->rwstate=SSL_WRITING;
                         i=BIO_write(s->wbio,
-                                (char *)&(wb->buf[wb->offset]),
-                                (unsigned int)wb->left);
+                                (char *)&(s->s3->wbuf.buf[s->s3->wbuf.offset]),
+                                (unsigned int)s->s3->wbuf.left);
                         }
                 else
                         {
                         SSLerr(SSL_F_SSL3_WRITE_PENDING,SSL_R_BIO_NOT_SET);
                         i= -1;
                         }
-                if (i == wb->left)
+                if (i == s->s3->wbuf.left)
                         {
-                        wb->left=0;
-                        wb->offset+=i;
-                        if (s->mode & SSL_MODE_RELEASE_BUFFERS)
-                                ssl3_release_write_buffer(s);
+                        s->s3->wbuf.left=0;
                         s->rwstate=SSL_NOTHING;
                         return(s->s3->wpend_ret);
                         }
@@ -856,12 +759,12 @@ int ssl3_write_pending(SSL *s, int type, const unsigned char *buf,
                             s->version == DTLS1_BAD_VER) {
                                 /* For DTLS, just drop it. That's kind of the whole
                                    point in using a datagram service */
-                                wb->left = 0;
+                                s->s3->wbuf.left = 0;
                         }
                         return(i);
                 }
-                wb->offset+=i;
-                wb->left-=i;
+                s->s3->wbuf.offset+=i;
+                s->s3->wbuf.left-=i;
                 }
         }
 
@@ -900,7 +803,7 @@ int ssl3_read_bytes(SSL *s, int type, unsigned char *buf, int len, int peek)
         void (*cb)(const SSL *ssl,int type2,int val)=NULL;
 
         if (s->s3->rbuf.buf == NULL) /* Not initialized yet */
-                if (!ssl3_setup_read_buffer(s))
+                if (!ssl3_setup_buffers(s))
                         return(-1);
 
         if ((type && (type != SSL3_RT_APPLICATION_DATA) && (type != SSL3_RT_HANDSHAKE) && type) ||
@@ -1009,8 +912,6 @@ start:
                                 {
                                 s->rstate=SSL_ST_READ_HEADER;
                                 rr->off=0;
-                                if (s->mode & SSL_MODE_RELEASE_BUFFERS)
-                                        ssl3_release_read_buffer(s);
                                 }
                         }
                 return(n);
@@ -1085,6 +986,7 @@ start:
 
                 if (SSL_is_init_finished(s) &&
                         !(s->s3->flags & SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS) &&
+                        (s->s3->flags & SSL3_FLAGS_ALLOW_UNSAFE_LEGACY_RENEGOTIATION) &&
                         !s->s3->renegotiate)
                         {
                         ssl3_renegotiate(s);
@@ -1120,25 +1022,7 @@ start:
                  * now try again to obtain the (application) data we were asked for */
                 goto start;
                 }
-        /* If we are a server and get a client hello when renegotiation isn't
-         * allowed send back a no renegotiation alert and carry on.
-         * WARNING: experimental code, needs reviewing (steve)
-         */
-        if (s->server &&
-                SSL_is_init_finished(s) &&
-                !s->s3->send_connection_binding &&
-                (s->version > SSL3_VERSION) &&
-                (s->s3->handshake_fragment_len >= 4) &&
-                (s->s3->handshake_fragment[0] == SSL3_MT_CLIENT_HELLO) &&
-                (s->session != NULL) && (s->session->cipher != NULL) &&
-                !(s->ctx->options & SSL_OP_ALLOW_UNSAFE_LEGACY_RENEGOTIATION))
-                
-                {
-                /*s->s3->handshake_fragment_len = 0;*/
-                rr->length = 0;
-                ssl3_send_alert(s,SSL3_AL_WARNING, SSL_AD_NO_RENEGOTIATION);
-                goto start;
-                }
+
         if (s->s3->alert_fragment_len >= 2)
                 {
                 int alert_level = s->s3->alert_fragment[0];
@@ -1168,21 +1052,6 @@ start:
                                 s->shutdown |= SSL_RECEIVED_SHUTDOWN;
                                 return(0);
                                 }
-                        /* This is a warning but we receive it if we requested
-                         * renegotiation and the peer denied it. Terminate with
-                         * a fatal alert because if application tried to
-                         * renegotiatie it presumably had a good reason and
-                         * expects it to succeed.
-                         *
-                         * In future we might have a renegotiation where we
-                         * don't care if the peer refused it where we carry on.
-                         */
-                        else if (alert_descr == SSL_AD_NO_RENEGOTIATION)
-                                {
-                                al = SSL_AD_HANDSHAKE_FAILURE;
-                                SSLerr(SSL_F_SSL3_READ_BYTES,SSL_R_NO_RENEGOTIATION);
-                                goto f_err;
-                                }
                         }
                 else if (alert_level == 2) /* fatal */
                         {
@@ -1250,7 +1119,8 @@ start:
         if ((s->s3->handshake_fragment_len >= 4) &&     !s->in_handshake)
                 {
                 if (((s->state&SSL_ST_MASK) == SSL_ST_OK) &&
-                        !(s->s3->flags & SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS))
+                        !(s->s3->flags & SSL3_FLAGS_NO_RENEGOTIATE_CIPHERS) &&
+                        (s->s3->flags & SSL3_FLAGS_ALLOW_UNSAFE_LEGACY_RENEGOTIATION))
                         {
 #if 0 /* worked only because C operator preferences are not as expected (and
        * because this is not really needed for clients except for detecting
@@ -1394,18 +1264,20 @@ int ssl3_do_change_cipher_spec(SSL *s)
                 }
 
         s->s3->tmp.peer_finish_md_len = s->method->ssl3_enc->final_finish_mac(s,
+                &(s->s3->finish_dgst1),
+                &(s->s3->finish_dgst2),
                 sender,slen,s->s3->tmp.peer_finish_md);
 
         return(1);
         }
 
-int ssl3_send_alert(SSL *s, int level, int desc)
+void ssl3_send_alert(SSL *s, int level, int desc)
         {
         /* Map tls/ssl alert value to correct one */
         desc=s->method->ssl3_enc->alert_value(desc);
         if (s->version == SSL3_VERSION && desc == SSL_AD_PROTOCOL_VERSION)
                 desc = SSL_AD_HANDSHAKE_FAILURE; /* SSL 3.0 does not have protocol_version alerts */
-        if (desc < 0) return -1;
+        if (desc < 0) return;
         /* If a fatal one, remove from cache */
         if ((level == 2) && (s->session != NULL))
                 SSL_CTX_remove_session(s->ctx,s->session);
@@ -1414,10 +1286,9 @@ int ssl3_send_alert(SSL *s, int level, int desc)
         s->s3->send_alert[0]=level;
         s->s3->send_alert[1]=desc;
         if (s->s3->wbuf.left == 0) /* data still being written out? */
-                return s->method->ssl_dispatch_alert(s);
+                s->method->ssl_dispatch_alert(s);
         /* else data is still being written out, we will get written
          * some time in the future */
-        return -1;
         }
 
 int ssl3_dispatch_alert(SSL *s)