1 files changed, 11 insertions, 113 deletions

diff --git a/src/lib/libssl/ssl_asn1.c b/src/lib/libssl/ssl_asn1.c
index 6e14f4d834..fc5fcce108 100644
--- a/src/lib/libssl/ssl_asn1.c
+++ b/src/lib/libssl/ssl_asn1.c
@@ -78,11 +78,6 @@ typedef struct ssl_session_asn1_st
         ASN1_INTEGER time;
         ASN1_INTEGER timeout;
         ASN1_INTEGER verify_result;
-#ifndef OPENSSL_NO_TLSEXT
-        ASN1_OCTET_STRING tlsext_hostname;
-        ASN1_INTEGER tlsext_tick_lifetime;
-        ASN1_OCTET_STRING tlsext_tick;
-#endif /* OPENSSL_NO_TLSEXT */
         } SSL_SESSION_ASN1;
 
 int i2d_SSL_SESSION(SSL_SESSION *in, unsigned char **pp)
@@ -91,10 +86,6 @@ int i2d_SSL_SESSION(SSL_SESSION *in, unsigned char **pp)
         int v1=0,v2=0,v3=0,v4=0,v5=0;
         unsigned char buf[4],ibuf1[LSIZE2],ibuf2[LSIZE2];
         unsigned char ibuf3[LSIZE2],ibuf4[LSIZE2],ibuf5[LSIZE2];
-#ifndef OPENSSL_NO_TLSEXT
-        int v6=0,v9=0,v10=0;
-        unsigned char ibuf6[LSIZE2];
-#endif
         long l;
         SSL_SESSION_ASN1 a;
         M_ASN1_I2D_vars(in);
@@ -187,33 +178,7 @@ int i2d_SSL_SESSION(SSL_SESSION *in, unsigned char **pp)
                 ASN1_INTEGER_set(&a.verify_result,in->verify_result);
                 }
 
-#ifndef OPENSSL_NO_TLSEXT
-        if (in->tlsext_hostname)
-                {
-                a.tlsext_hostname.length=strlen(in->tlsext_hostname);
-                a.tlsext_hostname.type=V_ASN1_OCTET_STRING;
-                a.tlsext_hostname.data=(unsigned char *)in->tlsext_hostname;
-                }
-        if (in->tlsext_tick)
-                {
-                a.tlsext_tick.length= in->tlsext_ticklen;
-                a.tlsext_tick.type=V_ASN1_OCTET_STRING;
-                a.tlsext_tick.data=(unsigned char *)in->tlsext_tick;
-                /* If we have a ticket set session ID to empty because
-                 * it will be bogus. If liftime hint is -1 treat as a special
-                 * case because the session is being used as a container
-                 */
-                if (in->tlsext_ticklen && (in->tlsext_tick_lifetime_hint != -1))
-                        a.session_id.length=0;
-                }
-        if (in->tlsext_tick_lifetime_hint > 0)
-                {
-                a.tlsext_tick_lifetime.length=LSIZE2;
-                a.tlsext_tick_lifetime.type=V_ASN1_INTEGER;
-                a.tlsext_tick_lifetime.data=ibuf6;
-                ASN1_INTEGER_set(&a.tlsext_tick_lifetime,in->tlsext_tick_lifetime_hint);
-                }
-#endif /* OPENSSL_NO_TLSEXT */
+
         M_ASN1_I2D_len(&(a.version),            i2d_ASN1_INTEGER);
         M_ASN1_I2D_len(&(a.ssl_version),        i2d_ASN1_INTEGER);
         M_ASN1_I2D_len(&(a.cipher),             i2d_ASN1_OCTET_STRING);
@@ -235,14 +200,6 @@ int i2d_SSL_SESSION(SSL_SESSION *in, unsigned char **pp)
         if (in->verify_result != X509_V_OK)
                 M_ASN1_I2D_len_EXP_opt(&(a.verify_result),i2d_ASN1_INTEGER,5,v5);
 
-#ifndef OPENSSL_NO_TLSEXT
-        if (in->tlsext_tick_lifetime_hint > 0)
-                M_ASN1_I2D_len_EXP_opt(&a.tlsext_tick_lifetime, i2d_ASN1_INTEGER,9,v9);
-        if (in->tlsext_tick)
-                M_ASN1_I2D_len_EXP_opt(&(a.tlsext_tick), i2d_ASN1_OCTET_STRING,10,v10);
-        if (in->tlsext_hostname)
-                M_ASN1_I2D_len_EXP_opt(&(a.tlsext_hostname), i2d_ASN1_OCTET_STRING,6,v6);
-#endif /* OPENSSL_NO_TLSEXT */
         M_ASN1_I2D_seq_total();
 
         M_ASN1_I2D_put(&(a.version),            i2d_ASN1_INTEGER);
@@ -266,18 +223,10 @@ int i2d_SSL_SESSION(SSL_SESSION *in, unsigned char **pp)
                                v4);
         if (in->verify_result != X509_V_OK)
                 M_ASN1_I2D_put_EXP_opt(&a.verify_result,i2d_ASN1_INTEGER,5,v5);
-#ifndef OPENSSL_NO_TLSEXT
-        if (in->tlsext_hostname)
-                M_ASN1_I2D_put_EXP_opt(&(a.tlsext_hostname), i2d_ASN1_OCTET_STRING,6,v6);
-        if (in->tlsext_tick_lifetime_hint > 0)
-                M_ASN1_I2D_put_EXP_opt(&a.tlsext_tick_lifetime, i2d_ASN1_INTEGER,9,v9);
-        if (in->tlsext_tick)
-                M_ASN1_I2D_put_EXP_opt(&(a.tlsext_tick), i2d_ASN1_OCTET_STRING,10,v10);
-#endif /* OPENSSL_NO_TLSEXT */
         M_ASN1_I2D_finish();
         }
 
-SSL_SESSION *d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp,
+SSL_SESSION *d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char * const *pp,
              long length)
         {
         int version,ssl_version=0,i;
@@ -293,18 +242,18 @@ SSL_SESSION *d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp,
         M_ASN1_D2I_start_sequence();
 
         ai.data=NULL; ai.length=0;
-        M_ASN1_D2I_get_x(ASN1_INTEGER,aip,d2i_ASN1_INTEGER);
+        M_ASN1_D2I_get(aip,d2i_ASN1_INTEGER);
         version=(int)ASN1_INTEGER_get(aip);
         if (ai.data != NULL) { OPENSSL_free(ai.data); ai.data=NULL; ai.length=0; }
 
         /* we don't care about the version right now :-) */
-        M_ASN1_D2I_get_x(ASN1_INTEGER,aip,d2i_ASN1_INTEGER);
+        M_ASN1_D2I_get(aip,d2i_ASN1_INTEGER);
         ssl_version=(int)ASN1_INTEGER_get(aip);
         ret->ssl_version=ssl_version;
         if (ai.data != NULL) { OPENSSL_free(ai.data); ai.data=NULL; ai.length=0; }
 
         os.data=NULL; os.length=0;
-        M_ASN1_D2I_get_x(ASN1_OCTET_STRING,osp,d2i_ASN1_OCTET_STRING);
+        M_ASN1_D2I_get(osp,d2i_ASN1_OCTET_STRING);
         if (ssl_version == SSL2_VERSION)
                 {
                 if (os.length != 3)
@@ -337,22 +286,22 @@ SSL_SESSION *d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp,
         ret->cipher=NULL;
         ret->cipher_id=id;
 
-        M_ASN1_D2I_get_x(ASN1_OCTET_STRING,osp,d2i_ASN1_OCTET_STRING);
+        M_ASN1_D2I_get(osp,d2i_ASN1_OCTET_STRING);
         if ((ssl_version>>8) == SSL3_VERSION_MAJOR)
                 i=SSL3_MAX_SSL_SESSION_ID_LENGTH;
-        else /* if (ssl_version>>8 == SSL2_VERSION_MAJOR) */
+        else /* if (ssl_version == SSL2_VERSION_MAJOR) */
                 i=SSL2_MAX_SSL_SESSION_ID_LENGTH;
 
         if (os.length > i)
                 os.length = i;
-        if (os.length > (int)sizeof(ret->session_id)) /* can't happen */
-                os.length = sizeof(ret->session_id);
+        if (os.length > sizeof ret->session_id) /* can't happen */
+                os.length = sizeof ret->session_id;
 
         ret->session_id_length=os.length;
-        OPENSSL_assert(os.length <= (int)sizeof(ret->session_id));
+        OPENSSL_assert(os.length <= sizeof ret->session_id);
         memcpy(ret->session_id,os.data,os.length);
 
-        M_ASN1_D2I_get_x(ASN1_OCTET_STRING,osp,d2i_ASN1_OCTET_STRING);
+        M_ASN1_D2I_get(osp,d2i_ASN1_OCTET_STRING);
         if (ret->master_key_length > SSL_MAX_MASTER_KEY_LENGTH)
                 ret->master_key_length=SSL_MAX_MASTER_KEY_LENGTH;
         else
@@ -445,56 +394,5 @@ SSL_SESSION *d2i_SSL_SESSION(SSL_SESSION **a, const unsigned char **pp,
         else
                 ret->verify_result=X509_V_OK;
 
-#ifndef OPENSSL_NO_TLSEXT
-        os.length=0;
-        os.data=NULL;
-        M_ASN1_D2I_get_EXP_opt(osp,d2i_ASN1_OCTET_STRING,6);
-        if (os.data)
-                {
-                ret->tlsext_hostname = BUF_strndup((char *)os.data, os.length);
-                OPENSSL_free(os.data);
-                os.data = NULL;
-                os.length = 0;
-                }
-        else
-                ret->tlsext_hostname=NULL;
-        ai.length=0;
-        M_ASN1_D2I_get_EXP_opt(aip,d2i_ASN1_INTEGER,9);
-        if (ai.data != NULL)
-                {
-                ret->tlsext_tick_lifetime_hint=ASN1_INTEGER_get(aip);
-                OPENSSL_free(ai.data); ai.data=NULL; ai.length=0;
-                }
-        else if (ret->tlsext_ticklen && ret->session_id_length)
-                ret->tlsext_tick_lifetime_hint = -1;
-        else
-                ret->tlsext_tick_lifetime_hint = 0;
-        os.length=0;
-        os.data=NULL;
-        M_ASN1_D2I_get_EXP_opt(osp,d2i_ASN1_OCTET_STRING,10);
-        if (os.data)
-                {
-                ret->tlsext_tick = os.data;
-                ret->tlsext_ticklen = os.length;
-                os.data = NULL;
-                os.length = 0;
-#if 0
-                /* There are two ways to detect a resumed ticket sesion.
-                 * One is to set a random session ID and then the server
-                 * must return a match in ServerHello. This allows the normal
-                 * client session ID matching to work.
-                 */ 
-                if (ret->session_id_length == 0)
-                        {
-                        ret->session_id_length=SSL3_MAX_SSL_SESSION_ID_LENGTH;
-                        RAND_pseudo_bytes(ret->session_id,
-                                                ret->session_id_length);
-                        }
-#endif
-                }
-        else
-                ret->tlsext_tick=NULL;
-#endif /* OPENSSL_NO_TLSEXT */
-
         M_ASN1_D2I_Finish(a,SSL_SESSION_free,SSL_F_D2I_SSL_SESSION);
         }