summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Use V_ASN1_UNDEF instead of -1.miod2015-07-202-14/+14
| | | | | | | Make sure ASN1_primitive_new() will return NULL in *pval in all error situations. ok bcook@ doug@
* Check the return value of asn1_enc_save(). ok bcook@ doug@miod2015-07-202-4/+8
|
* When freeing an X509_CRL, if freeing the user-maintained meth_data fails,miod2015-07-202-6/+8
| | | | | do not forgot to nevertheless keep freeing the other fields. ok doug@ guenther@
* In X509_PKEY_new(), make sure all allocation failures push an error to themiod2015-07-202-14/+30
| | | | | error stack, not only the first one. ok guenther@ doug@
* add NetLock Kft. CA root certificate, already present in web browsers andsteven2015-07-201-0/+80
| | | | | needed for fetching ports distfiles. ok sthen@
* Check return value for ENGINE_ctrl and ENGINE_ctrl_cmd.doug2015-07-201-4/+15
| | | | | | Fixes Coverity issue 21645. ok bcook@
* Check return value in openssl(1) s_socket.doug2015-07-201-3/+6
| | | | | | Fixes Coverity issue 21655. ok bcook@
* Remove check that is never true.doug2015-07-201-3/+1
| | | | | | | Fixes coverity issue 78799 as group == NULL was already an error condition above here. ok beck@
* Warn when rename() fails in openssl(1) apps.doug2015-07-201-8/+36
| | | | | | Fixes Coverity issues 78795 and 78803. ok bcook@
* Add VIS_DQ to escape double quotes. OK deraadt@ semarie@ reyk@millert2015-07-201-1/+3
|
* Remove OpenSSL engine RSAX.doug2015-07-1914-1409/+12
| | | | | | | | | OpenSSL stopped building it last year and removed it this year. Based on OpenSSL commit c436e05bdc7f49985a750df64122c960240b3ae1. Also cranked major version in libcrypto, libssl and libtls. "fine with me" bcook@ miod@
* Allow *_free() functions in libssl to handle NULL input.doug2015-07-199-9/+34
| | | | | | This mimics free()'s behavior which makes error handling simpler. ok bcook@ miod@
* Drop stupid (int) casts for the arguments of malloc() and friends. This ismiod2015-07-1918-48/+48
| | | | | not 16-bit MS-DOS anymore. ok bcook@ tedu@
* unifdef -UCBC_HANDLES_TRUNCATED_IOmiod2015-07-192-38/+2
| | | | ok bcook@ doug@
* Verify ASN1 objects types before attempting to access them as a particularmiod2015-07-194-4/+12
| | | | | type. ok guenther@ doug@
* tweak previous; ok dougjmc2015-07-191-4/+4
|
* Convert ssl3_get_certificate_request to CBS.doug2015-07-192-62/+66
| | | | ok miod@
* Fix symbol collision with libtls.doug2015-07-197-36/+36
| | | | | | Pointed out by guenther. ok guenther@
* Add TLS_method, TLS_client_method and TLS_server_method.doug2015-07-199-9/+321
| | | | | | | | | | | | | | | | Use these instead of SSLv23_*method when you want to make sure TLS is used. By default, we disable SSLv3 but it's still possible for the user to re-enable it. TLS_*method does not allow SSLv3. Both BoringSSL and (next version of) OpenSSL have these methods. However, they have changed the implementation significantly. We will as well, but not right now. Riding the libssl major bump. ok miod@ bcook@
* Crank major and remove legacy variables.doug2015-07-196-30/+6
| | | | | | Libtls is riding this crank. ok miod@ bcook@
* Crank the major of libtls: the behaviour of tls_write() has beenreyk2015-07-191-1/+1
| | | | | | changed in an incompatible way regarding partial writes. OK miod@ deraadt@
* Free memory when finished.doug2015-07-191-2/+6
| | | | | | Fixes coverity 78835. ok bcook@
* Add documentation on how to use TLS_{READ,WRITE}_AGAIN.doug2015-07-191-2/+29
| | | | ok beck@
* Now that it is safe to invoke X509_STORE_CTX_cleanup() if X509_STORE_CTX_init()miod2015-07-194-16/+32
| | | | | fails, check its return value and correctly mop up after ourselves. ok beck@ doug@
* Only close descriptor if not already closed.doug2015-07-191-3/+5
| | | | | | Fixes coverity 78916. ok miod@ bcook@
* Free variable before potentially reusing.doug2015-07-191-1/+2
| | | | | | Fixes coverity 78824. ok bcook@ miod@
* Free passin on error.doug2015-07-191-4/+4
| | | | | | Fixes coverity 78826. ok miod@ bcook@
* Fix coverity 105339, by correctly checking return from strtollbeck2015-07-191-1/+1
| | | | ok miod@ bcook@
* Put explicit braces around assignment used in a conditional.miod2015-07-192-4/+4
| | | | ok bcook@ doug@
* Remove the logic responsible for outputting most AES-NI instructions asmiod2015-07-196-214/+0
| | | | | | | | | raw byte sequences. The toolchains have had some time to update and assemble the instructions correctly (except for p{ins,ext}rd which are not supported yet by as(1) under OpenBSD, but will be fixed shortly). Inspired by a discussion between tedu@ and John-Mark Gurney. Verified to still work on Mac OS X and average Linux distros by bcook@
* Replace `.byte 0x48,0x83,0xEC,0x08' with `sub \$8,%rsp' which is exactly themiod2015-07-192-4/+4
| | | | same four bytes, unobfuscated.
* Simplify X509_STORE_CTX_init and make it safe with stack variables.doug2015-07-192-116/+110
| | | | | | | The current version is not safe with stack variables because it may return prematurely with a partially constructed object on error. ok miod@ a while back
* Remove case that can never happen.doug2015-07-192-10/+2
| | | | | | | It's a little convoluted due to gotos, but at that point, pci is always NULL. Spotted by Coverity 21702. ok miod@ beck@ bcook@
* Fix Coverity 72742 - ret is overwritten immediately after this.beck2015-07-192-4/+2
| | | | ok doug@
* Remove effectively unused variable.doug2015-07-191-4/+1
| | | | | | Fixes Coverity issue 21693. ok beck@ bcook@
* Assign p to CBS_data since it is used later.doug2015-07-192-4/+6
| | | | | | The p initialization was hiding this bug but Coverity 126279 saw it. ok miod@ bcook@ beck@
* abort when ENGINE_remove fails, fix Coverity 21656bcook2015-07-192-10/+4
| | | | ok doug@, beck@
* Convert dtls1_get_message_header to CBS and change to int.doug2015-07-186-32/+74
| | | | | | | Changed return value from void to int. It should never return an error given that the input length is not checked yet. ok miod@
* rand_err doesn't exist anymore, coverity 78808beck2015-07-182-6/+6
| | | | ok doug@
* Coverity 21651beck2015-07-182-6/+14
| | | | ok doug@
* Convert dtls1_get_record to CBS.doug2015-07-182-42/+56
| | | | ok miod@, input + ok jsing@
* Remove repeated code in dtls1_get_record.doug2015-07-182-80/+32
| | | | | | | | The "if" is a bit ugly, but this does remove a lot of repetitive code. This will be converted to CBS later as well. ok miod@ jsing@ roughly ok with it after seeing the CBS version
* Set SSL_MODE_ENABLE_PARTIAL_WRITE and SSL_MODE_ACCEPT_MOVING_WRITE_BUFFERbluhm2015-07-181-1/+4
| | | | | | | in libtls. This gives tls_write() a similar short write semantics as write(2). So implementing daemons with libevent buffers will be easier and workarounds in syslogd and httpd can be removed. OK tedu@ beck@ reyk@
* Dead code, Coverity 78798beck2015-07-182-6/+2
| | | | ok bcook@ doug@
* simplify length checking in do_indefinite_convertbcook2015-07-181-11/+17
| | | | | Fixes Coverity 117506, 117507, 117508 ok doug@
* Coverity ID 78910 - Yet another stupid API designed to not show failures. do thebeck2015-07-182-12/+16
| | | | | | | | | | lease worst alternative and do nothing rather than dereference NULL, but having a function with fundamentally broken API to simply make a list of strings, sort them, and call a function with each string as an argument is really quite silly.... and of course it was exposed API that the ecosystem uses that we can't delete.. yet. ok miod@ doug@
* Remove SSL_OP_MICROSOFT_BIG_SSLV3_BUFFER workaround.doug2015-07-1810-58/+26
| | | | | | This was a hack to work around problems on IE 6 with SSLv3. ok miod@ bcook@
* remove mysterious, decorative comment blockletsbcook2015-07-181-21/+21
|
* Explicitly mark ignored BN_* return vals in tests.bcook2015-07-181-6/+6
| | | | | The tests will fail all the same. Fixes Coverity 78811 21659 21658 21657. Discussed with beck@
* check sscanf conversion, fixes Coverity 21666bcook2015-07-181-2/+6
| | | | ok doug@, miod@, guenther@
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-03-20 17:10:47 +0000