summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* MFC.OPENBSD_6_0jsing2017-04-301-5/+5
| | | | | | | | | Fix a bug caused by the return value being set early to signal successful DTLS cookie validation. This can mask a later failure and result in a positive return value being returned from ssl3_get_client_hello(), when it should return a negative value to propagate the error. ok beck@
* Bump for LibreSSL 2.4.5libressl-v2.4.5bcook2017-01-071-3/+3
|
* MFC: Avoid a side-channel cache-timing attack that can leak the ECDSAjsing2017-01-051-1/+3
| | | | | | | | | private keys when signing. This is due to BN_mod_inverse() being used without the constant time flag being set. This issue was reported by Cesar Pereida Garcia and Billy Brumley (Tampere University of Technology). The fix was developed by Cesar Pereida Garcia.
* MFC: In ssl3_read_bytes(), do not process more than three consecutive TLSlibressl-v2.4.4jsing2016-11-031-4/+24
| | | | | | | | records, otherwise a peer can potentially cause us to loop indefinately. Return with an SSL_ERROR_WANT_READ instead, so that the caller can choose when they want to handle further processing for this connection. ok beck@ miod@
* Check for and handle failure of HMAC_{Update,Final} or EVP_DecryptUpdate()bcook2016-10-031-5/+11
| | | | | | based on openssl commit a5184a6c89ff954261e73d1e8691ab73b9b4b2d4 ok bcook@ original patch by guenther@
* Detect zero-length encrypted session data early, instead of when malloc(0)bcook2016-10-031-2/+2
| | | | | | | | fails or the HMAC check fails. Noted independently by jsing@ and Kurt Cancemi (kurt (at) x64architecture.com) ok bcook@ original patch by guenther@
* Check for packet with truncated DTLS cookie.bcook2016-10-031-12/+17
| | | | | | | | | | | | Flip pointer comparison logic to avoid beyond-end-of-buffer pointers to make it less likely a compiler will decide to screw you. Based on parts of openssl commits 6f35f6deb5ca7daebe289f86477e061ce3ee5f46 and 89c2720298f875ac80777da2da88a64859775898 ok jsing@ original commit by @guenther
* Improve ticket validity checking when tlsext_ticket_key_cb() callbackbcook2016-10-031-4/+25
| | | | | | | | | | | | chooses a different HMAC algorithm. Avert memory leaks if the callback preps the HMAC in some way. Based on openssl commit 1bbe48ab149893a78bf99c8eb8895c928900a16f but retaining a pre-callback length check to guarantee the callback is provided the buffer that the API claims. ok bcook@ jsing@ original commit by guenther@
* In X509_cmp_time(), pass asn1_time_parse() the tag of the field beingbcook2016-10-031-2/+3
| | | | | | | | parsed so that a malformed GeneralizedTime field is recognized as an error instead of potentially being interpreted as if it was a valid UTCTime. Reported by Theofilos Petsios (theofilos (at) cs.columbia.edu) ok beck@ tedu@ jsing@
* bump to 2.4.4bcook2016-10-021-3/+3
|
* MFC: Avoid falling back to a weak digest for (EC)DH when using SNI withlibressl-v2.4.3jsing2016-09-221-3/+10
| | | | libssl.
* MFC: Avoid unbounded memory growth in libssl, which can be triggered by ajsing2016-09-221-9/+20
| | | | | TLS client repeatedly renegotiating and sending OCSP Status Request TLS extensions.
* bump version for 2.4.3bcook2016-09-221-3/+3
|
* back out calls to EVP_CIPHER_CTX_cleanup() in EVP_Encrypt/DecryptFinalbcook2016-09-221-3/+1
| | | | | Software that refers to ctx after calling Final breaks with these changes. revert parts of 1.31. ok jsing@
* This commit was manufactured by cvs2git to create branch 'OPENBSD_6_0'.libressl-v2.4.2cvs2svn2016-07-231187-380610/+0
|
* rework crl2pkcs7; with help from jsingjmc2016-07-231-57/+18
|
* rework DESCRIPTION a little: no-command seems clearer than no-XXX;jmc2016-07-211-17/+12
|
* rename NOTES to COMMON SYNTAX (explains itself better); rework thejmc2016-07-211-43/+44
| | | | | | passphrase section a little; move the DER|PEM stuff in there to help avoid text repetition, and prefer the lowercase (less keys to press); adjust ENVIRONMENT to format a little more nicely;
* strip back openssl crl somewhat: remove the examplesjmc2016-07-211-41/+21
| | | | and move any relevant text into the main body;
* strip back openssl ciphers:jmc2016-07-201-106/+60
| | | | | | - rearrange the descriptions of -V and -v to read more logically - move the cipherlist text into the cipherlist description - zap examples
* strip back openssl ca: in particular remove some excessively wordy sections,jmc2016-07-191-337/+120
| | | | | move some other sections into more relevant places, and remove the example ca file;
* don't mix code and decls, ok tedu@bcook2016-07-182-4/+6
|
* use memset to initialize the unionbcook2016-07-172-4/+8
|
* remove unused OPENSSL_NO_OBJECT casebcook2016-07-172-28/+2
| | | | ok tedu@
* Initialize buffers before use, noted by Kinichiro Inoguchi.bcook2016-07-172-14/+14
| | | | ok beck@
* strip back asn1parse; ok beck jsingjmc2016-07-171-108/+27
| | | | description of -out altered on jsing's advice
* Clean up OCSP_check_validity() a bit more.beck2016-07-162-22/+20
| | | | | | - Return on first failure rather than continuing. - Don't compare times by comparing strings that possibly were not parsable as a time. ok deraadt@
* since we no longer pull source directly from openssl, the time isjmc2016-07-161-427/+57
| | | | | | | | right to try and trim some of the excess from this page. begin now by cutting some of the fluff from the start. the section on pass phrase arguments goes to the end of the page: it;s in the way for now.
* Limit the support of the "backward compatible" ssl2 handshake to only bebeck2016-07-162-2/+18
| | | | | used if TLS 1.0 is enabled. Sugessted/discussed with jsing@ and bcook@. ok guenther@ sthen@
* Adjust existing tls_config_set_cipher() callers for TLS cipher groupjsing2016-07-131-2/+2
| | | | | | | changes - map the previous configuration to the equivalent in the new groups. This will be revisited post release. Discussed with beck@
* Split the existing TLS cipher suite groups into four:jsing2016-07-133-11/+22
| | | | | | | | | | | | "secure" (TLSv1.2+AEAD+PFS) "compat" (HIGH:!aNULL) "legacy" (HIGH:MEDIUM:!aNULL) "insecure" (ALL:!aNULL:!eNULL) This allows for flexibility and finer grained control, rather than having two extremes (an issue raised by Marko Kreen some time ago). ok beck@ tedu@
* Fix usage() output and getopt sortingguenther2016-07-131-6/+6
|
* zero the read buffer after copying data to user so it doesn't linger.tedu2016-07-102-2/+4
| | | | ok beck
* Revert previous since the libtls change has been reverted.jsing2016-07-071-16/+24
|
* Revert previous - it introduces problems with a common privsep use case.jsing2016-07-073-72/+35
|
* add ca cert error check and make the path configurablebcook2016-07-071-1/+9
| | | | from Kinichiro Inoguchi
* call BN_init on temporaries to avoid use-before-set warningsbcook2016-07-076-6/+28
| | | | ok beck@
* J/j is a three valued option, document and fix code to actuall support thatotto2016-07-061-3/+5
| | | | | with a little help from jmc@ for the man page bits ok jca@ and a reluctant tedu@
* Check that the given ciphers string is syntactically valid and results injsing2016-07-061-1/+17
| | | | | | at least one matching cipher suite. ok doug@
* Remove manual file loading (now that libtls does this for us) and adjustjsing2016-07-061-24/+16
| | | | | pledge to match. Also use tls_config_error() to provide friendlier error messages.
* Always load CA, key and certificate files at the time the configurationjsing2016-07-063-35/+72
| | | | | | | | | | function is called. This simplifies code and results in a single memory based code path being used to provide data to libssl. Errors that occur when accessing the specified file are now detected and propagated immediately. Since the file access now occurs when the configuration function is called, we now play nicely with privsep/pledge. ok beck@ bluhm@ doug@
* Correctly handle an EOF that occurs prior to the TLS handshake completing.jsing2016-07-061-3/+6
| | | | | | Reported by Vasily Kolobkov, based on a diff from Marko Kreen. ok beck@
* remove extra assignment of s from 1.11, fix regression testbcook2016-07-051-2/+1
|
* remove unneeded duplicate call - spotted by jsing@beck2016-07-052-6/+2
|
* On systems where we do not have BN_ULLONG defined (most 64-bit systems),bcook2016-07-058-26/+111
| | | | | | | | | | | | | | BN_mod_word() can return incorrect results if the supplied modulus is too big, so we need to fall back to BN_div_word. Now that BN_mod_word may fail, handle errors properly update the man page. Thanks to Brian Smith for pointing out these fixes from BoringSSL: https://boringssl.googlesource.com/boringssl/+/67cb49d045f04973ddba0f92fe8a8ad483c7da89 https://boringssl.googlesource.com/boringssl/+/44bedc348d9491e63c7ed1438db100a4b8a830be ok beck@
* Add several fixes from OpenSSL to make OCSP work with intermediatebeck2016-07-052-20/+48
| | | | | | certificates provided in the response. - makes our newly added ocsp regress test pass too.. ok bcook@
* make less awful.. test against cloudflare toobeck2016-07-052-9/+19
|
* Add a nasty little ocsp regress test in the hope pedants will make it better.beck2016-07-043-1/+140
|
* do not uppercase "hop limit";jmc2016-07-021-4/+4
|
* Simplify IP proto-specific sockopt error handling.bcook2016-07-011-34/+26
| | | | | | | This makes error messages more specific and simplifies masking compatible sections for the portable version. ok beck@