| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adjust design of file descriptor table to eliminate races
with both opening and closing of file descriptor entries
and eliminates one class of deadlocks. One nice side effect
of this change in design should be better performance for
applications that open and close many file descriptors due
to reduced fd_table_lock contention and fd entry reuse.
- Add entry states to manage use of entry and eliminate
some closing races. fd entries are not deallocated upon
close() now.
- Call _thread_fd_table_init with one of five discreet
modes to properly initialize an entry and manage the
state transition to open.
- When closing an entry hold the entry spinlock locked
across the state transition and the _thread_sys_close
call to close another race.
- Introduce a new lock type FD_RDWR_CLOSE that transitions
either a closed entry or an open entry into closing state
and then waits for a RDWR lock so that the lock queue can
unwind normally. All subsequent fd lock attempts for that
entry are rejected with EBADF until the fd is fully closed,
or reopened by dup2(). Once a thread holds the FD_RDWR_LOCK
it is safe to close() it or dup2() on it.
- When a thread creates a new fd there is a window of time
when another thread could attempt to use the fd before the
creating thread has initialized the entry for it. This can
result in improper status_flags for the entry, so record
the entries init mode, detect when this has happened and
correct the status_flags when needed.
reviewed by marc@ & brad@, tested by several, okay brad@
|
|
|
|
|
|
| |
cool and recognizes __dead, and because shorter examples are clearer.
OK otto@.
|
|
|
|
|
| |
have multiple bits set, which lead to surprising results. Spotted by
Paul Stoeber. ok djm@
|
|
|
|
| |
OK djm@.
|
|
|
|
| |
OK otto@ and jaredy@.
|
|
|
|
|
|
|
|
|
| |
flag from its optional argument if permutation is disabled. The
idea was that since "r:" would match "-r foo" then "r::" should
match "-r foo" too as long as we know that things have not been
reshuffled. Unfortunately, this causes incompatibilities with GNU
getopt_long when the POSIXLY_CORRECT environment variable is set.
OK deraadt@
|
|
|
|
| |
ok beck@ miod@
|
|
|
|
|
|
| |
about them;
ok djm
|
| |
|
| |
|
|
|
|
|
| |
from eren elci; tweaked by djm
ok djm
|
|
|
|
| |
re-worded and ok djm
|
|
|
|
| |
dot org>; ok djm@ deraadt@
|
| |
|
| |
|
| |
|
|\
| |
| | |
branch.
|
| | |
|
| | |
|
|\ \
| | |
| | | |
branch.
|
| | | |
|
|\ \ \
| | | |
| | | | |
branch.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
'openssl x509 -hash'. ok beck@
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
'openssl x509 -hash'. ok beck@
|
| | | |
| | | |
| | | |
| | | | |
descriptive while at it, input and okay jmc@
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
sleep takes an unsigned integer.
OK moritz@, jaredy@, and dhill@
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
ok miod@, tedu@, pedro@
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
exceptions are deferred, we might not see the exception before another
floating-point instruction is executed. This is especially true on the i387
where we don't see underflow/overflow until the result is stored into memory.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
requires memory; try to make sure we have it. If all fails, leak
instead of crash. Test case originally found by cloder@, fix tested
by many.
|
| | | |
| | | |
| | | |
| | | | |
ok djm@ miod@, man page help from jmc@.
|
| | | |
| | | |
| | | |
| | | | |
ok jmc@, mbalmer@
|
| | | |
| | | |
| | | |
| | | | |
on most architectures. From Oliver Smith. OK deraadt@ and henning@
|
| | | |
| | | |
| | | |
| | | |
| | | | |
OpenSSL-0.9.8a, where they were added without a corresponding patch to
0.9.7 or an advisory! ok theo@ markus@
|
| | | |
| | | |
| | | |
| | | | |
spotted by ray some time ago
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
region succeeds, but allocation a required page dir failed. This
can happen if we're really close to ulimit after allocation the
region of the size requested. See malloc_ulimit1 regress test.
Tested by many; thanks.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
tested by quite a few developers. ok deraadt@
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
separating out each step. Inspired during miscommunication with
tedu@.
OK deraadt@
|