summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Restore beck's rev 1.3: snprintf() was reviewedguenther2014-04-202-2/+2
|
* More KNF.jsing2014-04-204-6/+6
|
* KNF.jsing2014-04-2012-1428/+1902
|
* KNF.jsing2014-04-2012-940/+1184
|
* KNF.jsing2014-04-208-528/+718
|
* More KNF.jsing2014-04-2026-160/+176
|
* More KNF.jsing2014-04-202-100/+124
|
* gettimeofday() is portable enough and does not need a wrapperderaadt2014-04-202-18/+4
|
* calloc() rather than malloc+memsetderaadt2014-04-202-4/+4
|
* Fix indentation, adding braces and combining a nested if to reduce depthguenther2014-04-202-24/+28
|
* KNF.jsing2014-04-204-362/+438
|
* KNF.jsing2014-04-208-796/+786
|
* Chop off more SSLv2 tentacles and start fixing and noting y2038 issues.guenther2014-04-2017-118/+44
| | | | | | | APIs that pass times as longs will have to change at some point... Bump major on both libcrypto and libssl. ok tedu@
* return after error instead of plowing ahead. noticed by mancha1 at zohotedu2014-04-202-0/+2
|
* Use calloc(a,b) instead of malloc(a*b) + memset(a*b). I don't know ifderaadt2014-04-202-4/+2
| | | | | | | | | | | | | | | | | | | | | | this instance is integer-overflowable, but we cannot keep hand-auditing every instance (or apathetically ignoring these issues) when the simple calloc idiom is better in the presence of a good calloc(). It is simply unfeasible to always enter correct range checks before the aggregate size calculation, just go find some 4000 lines of code, REPAIR THEM ALL, then come back and tell me I am wrong. This only works on systems where calloc() does the integer overflow check, but if your system doesn't do this, you need to ask your vendor WHY THEY ARE 10 YEARS BEHIND IN BEST PRACTICE? This is the kind of problem that needs to be solved at the right layer. malloc integer-overflow was implicated in the 2002 OpenSSH hole. OpenSSH and much other code is now written to use calloc(), for instance OpenSSH has 103 calls to it. We feel safer with our use of calloc(). It is a natural approach for us to use calloc(). How safe do you feel on systems which lack that range check in their calloc()? Good writeup from 2006: http://undeadly.org/cgi?action=article&sid=20060330071917
* Undo a calloc() replacement. It lacks the integer overflow check thatderaadt2014-04-201-14/+1
| | | | the system one has.
* KNF.jsing2014-04-2024-2308/+2268
|
* reset imprint to NULL to avoid double free. from mancha1 at zohotedu2014-04-202-0/+2
|
* release buffers fix was lost in merge. put it back.tedu2014-04-192-2/+4
|
* change some rsh references to ssh. poke by jmctedu2014-04-192-9/+9
|
* More KNF.jsing2014-04-194-74/+84
|
* More KNF.jsing2014-04-196-90/+122
|
* another attempt at fixing stale x509 data. since we don't know where thetedu2014-04-192-20/+16
| | | | | initial storage came from, we can't free it. just memset in the sequence case. probably ok beck
* More KNF.jsing2014-04-1914-157/+163
|
* More KNF.jsing2014-04-192-40/+40
|
* tweak previous;jmc2014-04-191-3/+2
|
* zap trailing whitespace;jmc2014-04-191-2/+2
|
* remove the openssl_fdset wrapper, and a variety of VMS'ism's likederaadt2014-04-196-48/+19
| | | | | crazy (void *) casts all over the place ok beck jsing
* KNF.jsing2014-04-1912-1626/+1628
|
* Remove a gethostbyname() cache layer. The internet works better thesederaadt2014-04-191-50/+1
| | | | days. Initially fixed this, but Ted asked for it to die.
* ReadFile() and GetStdHandle() are not very POSIX.deraadt2014-04-194-45/+6
| | | | ok beck jsing
* truncation check some snprintf calls (over-cautiously in case)deraadt2014-04-194-19/+78
| | | | ok jsing beck
* can't actually do this. cause unknown.tedu2014-04-192-2/+2
|
* Fix some serious pointer-arithmatic-magic-number-unchecked-return eyebleedbeck2014-04-191-53/+44
| | | | | | | | | | that I stumbled into here and got stuck with. If modern society can get past selling daughters for cows, surely we can decide to write modern C code in an "application" that is probably 3 lines of shell/python/cgi away from talking to the internet in a lot of places.. (This file still needs a lot more love though) "oh god yuck" deraadt@ ok tedu@
* KNF.jsing2014-04-1912-1128/+1060
|
* Repair some indent to be more KNF, and break instead of fallthrough toderaadt2014-04-191-12/+14
| | | | default which does break
* one small tweak to avoid ever going off the end of a string.tedu2014-04-191-4/+6
|
* improved checking for invalid hashes. from solar designertedu2014-04-191-6/+10
|
* More KNF.jsing2014-04-196-66/+68
|
* kill a stray \deraadt2014-04-191-2/+2
|
* Lacking a proof that--for this implementation--exposure of Montgomeryguenther2014-04-194-14/+14
| | | | | | | | multiplication or RSA blinding parameters doesn't permit retroactive timing analysis of the secrets, we'll do the stupidly cheap thing and cleanse them before freeing them. ok deraadt@
* More KNF.jsing2014-04-1910-476/+592
|
* Remove hacky workaround for Cray T3E.deraadt2014-04-191-11/+0
| | | | ok guenther
* More KNF.jsing2014-04-198-522/+758
|
* oops, typo got into changederaadt2014-04-191-1/+1
|
* More KNF.jsing2014-04-196-20/+28
|
* malloc + strlcpy -> strdupderaadt2014-04-191-3/+2
|
* unifdef ENOTDIR, everyone has itderaadt2014-04-191-15/+3
|
* We'll interpret a (void) cast on snprintf() to mean it's been verified thatguenther2014-04-1955-147/+147
| | | | | | truncation is either desirable, not an issue, or is detected and handled later ok deraadt@
* Use somewhat harsher language and better examples; demonstrate thatderaadt2014-04-194-109/+88
| | | | | non-dangerous use functions is difficult. ok guenther
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-03-28 12:17:07 +0000