summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add const qualifier to the argument of X509_get_issuer_name(3) andtb2018-05-132-6/+6
| | | | | | | X509_get_subject_name(3). tested in a bulk build by sthen ok jsing (as part of a larger diff)
* Add const qualifier to the X509_NAME *, ASN1_BIT_STRING *, andtb2018-05-132-6/+6
| | | | | | | ASN1_INTEGER * arguments of OCSP_cert_id_new(3). tested in a bulk build by sthen ok jsing (as part of a larger diff)
* Add const qualifier to the ASN1_OBJECT * argument of:tb2018-05-132-11/+12
| | | | | | | | OCSP_REQUEST_get_ext_by_OBJ(3), OCSP_ONEREQ_ext_by_OBJ(3) OCSP_BASICRESP_get_ext_by_OBJ(3), OCSP_SINGLERESP_get_ext_by_OBJ(3) tested in a bulk build by sthen ok jsing (as part of a larger diff)
* Add const qualifier to the ASN1_OBJECT * parameter oftb2018-05-132-5/+5
| | | | | | | X509v3_get_ext_by_OBJ(3). tested in a bulk build by sthen ok jsing (as part of a larger diff)
* Add a const qualifier to the ASN1_OBJECT * argument of the following:tb2018-05-134-14/+16
| | | | | | | | EVP_PKEY_get_attr_by_OBJ(3), X509at_get_attr_by_OBJ(3), X509at_get0_data_by_OBJ(3), X509_REQ_get_attr_by_OBJ(3) tested in a bulk by sthen ok beck (as part of a larger diff)
* Add a const qualifier to the argument of EVP_PKEY_get0_asn1(3).tb2018-05-132-4/+4
| | | | | tested in a bulk build by sthen ok beck (as part of a larger diff)
* Add a const qualifier to the argument of EVP_PKEY_get0(3).tb2018-05-132-4/+4
| | | | | tested in a bulk build by sthen ok beck (as part of a larger diff)
* Add a const qualifier to the argument of EVP_PKEY_bits(3).tb2018-05-132-4/+4
| | | | | tested in a bulk build by sthen ok beck (as part of a larger diff)
* Add a const qualifier to the second argument of EVP_DigestVerifyFinal(3).tb2018-05-132-4/+5
| | | | | tested in a bulk build by sthen ok beck (as part of a larger diff)
* In bio.h rev. 1.43 2018/05/12 18:51:59, tb@ added a const qualifierschwarze2018-05-123-8/+8
| | | | | to the argument of BIO_new_accept(3), BIO_new_connect(3), and BIO_new_mem_buf(3). Update the documentation.
* In bio.h rev. 1.42 2018/05/12 17:47:53, tb@ added a const qualifierschwarze2018-05-121-3/+3
| | | | to return value of BIO_s_mem(3). Update the manual page.
* const qualifiers for BIO_new_mem_buf(), BIO_new_connect() andtb2018-05-124-11/+11
| | | | | | | | BIO_new_accept(). The one for BIO_new_mem_buf() is a bit ugly since it needs to cast away the newly added const qualifier, as in OpenSSL commit 8ab31975bac. ok jsing
* Add const qualifiers to the return values of BIO_s_mem() andtb2018-05-123-9/+9
| | | | | | BIO_s_datagram(). ok jsing
* Cleanup c2i_ASN1_BIT_STRING() code.jsing2018-05-121-20/+23
| | | | | | | | | | Avoid overloading a variable to store both a value and an error code - we can simply inline the error calls (as done everywhere else). Remove a bunch of unnecessary parentheses and tidy a few other things. With input from tb@. ok inoguchi@ tb@
* Add a missing bounds check in c2i_ASN1_BIT_STRING().jsing2018-05-121-1/+6
| | | | | | | | | This could potentially result in a left shift that exceeded the size of the storage type. Issue found by Simon Friedberger, Robert Merget and Juraj Somorovsky. ok inoguchi@ tb@
* Use explicit_bzero() rather than memset() when clearing a BIGNUM.jsing2018-05-121-2/+2
| | | | ok bcook@ tb@
* If we fail to decode an EC point format extension, send a decode_errorjsing2018-05-121-4/+6
| | | | | | | | alert rather than an internal_error alert. Issue found by Simon Friedberger, Robert Merget and Juraj Somorovsky. ok beck@ inoguchi@
* Fix typo in RFC number.tb2018-05-101-2/+2
| | | | ok benno
* begin LibreSSL 2.8.0 dev branchbcook2018-05-031-3/+3
|
* In evp.h rev. 1.59 2018/05/02 15:51:41, tb@ added a const qualifierschwarze2018-05-023-9/+9
| | | | | to the return value of BIO_f_base64(3), BIO_f_cipher(3), and BIO_f_base64(3). Update the documentation.
* Add const qualifiers to return value of BIO_f_{base64,cipher,md}().tb2018-05-024-13/+13
| | | | | tested in bulk by sthen ok jsing
* Remove incorrect NULL checks in DH_set0_key().tb2018-05-021-5/+1
| | | | | | Reported by Ondřej Surý, LibreSSL-portable issue #92. ok inoguchi, jsing
* In x509.h rev. 1.46 2018/05/01 19:01:28, tb@ added const qualifiersschwarze2018-05-012-6/+6
| | | | to some function arguments. Update the documentation.
* Convert a handful of X509_*() functions to take const as in OpenSSL.tb2018-05-0110-43/+44
| | | | | tested in a bulk by sthen ok jsing
* In bio.h rev. 1.41 2018/05/01 13:29:09, tb@ added const qualifiersschwarze2018-05-019-28/+28
| | | | to the prototypes of several functions. Update the documentation.
* In ssl.h rev. 1.158 2018/05/01 13:30:24, tb@ changed BIO_f_ssl(3)schwarze2018-05-011-3/+3
| | | | to return const. Update the documentation.
* Fix whitespace on a few lines to reduce noise in an upcoming diff.tb2018-05-011-5/+5
|
* const for BIO_f_ssl(), the last const difference to OpenSSL in ourtb2018-05-012-5/+5
| | | | | | public API in libssl. ok beck, jsing
* const for BIO_{new,set}() and most of the BIO_{f,s}_*() family oftb2018-05-0114-52/+52
| | | | | | functions. ok beck, jsing
* Add a missing header when compiling with -DDEBUGdenis2018-04-301-1/+5
| | | | | | With advice from jca@ OK jca@ millert@
* In view of the recent BN_FLG_CONSTTIME vulnerabilities in OpenSSL,schwarze2018-04-294-28/+104
| | | | | | | | | | | | | | | | carefully document constant time vs. non-constant time operation of BN_div(3), BN_mod_exp(3), and BN_mod_inverse(3). Until the work that is required on the ill-designed BN_exp(3) and BN_gcd(3) interfaces can be undertaken, also document the imperfections in their behaviour, for now. Finally, mention BN_mod_exp(3) behaviour for even moduli. Delete the vague statement about some functions automatically setting BN_FLG_CONSTTIME. It created a false sense of security. Do not rely on it: not all relevant functions do that. Topic brought up by beck@, significant feedback and OK jsing@.
* Correct direction of SSL_ERROR_ZERO_RETURN caseguenther2018-04-291-3/+3
| | | | ok schwarze@
* reference hosts(5) instead of networks(5)schwarze2018-04-281-3/+3
|
* Remove references to the obsolete getnetent(3) and networks(5).schwarze2018-04-282-10/+7
|
* Stop talking about /etc/networks, which is no longer used,schwarze2018-04-281-39/+38
| | | | | | and reference gethostby*(3) and /etc/hosts instead. Say that setnetent(3), getnetent(3), and endnetent(3) now do nothing. With feedback from guenther and significant help from deraadt@.
* Say that sethostent(3), gethostent(3), and endhostent(3) do nothing.schwarze2018-04-281-50/+19
| | | | | | While here, stop implying plans to support additional address families in the future, and do not call gethostbyname2(3) "advanced". OK deraadt@ guenther@
* To allow us to get rid of /etc/networks, make setnetent(3),schwarze2018-04-281-75/+4
| | | | | | getnetent(3), and endnetent(3) do nothing, just like sethostent(3), gethostent(3), and endhostent(3) years ago. OK deraadt@ guenther@
* Fix a small timing side channel in dsa_sign_setup(). Simple adaptationtb2018-04-281-12/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of OpenSSL commit c0caa945f6ef30363e0d01d75155f20248403df4 to our version of this function. ok beck, jsing Original commit message: commit c0caa945f6ef30363e0d01d75155f20248403df4 Author: Pauli <paul.dale@oracle.com> Date: Wed Nov 1 06:58:13 2017 +1000 Address a timing side channel whereby it is possible to determine some information about the length of the scalar used in DSA operations from a large number (2^32) of signatures. This doesn't rate as a CVE because: * For the non-constant time code, there are easier ways to extract more information. * For the constant time code, it requires a significant number of signatures to leak a small amount of information. Thanks to Neals Fournaise, Eliane Jaulmes and Jean-Rene Reinhard for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4576)]
* Fix a small timing side channel in ecdsa_sign_setup(). Up to whitespacetb2018-04-281-8/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this is OpennSSL commit 4a089bbdf11f9e231cc68f42bba934c954d81a49. ok beck, jsing Original commit message: commit 4a089bbdf11f9e231cc68f42bba934c954d81a49 Author: Pauli <paul.dale@oracle.com> Date: Wed Nov 1 06:58:39 2017 +1000 Address a timing side channel whereby it is possible to determine some information about the length of the scalar used in ECDSA operations from a large number (2^32) of signatures. This doesn't rate as a CVE because: * For the non-constant time code, there are easier ways to extract more information. * For the constant time code, it requires a significant number of signatures to leak a small amount of information. Thanks to Neals Fournaise, Eliane Jaulmes and Jean-Rene Reinhard for reporting this issue. Reviewed-by: Andy Polyakov <appro@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/4576)]
* trailing whitespace, and move arg checking before pledgebeck2018-04-271-17/+17
| | | | | in preparation for pledgepath ok deraadt@
* Put function name on a separate line and zap stray whitespace.tb2018-04-251-3/+4
|
* In asn1.h rev. 1.46 2018/04/25 11:48:21, tb@ added const qualifiersschwarze2018-04-257-30/+30
| | | | | to some parameters of some functions. Update the documentation. Add a few additional missing const qualifiers while here.
* Avoid talking about the innternal, undocumented data type "struct lhash_st",schwarze2018-04-251-3/+3
| | | | show the public data type name "LHASH_OF(SSL_SESSION)" instead.
* Document the callbacks as taking "SSL *" and "SSL_CTX *" argumentsschwarze2018-04-251-7/+7
| | | | | and avoid the internal, undocumented names "struct ssl_st *" and "struct ssl_ctx_st *".
* In ssl.h rev. 1.156 2018/04/25 07:10:39, tb@ added const qualifiersschwarze2018-04-255-16/+16
| | | | | to some parameters and return values of some functions. Update the documentation.
* remove whitespace before closing parenstb2018-04-251-5/+5
|
* Add const to functions in asn1/asn1.h as they did in OpenSSL.tb2018-04-2519-92/+96
| | | | | | | BIO_f_asn1() will be taken care of later. Tested in a bulk by sthen ok bcook jca jsing
* Fix capitalization of data. Pointed out by jsing and forgotten intb2018-04-251-2/+2
| | | | previous commit.
* The cookie in the cookie verify callback needs to be const.tb2018-04-252-4/+5
| | | | ok jsing (as part of a larger diff)
* OpenSSL started adding const to functions all over the place. Make alltb2018-04-257-38/+30
| | | | | | | | our libssl functions match theirs wrt const, except for BIO_f_ssl(3) which will be fixed in a later step. this went through a i386 bulk by sthen ok jsing