summaryrefslogtreecommitdiff
path: root/src/lib/libc/stdlib/malloc.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-07-28remove non-portable __progname extern from arc4random unit test.bcook1-2/+1
ok @deraadt
2014-07-27Link dependencies on libssl and libcrypto were missing.guenther1-2/+3
OPENSSL_NO_RC5 is #defined in the #includes, so it's not needed here. ok deraadt@
2014-07-25Add missing year to copyright.jsing4-8/+8
2014-07-25BIO_free() returns immediately when the sole input is NULL.doug26-96/+61
Remove unnecessary NULL check. ok miod@
2014-07-23level_add_node(): if a memory allocation failure causes us to attempt to cleanmiod2-8/+14
up and return failure, be sure the cleanup work does NOT free objects which are still being referenced by other objects. ok guenther@
2014-07-23Make sure PEM_def_callback() correctly handles negative buffer sizes; all usesmiod2-20/+34
within libcrypto are safe, but until we can change this function prototype to use size_t instead of int, better be safe than sorry. tweaks and ok guenther@
2014-07-23Check the return value of the UI functions (including UI_new() which returnmiod2-12/+22
value is happily dereferenced without checking it for being non-NULL). ok beck@
2014-07-22Now that DES_random_key() can be trusted, use it to generate DES keys in themiod4-24/+20
EVP_CTRL_RAND_KEY method handlers, rather than generating a random odd key and not even checking it against the weak keys list. ok beck@
2014-07-22In DES_random_key(), force the generated key to the odd parity before checkingmiod2-16/+16
it is not one of the weak and semi-weak keys. Even though the probability of generating a weak key with incorrect parity is abysmally small, there is no reason to be correct (although, if you're in a need for fresh DES keys nowadays, you should seriously consider switching to a stronger symmetric cipher algorithm). ok beck@
2014-07-22Handle failure of NETSCAPE_SPKI_b64_encode() and don't leak memoryguenther1-6/+10
when BIO_new_{file,fp}() fails. inspired by a diff from logan@ ok miod@
2014-07-22Use Cm instead of Li for 'MASK:'guenther1-2/+2
(Overlooked among jmc@'s other suggestions)
2014-07-22Rewrite the description of the string_mask config file option to matchguenther1-34/+30
reality, and reformatting to be readable. formatting and wording suggestions miod@ jmc@
2014-07-22Kill a bunch more BUF_strdup's - these are converted to have a check forbeck12-30/+40
NULL before an intrinsic strdup. ok miod@
2014-07-22better match proposed syscall apibcook2-16/+4
2014-07-21protect sysctl path with SYS__sysctl instead; from enh@google, ok bcookderaadt2-12/+12
2014-07-21Use explicit_bzero() instead of memset() on buffers going out of scope.guenther6-12/+18
Also, zero the SHA256 context. suggested by "eric" in a comment on an opensslrampage.org post ok miod@ deraadt@
2014-07-21cast from void * before math; enh@googlederaadt2-4/+4
2014-07-21missing newlinederaadt1-1/+2
2014-07-21Switch from <sys/endian.h> or <machine/endian.h> to the new,guenther5-10/+10
being-standardized <endian.h> ok deraadt@ millert@ beck@
2014-07-20Move more OS-specific functionality to arc4random.h headers.bcook10-14/+88
Move <sys/mman.h> and raise(SIGKILL) calls to OS-specific headers. On OpenBSD, move thread_private.h as well to arc4random.h. On Windows, use TerminateProcess on getentropy failure. ok deraadt@
2014-07-20initial win32 ARC4_LOCK/UNLOCK implementation.bcook2-2/+42
It may make sense to later replace this with a Critical Section later. ok guenther@
2014-07-20From ISO/IEC 9899:1999 and 9899:201x,guenther2-5/+5
6.11.5 - Storage-class specifiers: The placement of a storage-class specifier other than at the beginning of the declaration specifiers in a declaration is an obsolescent feature. Diff from Jean-Philippe Ouellet (jean-philippe (at) ouellet.biz)
2014-07-20Demonstrate how new linux getrandom() will be called, at least untilderaadt2-2/+74
it shows up in libraries. Even the system call is probably not finalized. Bit dissapointed it has turned out to be a descriptor-less read() with EINVAL and EINTR error conditions, but we can work with it.
2014-07-20Mark the format string argument to BIO_*printf as not being allowed to be NULLguenther2-10/+14
ok bcook@
2014-07-20Fix ordering breakage, moving the fclose() test last again.guenther1-6/+22
Also correct some format strings. From Doug Hogan (doug (at) acyclic.org)
2014-07-20Make sure the correct errno is reported by warn* or err* and notguenther7-7/+14
the errno of an intervening cleanup operation like close/unlink/etc. Diff from Doug Hogan (doug (at) acyclic.org)
2014-07-20Delete unused variables found by -Wallguenther5-5/+2
2014-07-20Add missing include. Tickled by Doug Hogan (doug (at) acyclic.org)guenther1-0/+1
2014-07-19remove disabled main hook; we use phdr now; ok bcookderaadt6-42/+6
2014-07-19arc4random re-seeds with getentropy() now; ok deraadt@ jmc@naddy1-3/+3
2014-07-19tab lovederaadt2-6/+6
2014-07-19Move _ARC4_ATFORK handlers from thread_private.h in portable.bcook6-6/+30
2014-07-19move _ARC4_LOCK/UNLOCK primitives from thread_private into OS-specific modulesbcook6-6/+44
2014-07-19fixup typosbcook6-110/+108
2014-07-19Fix strtonum range to unbreak -pass fd:0lteo1-2/+2
ok deraadt@
2014-07-19Change _rs_allocate so it can combine the two regions (rs and rsx)deraadt10-138/+135
into one if a system has an awesome getentropy(). In that case it is valid to totally throw away the rsx state in the child. If the getentropy() is not very good and has a lazy reseed operation, this combining is a bad idea, and the reseed should probably continue to use the "something old, something new" mix. _rs_allocate() can accomodate either method, but not on the fly. ok matthew
2014-07-18Cleanup portable arc4random fork detection code:matthew6-66/+48
1. Use "len" parameter instead of sizeof(*rs). 2. Simplify the atfork handler to be strictly async signal safe by simply writing to a global volatile sig_atomic_t object, and then checking for this in _rs_forkdetect(). (Idea from discussions with Szabolcs Nagy and Rich Felker.) 3. Use memset(rs, 0, sizeof(*rs)) to match OpenBSD's MAP_INHERIT_ZERO fork semantics to avoid any skew in behavior across platforms. ok deraadt
2014-07-18missing newlinederaadt1-2/+2
2014-07-18Remove "const" from the lsearch(3) manual's synopsis too.matthew1-3/+3
Reminded by Rafael Neves
2014-07-18zap trailing whitespace;jmc1-3/+3
2014-07-18Change lsearch()'s "base" argument to require a non-const pointer tomatthew1-2/+2
align with POSIX and other systems. Pointed out by Elliott Hughes on tech ok deraadt
2014-07-18Seperate arc4random's os-dependent parts into static inline functions,deraadt10-36/+543
making it much easier for libressl -portable to fill in the gaps. ok bcook beck
2014-07-17avoid errx(); Jonas Termansenderaadt1-3/+5
2014-07-17avoid sys/param.h; Jonas Termansenderaadt4-10/+12
2014-07-17it is 2014, and we still need to encourage people away from srand()deraadt2-5/+14
and random(). Sigh.
2014-07-17"Race-free because we're running single-threaded in a newderaadt1-1/+5
address space, and once allocated rs is never deallocated." document the forkhandler to save reviewers time, with matthew
2014-07-17Missing bounds check in ssl3_get_certificate_request(), was not spotted inmiod2-2/+12
1.78; reported by Ilja Van Sprundel.
2014-07-17Free sktmp when it's no longer needed. By doing so, we fix a bunch of memory ↵logan2-4/+8
leaks. From miod@ OK from miod@ and guenther@
2014-07-16Fix tlsext_tick_lifetime_hint value in test #2 to make sure themiod1-29/+29
(tlsext_tick_lifetime_hint > 0) test also passes on 32-bit platforms (tlsext_tick_lifetime_hint is a long).
2014-07-16Only call getauxval(3) if HAVE_GETAUXVAL is defined. Fixes build on olderkettenis2-2/+6
Linux (such as Ubuntu 12.04LTS) that don't have it yet. Seems the AT_XXX defines are pulled in by <link.h> now. ok beck@