summaryrefslogtreecommitdiff
path: root/src/lib/libc/stdlib/malloc.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-06-30simplify and unobfuscate a variable to fix a mem leak.tedu2-12/+18
original diff by logan
2014-06-30fix the identical leak in three different files.tedu6-12/+18
reported by Brent Cook, original diff by logan
2014-06-29Free "data" when it's no longer in use.logan1-1/+2
(Thanks to Brent Cook) OK from jsing@
2014-06-29Fix file descriptor leaklogan1-1/+2
(Thanks to Brent Cook) OK from jsing@
2014-06-29Remove yet another unused file... a backup copy (minus copyright andjsing2-132/+0
includes) follows this commit message:
2014-06-29KNF.jsing22-3212/+3126
I just spent too long chasing a bug in here and really should have done this first. Gem of the day... is it an if test or a for loop? No, it is a super ifloop! if (!(flags & PKCS7_NOVERIFY)) for (k = 0; k < sk_X509_num(signers); k++) {
2014-06-29Remove another unused source file - I got suspicious when I found ajsing2-920/+0
function that ended with: if (ret & 0x01) if (ret & V_ASN1_CONSTRUCTED) }
2014-06-29More KNF.jsing2-64/+98
2014-06-29correct issetugid sense as spotted by Stijn van Drongelen.deraadt2-6/+14
Substantially expand the conditional to reduce potential for error.
2014-06-28Add a missing word.jca2-2/+2
2014-06-28Fix a memory leak and another one that occurs in the error paths.logan2-4/+12
(Thanks to Brent Cook) OK from tedu@
2014-06-28Fix 9 memory leaks.logan2-2/+20
(Thanks to Brent Cook) With help from tedu@ OK from tedu@
2014-06-28Fix 2 memory leaks.logan2-2/+6
(Thanks to Brent Cook) OK from tedu@
2014-06-28Use strtonum() instead of atoi(), and then impose what are we thinkderaadt13-102/+211
are the current range checks. Help from millert and lteo. Please test now that it is deployed and let us know if any numbers are off.. ok lteo
2014-06-27When building a BN on the stack in BN_div(), make sure to initialize all itsmiod2-2/+4
fields (i.e. the flags field) before using it. This is currently harmless, but might not be if we end up invoking other BN functions checking for constant-time processing requirement in the future.
2014-06-27re-init and init code paths are now more shared, so the getpid()-basedderaadt1-2/+3
portable code path must handle that; with brent cook
2014-06-27extra evil spaces snuck in over the last whilederaadt1-20/+20
2014-06-27Move to a smaller rbytes buffer and skip a random part. Not tootto1-3/+4
improve the random stream itself (it doesn't), but to introduce noise in the arc4random calling pattern. Thanks to matthew@ who pointed out bias in a previous diff, ok deraadt@ matthew@
2014-06-27save_errno botch; spotted by miodderaadt2-4/+4
2014-06-27hand-KNF macro the do { } while loopsderaadt8-80/+98
2014-06-27hand-KNF the remaining bitsderaadt2-196/+212
2014-06-27Remove M_ASN1_New* macros which are only used in X509_PKEY_new() are obfuscatemiod4-44/+32
it to hide memory leaks in the error paths, and fix aforementioned memory leaks. ok jsing@ logan@ deraadt@
2014-06-26Add back an #ifndef MAP_INHERIT_ZERO chunk to support the old getpid()deraadt1-1/+13
mechanism, to aid in portability to other systems as requested. ok matthew
2014-06-26save errno in ERR_put_error(), so that SYSerr doesn't have any accidentalderaadt2-2/+6
cases where errno can be trashed. ok jsing
2014-06-26fix HD() misuse; from brent cookderaadt2-4/+4
2014-06-25AT_BASE returns us the *address* of the start of ld.so, sobeck2-4/+4
use the address, not what it points to (which is always the same) ok deraadt@
2014-06-25get the page of data at AT_SYSINFO_EHDRbeck2-4/+4
ok deraadt@
2014-06-25comment fixes from theobeck2-10/+12
2014-06-25Possibly obtain a little bit of entropy from addresses returnedbeck2-4/+46
by getauxval if we have it. ok deraadt@
2014-06-25O_NOFOLLOW would be very nice to have here if the version of linuxbeck2-20/+22
we are running supports it. from enh@google.com
2014-06-25Alexander Schrijver posted a diff to remove references to the c_rehash script,jmc1-6/+5
which we don;t have in base. after some discussion with jca, i've not removed these references, but tried to make it clearer it's distributed with openssl and not included in base;
2014-06-25document why we explicit_bzeroderaadt1-2/+2
2014-06-24Unifdef -UNO_SYS_TYPES_Hmiod10-40/+18
2014-06-24Remove previously commented out wrong code, as well as the comment saying thismiod2-6/+2
is incorrect code.
2014-06-24Remove ancient workaround for previous century's compilers in the declarationmiod2-4/+2
of CRYPTO_EX_DATA; riding upon the libcrypto major bump.
2014-06-24Remove BIO_f_reliable(), guilty of playing with EVP_MD_CTX internals itmiod5-1256/+4
should not know anything about. Verified not to be used in ports; riding upon the recent libcrypto major bump.
2014-06-24Crank libcrypto major since my previous commit changed the size of thejsing2-2/+2
ChaCha context. Other changes will also ride this crank.
2014-06-24If a chacha operation does not consume all of the generated key stream,jsing6-14/+92
ensure that we save it and consume it on subsequent writes. Otherwise we end up discarding part of the key stream and instead generate a new block at the start of the next write. This was only an issue for callers that did multiple writes that are not multiples of 64 bytes - in particular, the ChaCha20Poly1305 usage does not hit this problem since it performs encryption in a single-shot. For the same reason, this is also a non-issue when openssl(1) is used to encrypt with ChaCha. Issue identified by insane coder; reported to bugs@ by Joseph M. Schwartz. ok beck@
2014-06-24Extend the chacha regress to cover the ChaCha interface, in addition to thejsing1-22/+99
single-shot CRYPTO_chacha_20() interface (the ChaCha interface was already tested via the EVP regress, but not extensively). The additional ChaCha tests include single-shot writes, along with partial/single-byte writes that currently fail due to a bug in the underlying implementation.
2014-06-24Some KNF.jsing2-12/+24
2014-06-24Replace 48 lines of code with a single inet_pton() call. The previousjsing2-96/+6
handrolled version could not even make use of sscanf(), since that would not work with a certain antiquated compiler. It is worth noting that there is a tiny change in behaviour - previously calling BIO_get_host_ip() with something that looked like it might be a valid IP address (for example, "1." or even ".") would result in it returning failure rather than trying a BIO_gethostbyname() - now we'll always try a BIO_gethostbyname() if it was not a valid IPv4 address. ok beck@ miod@ deraadt@
2014-06-24Actually make BIO_set_tcp_ndelay() work - TCP_NODELAY will not magicallyjsing2-32/+6
appear by itself. ok beck@ miod@
2014-06-24Fix memory leak.logan1-2/+4
Thanks to Brenk Cook. OK from miod@
2014-06-23Since this is a library, place issetugid() before every getenv()deraadt10-26/+48
ok miod
2014-06-23unbreak build of getentropy_sysctl - we need linux/sysctl.h, andbeck2-36/+42
RANDOM_UUID is an enum member.
2014-06-23unbreak - main needs to be extern in here somewhere.beck2-2/+4
2014-06-22KNF, particularly wrapped lines of calls to PEM_read_bio_FOO() andguenther2-48/+88
multiline comments ok jsing@
2014-06-22Add regress tests for BIO_get_host_ip().jsing1-2/+70
2014-06-22BIO_sock_init() no longer does anything, so stop calling it.jsing2-20/+2
2014-06-22Just use SOMAXCONN and IPPROTO_TCP, since we know we have them.jsing2-28/+8