| Commit message (Collapse) | Author | Files | Lines | ||
|---|---|---|---|---|---|
| 2014-06-01 | Make usage for -quiet match the manpage and fix a misspelling | guenther | 1 | -2/+2 | |
| 2014-06-01 | Overhaul the key block handling in tls1_change_cipher_state() - use | jsing | 2 | -92/+132 | |
| meaningful variable names with pointer arithmitic, rather than n, i, j and p with array indexing. Based on Adam Langley's chromium diffs. ok miod@ | |||||
| 2014-06-01 | In tls1_setup_key_block(), use the correct IV length for GCM mode, which | jsing | 2 | -34/+48 | |
| results in the key block length calculation also being correct. Rename a number of variables so that their purpose becomes clear and simplify some of the code. Inspired by Adam Langley's chromium diffs. ok miod@ | |||||
| 2014-06-01 | There is no need for is{upper,lower}() tests before to{lower,uppper}(), | deraadt | 4 | -54/+16 | |
| since all other characters are mapped through transparently. ok jsing | |||||
| 2014-06-01 | Commit this before the head-scratching leads to premature baldness: | deraadt | 2 | -2/+2 | |
| memset(a->data, 0, (unsigned int)a->max); but the decl is: size_t max; size_t could be larger than int, especially in some of the systems OpenSSL purports to support. How do _intentionally truncating_ casts like enter into a codebase? Lack of understanding of C, at a minimum. Generally the objects are small, but this code is _intentionally unready_ for large objects. ok miod | |||||
| 2014-06-01 | Build with WARNINGS=Yes and Werror. | miod | 2 | -12/+4 | |
| 2014-06-01 | Remove __bio_h__attr__ wrapper around __attribute__, since earlier statements | miod | 2 | -20/+8 | |
| in this file directly use __attribute__. ok deraadt@ | |||||
| 2014-06-01 | Add a deprecated attribute to all CRYPTO_dbg_ functions. | miod | 2 | -20/+20 | |
| ok deraadt@ | |||||
| 2014-06-01 | Build these tests with WARNINGS=Yes and -Werror, and do the necessary | miod | 40 | -65/+143 | |
| fixes to keep building. | |||||
| 2014-06-01 | Avoid the use of an uninitialised variable. In reality, this is a non-issue | jsing | 2 | -4/+2 | |
| since the calculated value is not actually used in the uninitialised case. Change the code so that we only do the calculation if we actually need it. Issue detected by clang and reported by both brad@ and Brent Cook. | |||||
| 2014-06-01 | EBCDIC support died a while ago, except in a comment. | deraadt | 2 | -4/+0 | |
| 2014-06-01 | Clean up the tls1_change_cipher_state() key length handling and use a | jsing | 2 | -20/+24 | |
| single variable with a descriptive name, instead of two poorly named variables. Largely based on Adam Langley's chromium patches. ok miod@ | |||||
| 2014-06-01 | Use C99 initialisers for cipher_aliases. This improves readability, | jsing | 2 | -184/+664 | |
| removes the need for zero values to be specified (meaning that we usually specify two fields instead of 12), makes the field names grepable and protects from future field reordering/removal. ok beck@ miod@ | |||||
| 2014-05-31 | Get the public headers from the official place with <openssl/ > | deraadt | 12 | -12/+14 | |
| from Brent Cook | |||||
| 2014-05-31 | annoying whitespace | deraadt | 2 | -6/+6 | |
| 2014-05-31 | Change the actual default for returned asn1 strings to be utf8 in the code, | beck | 2 | -2/+2 | |
| rather than only in the config file, to trip people up later. Found, and fix pleaded for by <spider@skuggor.se> who apparently spent hours chasing it down. ok miod@ | |||||
| 2014-05-31 | BUF_MEM_grow_clean() takes a size_t as the size argument. Remove false comments | miod | 4 | -18/+6 | |
| mentioning it's an int, bogus (int) casts and bounds checks against INT_MAX (BUF_MEM_grow_clean has its own integer bounds checks). ok deraadt@ | |||||
| 2014-05-31 | Add a comment documenting where libssl depends upon the current (objectionable) | miod | 2 | -0/+2 | |
| behaviour of this code, to prevent people from blindly changing it. | |||||
| 2014-05-31 | copy a comment placed in other files; req from miod | deraadt | 2 | -2/+6 | |
| 2014-05-31 | Some KNF and fix the vairable spelling. | jsing | 2 | -46/+32 | |
| 2014-05-31 | Move the cts128 and gcm128 tests to regress. | jsing | 9 | -924/+530 | |
| 2014-05-31 | More KNF. | jsing | 2 | -206/+244 | |
| 2014-05-31 | More manual OPENSSL_NO_EC and OPENSSL_NO_TLSEXT cleanup. | jsing | 8 | -28/+20 | |
| 2014-05-31 | unifdef -UDOXYGEN and manually remove the few doxygen comments that are not | jsing | 2 | -62/+0 | |
| wrapped in #ifdef DOXYGEN... Requested by miod@ | |||||
| 2014-05-31 | ECDH and ECDSA will not work overly well if there is no EC, so unifdef | jsing | 16 | -100/+0 | |
| OPENSSL_NO_EC. ok tedu@ | |||||
| 2014-05-31 | TLS would not be entirely functional without extensions, so unifdef | jsing | 30 | -360/+0 | |
| OPENSSL_NO_TLSEXT. ok tedu@ | |||||
| 2014-05-31 | Delete the extraneous "return" statement at the end of a void function. | jca | 1 | -2/+1 | |
| From Fritjof Bornebusch. | |||||
| 2014-05-31 | KNF and other cleanup. | jsing | 2 | -266/+295 | |
| 2014-05-30 | Don't add potentially nasty stderr uses to dead CRYPTO_dbg_mem functions. | deraadt | 2 | -6/+6 | |
| But do use the abort(), which we are hoping all future vendors will move towards the more modern "do not flush streams"; hint hint, if you didn't do that already, there are grave risks because much software brings risk without that behaviour. We didn't cause the change.. POSIX did... ok beck | |||||
| 2014-05-30 | Move sha256 and sha512 tests to regress and wire them up. | jsing | 7 | -332/+17 | |
| 2014-05-30 | Move the AES wrap test code into regress. | jsing | 4 | -264/+182 | |
| 2014-05-30 | More KNF. | jsing | 2 | -112/+146 | |
| 2014-05-30 | remove some #if 0 code. we don't need any more reminders that we're using | tedu | 38 | -802/+2 | |
| a not quite appropriate data structure. ok jsing | |||||
| 2014-05-30 | Make use of SSL_IS_DTLS, SSL_USE_EXPLICIT_IV, SSL_USE_SIGALGS and | jsing | 18 | -128/+100 | |
| SSL_USE_TLS1_2_CIPHERS. Largely based on OpenSSL head. | |||||
| 2014-05-30 | Fix some more nasty stringyness in here by using asprintf instead of cruft. | beck | 2 | -20/+14 | |
| gets rid of the second last use of the awful DECIMAL_SIZE. | |||||
| 2014-05-30 | more: no need to null check before free; ok guenther | deraadt | 8 | -8/+8 | |
| 2014-05-30 | more: no need for null check before free | deraadt | 88 | -424/+206 | |
| ok tedu guenther | |||||
| 2014-05-30 | While working on another diff I ended up looking to see why on earth the | jsing | 4 | -80/+12 | |
| DTLS code had a chunk that checked to see if the SSL version was *not* DTLS. Turns out that this is inside a big #if 0 block with a comment explaining why DTLS will never need this code... The DTLS code was clearly written by wholesale copying the SSLv3 code. Any code not applicable to DTLS was seemingly #if 0'd or commented out and left for others to find. d1_pkt.c is copied from s3_pkt.c and it has a do_dtls1_write() function that has the same function signature as do_ssl3_write(), except that the create_empty_fragement (yes, that is the spelling in ssl_locl.h) argument is unused for DTLS (although there is code that pretends to use it) since it uses explicit IV (as the comment notes). Instead of leaving this turd lying around, nuke the #if 0'd code (along with the check for *not* DTLS) and remove the pointless create_empty_fragment argument given the only two do_dtls1_write() calls specify zero. This kind of thing also makes you wonder how much actual peer review occurred before the code was initially committed... ok beck@ | |||||
| 2014-05-30 | Rework parse_name() so that variable declaration is separate from function | jsing | 1 | -37/+50 | |
| based initialisation, use more readable variable names and use a goto rather than duplicating the frees for the error and non-error paths... ok beck@ | |||||
| 2014-05-30 | remove CONST_STRICT. ok beck deraadt | tedu | 6 | -28/+2 | |
| 2014-05-30 | no need for null check before free. from Brendan MacDonell | tedu | 39 | -112/+57 | |
| 2014-05-30 | Don't write out more than we have allocated in obj_txt, as the glory | beck | 2 | -2/+4 | |
| that is OBJ_obj2txt() can return a larger value.. ok tedu@ | |||||
| 2014-05-30 | remove some of the bigger lies, as applicable to libressl. | tedu | 2 | -18/+6 | |
| 2014-05-29 | I do not have time to describe how bad the realloc() uses in here, now | deraadt | 2 | -8/+4 | |
| being relaced by reallocarray(). you will have to look at the diff. there can be no explanations for the extra casts. as beck says, "Don't go towards the light theo!" ok beck tedu | |||||
| 2014-05-29 | trivial realloc -> reallocarray | deraadt | 1 | -2/+1 | |
| 2014-05-29 | the comment says RAND_pseudo_bytes should be RAND_bytes. make it so. | tedu | 2 | -12/+2 | |
| ok deraadt | |||||
| 2014-05-29 | we no longer care that these aren't used for ssl2 | tedu | 2 | -4/+4 | |
| 2014-05-29 | ok, next pass after review: when possible, put the reallocarray arguments | deraadt | 17 | -27/+27 | |
| in the "size_t nmemb, size_t size" | |||||
| 2014-05-29 | convert 53 malloc(a*b) to reallocarray(NULL, a, b). that is 53 | deraadt | 51 | -93/+109 | |
| potential integer overflows easily changed into an allocation return of NULL, with errno nicely set if need be. checks for an allocations returning NULL are commonplace, or if the object is dereferenced (quite normal) will result in a nice fault which can be detected & repaired properly. ok tedu | |||||
| 2014-05-29 | Everything sane has stdio, and FILE *. we don't need ifdefs for this. | beck | 82 | -338/+0 | |
| ok to firebomb from tedu@ | |||||
 |
index : openbsd | |
| A mirror of https://github.com/libressl/openbsd.git |
| summaryrefslogtreecommitdiff |