summaryrefslogtreecommitdiff
path: root/src/lib/libc/stdlib/recallocarray.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2020-03-30Void functions obviously do not return values; no need to elaborate.schwarze5-31/+10
Patch from Martin Vahlensieck <academicsolutions dot ch>.
2020-03-29Void functions obviously do not return values; no need to elaborate.schwarze5-28/+10
Patch from Martin Vahlensieck <academicsolutions dot ch>.
2020-03-28Be concise: do not say that void functions return no values, that's obvious.schwarze3-22/+6
Useless text reported by Martin Vahlensieck (academicsolutions.ch) on tech@.
2020-03-24Fix ASN1 print functionsinoguchi1-6/+13
Check and print out boolean type properly. Based on OpenSSL commit ad72d9fdf7709ddb97a58d7d45d755e6e0504b96. Reduced unneeded parentheses from if condition. Check return value from i2s_ASN1_INTEGER. Based on OpenSSL commit 5e3553c2de9a365479324b8ba8b998f0cce3e527. Added if condition expression and return 0 if NULL is returned. ok tb@
2020-03-23Add a test program for getopt(3) that is adequate for manual testingschwarze4-2/+174
and a compact test suite for getopt(3) intended automated regression testing, both written from scratch. The suite is intended to provide full coverage, except that it doesn't test manual changes of optind and optreset and except that it so far avoids the situation where we have a known bug.
2020-03-16Consistently spell 'unsigned' as 'unsigned int', as style(9) seemstb7-44/+45
to prefer that. No binary change except in d1_srtp.c where the generated assembly differs only in line numbers (due to a wrapped long line) and in s3_cbc.c where there is no change in the generated assembly. ok inoguchi jsing
2020-03-16Adapt to tls13_record_layer.c r1.30 (the sequence number shouldn't wrap).tb1-2/+2
2020-03-16The RFC is clear (section 5.3) that sequence number should never wrap.tb1-5/+12
We currently throw an error on overflow, but still wrap. Check up front if we would need to wrap and only increment if that case is excluded. This simplifies the increment loop and makes the returns in this function less magic. ok jsing
2020-03-13Increment a few more sequence numbers where the carry is close totb1-1/+41
crossing a byte boundary.
2020-03-13Remove dtls1_enc().jsing5-222/+11
Like much of the original DTLS code, dtls1_enc() is effectively a renamed copy of tls1_enc(). Since then tls1_enc() has been modified, however the non-AEAD code remains largely the same. As such, remove dtls1_enc() and instead call tls1_enc() from the DTLS code. The tls1_enc() AEAD code does not currently work correctly with DTLS, however this is a non-issue since we do not support AEAD cipher suites with DTLS currently. ok tb@
2020-03-13Add regress for TLSv1.3 sequence number handling.jsing3-1/+135
2020-03-13Correct TLSv1.3 sequence number increment and wrapping check.jsing1-3/+3
Fix proposed by tb@
2020-03-13Add missing $OpenBSD$ tag.jsing1-0/+1
2020-03-13Add regress for CBB_add_space().jsing1-1/+41
2020-03-13Ensure that CBB_add_space() always provides zeroed memory.jsing1-1/+2
ok tb@
2020-03-12Use calloc() rather than malloc() when allocating initial CBB buffer.jsing1-4/+3
CBB uses recallocarray() to expand buffers, however was still using malloc() for the initial buffer, which could result in memory being leaked in incorrect use cases. While here also use calloc() to allocate internal structs. ok inoguchi@ tb@
2020-03-12Use calloc() rather than malloc() when allocating buffers.jsing1-3/+3
This reduces the chance of accidently leaking stack memory. ok inoguchi@ tb@
2020-03-12Stop overloading the record type for padding length.jsing5-13/+10
Currently the CBC related code stuffs the padding length in the upper bits of the type field... stop doing that and add a padding_length field to the record struct instead. ok inoguchi@ tb@
2020-03-12Use internal versions of SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA.jsing9-53/+83
SSL3_BUFFER, SSL3_RECORD and DTLS1_RECORD_DATA are currently still in public headers, even though their usage is internal. This moves to using _INTERNAL suffixed versions that are in internal headers, which then allows us to change them without any potential public API fallout. ok inoguchi@ tb@
2020-03-10Use ctx->hs->secrets rather than the S3I(s) version.jsing2-4/+4
ok inoguchi@ tb@
2020-03-10Update to follow handshake enum removal.jsing1-7/+1
2020-03-10Remove some unnecessary handshake enums/functions.jsing4-26/+4
Both session tickets and key updates are post-handshake handshake messages, which were originally included in the handshake code. ok inoguchi@ tb@
2020-03-10Add a return value check to tls13_buffer_extend().jsing1-1/+4
In the unlikely event that the return value from the read callback is larger than the number of bytes we asked for, we can end up incrementing buf->len beyond capacity. Check the return value from the read callback to prevent this. ok inoguchi@ tb@
2020-03-10Remove the enc function pointers.jsing6-22/+12
The enc function pointers do not serve any purpose these days - remove a layer of indirection and call dtls1_enc()/tls1_enc() directly. ok inoguchi@ tb@
2020-03-10Import openssl-1.1.1d test data to base64test.cinoguchi1-1/+97
ok bcook@ tb@
2020-03-10Modify regress base64test.cinoguchi1-11/+14
- Don't remove multi line CR/LF from bt->out when NL mode base64_encoding_test removes CR/LF from bt->out to compare with the encoding result. This is fine with NO NL mode, but it goes wrong with NL mode if encoding result is larger than 64 and multi line, like below. "eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4\neHh4eHh4eHh4eHh4\n" - Use memcpy instead of asprintf to avoid lost '\0' at the end of data This test data loses trailing '\0' if using asprintf. "\x61\x47\x56\x73\x62\x47\x38\x3d\x0a\x00" - Print original data if decoding result comparison fails This change is not for importing test data, but I just notice. It prints bt->out if fail to memcmp bt->in with decoding result. ok bcook@ tb@
2020-03-09cstyle in illumos noticed some weird syntax, which this fixes.dlg1-4/+4
some errx lines in if statements were terminated with commas, which caused the following statement to be considered part of the error handling. while it is bad style, ingo points out it was also a bug which which caused some tests in the code to be skipped. this reminds me of a haiku that Chris Pascoe (cpascoe@) had behind his desk: Also, that comma Should be a semi-colon. Cherry blossoms fall. this was found by Robert Mustacchi when porting the tests to illumos. ok schwarze@ stsp@ thank you robert.
2020-03-06RFC 8446, section 4.1.3: If a TLSv1.2 client receives a ServerHello fortb1-1/+27
TLSv1.1 or below, it should check whether the server's random value contains the magic downgrade protection cookie and in that case abort the handshake with an illegal parameter alert. ok inoguchi, jsing
2020-03-06TLSv1.3 servers that intend to downgrade are required to set the lasttb1-4/+8
eight bytes of the server's random to a magic cookie (RFC 8446, 4.1.3). The TLSv1.3 spec changes the TLSv1.2 spec in that it recommends that TLSv1.2 servers that negotiate TLSv1.1 or below do the same. This gives a limited additional protection against downgrade attacks beyond what is already present in the Finished exchange. The TLSv1.3 part was already implemented in Hobart and can be trivially modified to do the TLSv1.2 bit as well. ok inoguchi, jsing
2020-03-04Check high bit for base64 decodeinoguchi1-2/+10
Referred to this OpenSSL commit and adopted to the codebase. b785504a10310cb2872270eb409b70971be5e76e suggest and ok tb@
2020-03-03Fix base64 processing of long linesinoguchi1-99/+66
Fix the problem that long unbroken line of base64 text is not decoded. Referred to this OpenSSL commit and adapted to the codebase. 3cdd1e94b1d71f2ce3002738f9506da91fe2af45 Reported by john.a.passaro <at> gmail.com to the LibreSSL ML. ok tb@
2020-02-23The decryption_failed alert must not be sent by compliant implementations.tb1-2/+2
Use a bad_record_mac alert instead. Found with tlsfuzzer's ChaCha20 test. ok beck inoguchi jsing
2020-02-23According to RFC 8446, Section 4.4.4, recipients of incorrect Finishedtb2-4/+4
messages must terminate the connection with a decrypt_error alert, so replace the use of the deprecated decryption_failed alert accordingly. ok beck inoguchi jsing
2020-02-21Remove the s2n macro now that it is finally unused.jsing1-4/+1
ok inoguchi@ tb@
2020-02-21Convert the SSL/TLS record creation code to CBB.jsing1-18/+28
ok inoguchi@ tb@
2020-02-21Convert the DTLS header creation code to CBB.jsing1-20/+27
Also consolidate it into the one place, since there is no reason to write the epoch and sequence out later. ok inoguchi@ tb@
2020-02-21Remove some commented code, remove some pointless comments and move somejsing1-17/+6
comments to their correct places. ok inoguchi@ tb@
2020-02-21Convert dtls1_build_sequence_number() to CBB.jsing1-7/+15
ok inoguchi@ tb@
2020-02-21Move l2n/l2n8 into s3_cbc.c, since this is the only code that uses it.jsing2-16/+16
ok inoguchi@ tb@
2020-02-21Remove prefix_len, since it is always zero.jsing1-4/+3
ok inoguchi@ tb@
2020-02-21Remove now unused variable.jsing1-3/+1
ok inoguchi@ tb@
2020-02-19Tag subcommand sectionskn1-2/+44
Allow semantic lookup by manually tagging sections (.Sh) for which no automatic tagging has been implemented; this thereby also eliminates false positives such that ":tx509<Enter>" now jumps to the X509 section. feedback remi inoguchi schwarze OK tb
2020-02-19Refactor do_ssl3_write().jsing1-97/+98
When empty fragments were added as a countermeasure against chosen plaintext attacks on CBC, it was done by adding a recursive call to do_ssl3_write(). This makes the code more complex and difficult to change. Split the record creation code into a separate ssl3_create_record() function, which do_ssl3_write() calls. In the case where an empty fragment is needed, ssl3_create_record() is simply called twice, removing the need for recursion. ok inoguchi@ tb@
2020-02-18drop unused include <openssl/curve25519.h>tb4-10/+4
ok inoguchi jsing
2020-02-17Describe the restriction for length of openssl conf value stringinoguchi1-2/+4
ok and suggestion jmc@
2020-02-17Restrict the length of openssl conf value stringinoguchi3-5/+14
There was no limitation for the length of openssl conf value. This brings possibility of out-of-memory problem as oss-fuzz had detected. This diff restricts the length of conf value up to 64k. ok jsing@
2020-02-16Update protocol version test to include TLSv1.3.jsing2-0/+3
2020-02-16Add -tls1_3 and -notls1_3 options to openssl(1) s_client.jsing2-23/+37
Also stop using version pinned methods, instead setting the min and max protocol versions. Requested by inoguchi@ ok inoguchi@ tb@
2020-02-16Avoid potential NULL dereference when parsing a server keyshare extension.jsing1-1/+4
It is currently possible for key_share to be NULL when a TLS client receives a keyshare extension. However, for this to occur the client has to be doing TLS 1.2 or earlier, which means that it was invalid for the server to send the extension. As such, check for NULL and treat it as an invalid extension. Found by oss-fuzz (#20741 and #20745). ok inoguchi@ tb@
2020-02-16Avoid leak for tmp.x25519inoguchi2-5/+11
Changed to use local variable to hold malloc address rather than directly set to S3I(s)->tmp.x25519, and set that private_key pointer to S3I(s)->tmp.x25519 after all the "goto err;". Also added freezero for S3I(s)->tmp.x25519 to ssl3_free() and ssl3_clear(). ok jsing@ tb@
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-04-27 03:10:02 +0000