summaryrefslogtreecommitdiff
path: root/src/lib/libc/stdlib/recallocarray.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2020-06-05Apply some style(9).jsing1-34/+30
2020-06-05One error file per directory is plenty.jsing3-229/+157
2020-06-04When X509_ATTRIBUTE_create() receives an invalid NID (e.g., -1), returnschwarze4-19/+124
failure rather than silently constructing a broken X509_ATTRIBUTE object that might cause NULL pointer accesses later on. This matters because X509_ATTRIBUTE_create() is used by documented API functions like PKCS7_add_attribute(3) and the NID comes straight from the user. This fixes a bug found while working on documentation. OK tb@ and "thanks" bluhm@
2020-06-04minor polishing:schwarze1-4/+10
* below SEE ALSO, point to the most similar function that is not deprecated * add a comment saying why ERR_load_ERR_strings() is intentionally undocumented * update the comment specifying the merge status
2020-06-04Align tls13_server_select_certificate() withtb1-3/+7
tls13_client_select_certificate(). ok inoguchi
2020-06-04Improve client certificate selection for TLSv1.3tb1-16/+80
This allows clients to use EC certificates. ok inoguchi, jsing
2020-06-04mention that TLS_method(3) also supports TLSv1.3;schwarze1-3/+3
tb@ OKed this part of a larger diff from inoguchi@
2020-06-04Collapse the x509v3 directory into x509.jsing38-47/+44
This avoids the need to grep across directories to find functions and prepares for further rototilling and chainsawing. Discussed with tb@ (who also tested the release build)
2020-06-04new manual page PKCS7_add_attribute(3);schwarze7-12/+201
tweaks and OK tb@
2020-06-03Properly document PKCS7_final(3), which was already mentionedschwarze10-32/+263
in passing in some other manual pages.
2020-06-03Enable the record layer limits test and mark two finished test cases astb1-5/+8
xfail for now. Arguably, the expected decode_error is more appropriate than the decrypt_error that we send at the moment.
2020-06-02Remove const modifier in return type of tls13_handshake_active_state()tb1-3/+3
which make no sense as pointed out by gcc on sparc64. ok jsing
2020-06-02distracting whitespacetb1-5/+5
2020-06-01Split the handling of post handshake handshake messages into itstb1-55/+44
own recv function. This simplifies tls13_recod_layer_read_internal() greatly and makes the phh handling easier to reason about since the code is no longer glued to the right hand edge of the terminal. ok jsing
2020-06-01Remove expired certificate, ok tb@sthen1-53/+1
/C=SE/O=AddTrust AB/OU=AddTrust External TTP Network/CN=AddTrust External CA Root
2020-06-01Enable the test-tls13-zero-length-data.py test, skipping thetb1-8/+10
three tests that fail due to a BIO_gets() bug.
2020-06-01Enable test-dhe-rsa-key-exchange-with-bad-messages.pytb1-4/+2
2020-06-01Send an illegal_parameter alert if a client sends us invalid DH keytb1-3/+15
shares. Previously we would fail and just close the pipe. Fixes the remaining failing test-dhe-rsa-key-exchange-with-bad-messages.py tests of tlsfuzzer. ok beck (earlier version) jsing
2020-06-01Add a mechanism to set an alert in those parts of the read half oftb1-3/+21
the record layer that don't do I/O themselves. Use this mechanism to send a record overflow alert for messages that have overlong plaintext or inner plaintext. Fixes most of the remaining record-layer-limits failures of tlsfuzzer. ok jsing
2020-06-01bump to LibreSSL 3.2.1libressl-v3.2.0bcook1-3/+3
2020-05-31Replace ssl_max_server_version() with ssl_downgrade_max_version()jsing3-30/+6
Replace the only occurrence of ssl_max_server_version() with a call to ssl_downgrade_max_version() and remove ssl_max_server_version(). ok beck@ tb@
2020-05-31When building a chain look for non-expired certificates first.jsing1-8/+29
Currently, when building a certificate chain we look up an issuer and if it is the only issuer certificate available we still use it even if it has expired. When X509_V_FLAG_TRUSTED_FIRST is not in use, untrusted certificates are processed first and if one of these happens to be expired it will be used to build the chain, even if there is another non-expired option in the trusted store. Rework this code so that we first look for a non-expired untrusted certificate. If one does not exist then we take a look in the trusted store to see if we would be able to build the chain and only if there is not, do we then look for an expired untrusted certificate. This makes certificate validation possible for various sites that are serving expired AddTrust certificates. Issue reported by Christian Heimes via GitHub. ok beck@ tb@
2020-05-31Correct downgrade sentinels when a version pinned method is in use.jsing4-7/+40
Previously only the enabled protocol versions were considered, however we also have to consider the method in use which may be version pinned. Found the hard way by danj@ with haproxy and force-tlsv12. ok beck@ inoguchi@ tb@
2020-05-31Fix printing long doubles on architectures with hm and lm bits.mortimer1-1/+9
Issue reported with initial patch by enh@google.com. ok deraadt@
2020-05-29Improve server certificate selection for TLSv1.3.jsing2-23/+94
This allows an EC certificate to be selected and used, if the client sigalgs would allow it. With feedback from tb@ ok inoguchi@ tb@
2020-05-29Handle the case where we receive a valid 0 byte application data record.jsing1-1/+10
In this situation we cannot return zero bytes, as that signals EOF. Rather we need to return TLS13_IO_WANT_POLLIN so tell the caller to call us again, at which point we'll pull up the next record. ok tb@
2020-05-29Wire up the servername callback in the TLSv1.3 server.jsing3-3/+45
This makes SNI work correctly with TLSv1.3. Found the hard way by danj@, gonzalo@ and others. ok beck@ inoguchi@ tb@
2020-05-29Mop up servername_done, which is unused.jsing3-14/+3
ok beck@ inoguchi@ tb@
2020-05-29Add checks for SH downgrade sentinel and HRR hash in appstest.shinoguchi1-1/+27
2020-05-27more tests after getopt_long.c rev. 1.32;schwarze1-10/+43
OK martijn@
2020-05-27This patch fixes one bug and one instance of undesirable behaviour.schwarze1-9/+1
The bug, present since 4.4BSD, was that a trailing dash in an option group, when the dash is not permitted as an option letter, resulted in the whole option group being returned as an argument, even though the previous option in the group was already parsed as an option: OPTS=abc ./getopt-test -a- -c arg ===>> OPT(a)ARG(-a-)ARG(-c)ARG(arg). Instead, treat the dash as an invalid option and continue parsing options: ===>> OPT(a)ERR(?-)OPT(c)ARG(arg). The undesirable behaviour was that allowing the dash as an option letter only allowed isolated dashes ("-") and trailing dashes in groups ("-a-"), but neither middle dashes in groups ("-a-b"), even though that already partially worked in 4.4BSD, nor leading dashes in groups ("--a"), even though that works on all other BSDs and on glibc. Also, while POSIX does not require that the dash can be used as an option letter at all, arguably, it encourages that letters either be fully supported or not supported at all. It is dubious whether supporting an option letter in some positions but not in others can be considered conforming. This patch makes OpenBSD behaviour identical to FreeBSD and NetBSD, improves compatibility with glibc (except that glibc does not support isolated "-"), improves compatibility with DragonFly (except that DragonFly is buggy when the dash option letter can take an optional argument but that argument is not present), improves compatibility with Illumos and Solaris 11 (except those do not support "-" and mishandle "--a"), and restores 4.4BSD behaviour for "-a-b". In no respect i'm aware of is compatibility with any other systems reduced. For the full rationale, see my mail to tech@ on 30 Mar 2020 14:26:41 +0200. Part of the problem was originally reported by an anonymous coward on tech@ on 12 Mar 2020 03:40:24 +0200, additional analysis was contributed by martijn@, and then the OP sent the final version of the patch i'm now committing on 17 Mar 2020 19:17:56 +0200. No licensing problem here because after the commit, the file does not contain a single word written by the OP. Also, the OP told me in private mail that he intends to publish the patch under the ISC license already contained in the file and that he wishes to be known by the pseudonym "0xef967c36". OK martijn@, and no objection when shown on tech@, but commit delayed to stay clear of the release.
2020-05-27document PKCS7_dataFinal(3);schwarze3-3/+162
tweak and OK tb@
2020-05-26minor cleanup ahead of the following work:schwarze1-12/+14
remove references to the SSL protocol which is no longer supported and use .Xr rather than .Fn for functions documented elsewhere
2020-05-26Add additional length checks for TLSv1.3 plaintext and inner plaintext.jsing1-1/+6
Reminded by and ok beck@
2020-05-24Previous commit caught a few errx() cases by accident. undo them.tb1-25/+25
2020-05-24Fix some stylistic nits from jsing.tb1-8/+11
ok jsing
2020-05-24Clear SSL_MODE_AUTO_RETRY in libtls, since we handle WANT_POLLIN correctly.jsing1-1/+3
2020-05-24include newlines in FAIL messagestb1-108/+108
2020-05-24address some nits from jsingtb1-7/+11
2020-05-24Minimally document PKCS7_dataInit(3).schwarze4-5/+215
No comment when shown around among LibreSSL devs except "very very strange function" from beck@ and "cannot say much about it" from tb@. If needed, this can be further polished in the tree, review is still welcome.
2020-05-24Briefly mention the obsolete function OPENSSL_init(3).schwarze1-7/+23
Suggested by bluhm@, OK beck@ tb@.
2020-05-24The version detection doesn't work on bluhm's test machine, causingtb1-3/+3
the test to fail. Neuter it for now and just assume we do TLSv1.3. I have been intending to purge this version detection hack once I'm sure we can leave the 1.3 server enabled but I'll leave it here for now.
2020-05-23Define REGRESS_TARGETS explicitly.tb1-2/+4
2020-05-23Enforce that SNI hostnames be correct as per rfc 6066 and 5980.beck3-18/+159
Correct SNI alerts to differentiate between illegal parameter and an unknown name. ok tb@`
2020-05-23While the second SSL_CTX in this code is only used on servernametb1-1/+2
callback, so its mode is not used to update the ssl's mode, it seems more appropriate to clear the SSL_MODE_AUTO_RETRY flag on it as well. ok jsing
2020-05-23In ssl_lib.c revision 1.217, jsing enabled SSL_MODE_AUTO_RETRY bytb2-2/+7
default. To avoid hanging on a blocking read, we need to clear the SSL_MODE_AUTO_RETRY flag in the s_client and the s_server. ok beck inoguchi jsing
2020-05-23Enable SSL_MODE_AUTO_RETRY by default.jsing1-1/+2
In TLSv1.2 and earlier, when an application goes to read application data, handshake messages may be received instead, when the peer has triggered renegotation. A similar thing occurs in TLSv1.3 when key updates are triggered or the server sends new session tickets. Due to the SSL_read() API there is no way to indicate that we got no application data, instead after processing the in-band handshake messages it would be normal to return SSL_ERROR_WANT_READ and have the caller call SSL_read() again. However, various applications expect SSL_read() to return with either application data or a fatal error, when used on a blocking socket. These applications do not play well with TLSv1.3 post-handshake handshake messages (PHH), as they fail to handle SSL_ERROR_WANT_READ. The same code is also broken in the case of a TLSv1.2 or older renegotiation, however these are less likely to be encountered. Such code should set SSL_MODE_AUTO_RETRY in order to avoid these issues. Contrary to the naming, SSL_MODE_AUTO_RETRY does not actually retry in every case - it retries following handshake messages in the application data stream (i.e. renegotiation and PHH messages). This works around the unretried SSL_read() on a blocking socket case, however in the case where poll/select is used with blocking sockets, the retry will likely result in the read blocking after the handshake messages are processed. Rather than pushing for broken code to be fixed, OpenSSL decided to enable SSL_MODE_AUTO_RETRY by default, instead breaking code that does poll or select on blocking sockets (like s_client and s_server). Unfortunately we get to follow suit. ok beck@ inoguchi@ tb@
2020-05-23Wire up SSL_MODE_AUTO_RETRY mode to retrying after PHH messages.jsing2-2/+8
ok beck@ inoguchi@ tb@
2020-05-23Provide the option to retry or return after post-handshake messages.jsing2-4/+16
In TLSv1.3 post-handshake handshake messages are used for key updates and session tickets. These are in-band and mean that when the upper layer goes to read application data, we can end up reading and having to process handshake messages - this option changes whether we retry and read the next TLS record, or if we return, signalling that we want more data to be available. ok beck@ inoguchi@ tb@
2020-05-23fix a confusingly wrapped linetb1-3/+3
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-05-10 22:34:12 +0000