summaryrefslogtreecommitdiff
path: root/src/lib/libc/stdlib/recallocarray.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2023-02-16zap stray empty linetb1-2/+1
2023-02-16Add missing masks to accumulator version of bn_umul_hilo()jsing1-1/+5
2023-02-16libressl *_namespace.h: adjust *_ALIAS() to require a semicolontb85-1006/+1006
LCRYPTO_ALIAS() and LSSL_ALIAS() contained a trailing semicolon. This does not conform to style(9), breaks editors and ctags and (most importantly) my workflow. Fix this by neutering them with asm("") so that -Wpedantic doesn't complain. There's precedent in libc's namespace.h fix suggested by & ok jsing
2023-02-16Reimplement bn_add_words() and bn_sub_words() using bignum primitives.jsing2-111/+88
This removes the effectively duplicate BN_LLONG version of bn_add_words() and simplifies the code considerably. ok tb@
2023-02-15Place bn_mul_add_words() after bn_mul_words().jsing1-39/+39
2023-02-15zap tabtb1-2/+2
2023-02-14Remove the misnamed and now unused mul, mul_add and mul_add_c macros.jsing1-122/+2
There were only three versions of each one... ok tb@
2023-02-14Reimplement bn_mul_words(), bn_mul_add_words() and bn_mul_comba{4,8}().jsing1-235/+152
Use bignum primitives rather than the current mess of macros, which also allows us to remove the essentially duplicate versions of bn_mul_words() and bn_mul_add_words() for BN_LLONG. The "mul" macro gets replaced by bn_mulw_addw(), "mul_add" with bn_mulw_addw_addw() and "mul_add_c" with bn_mulw_addtw() (where 'w' indicates single word input and 'tw' indicates triple word input). The variables in the comba functions have also been reordered, so that the patterns are easier to understand - the compiler can take care of optimising the inputs and outputs to avoid register moves. ok tb@
2023-02-14Provide big number primitives for word addition/multiplication.jsing1-1/+114
These use a consistent naming scheme and are implemented using bitwise/constant time style operations, which should generally be safe on all platforms (until a compiler decides to optimise and use branches). More optimised versions can be provided for a given architecture. ok tb@
2023-02-14Make BN_is_zero() check word values.jsing1-4/+9
Rather than completely relying on top, check the words of a bignum. This gets us one step away from being dependent on top and additionally means that we correctly report zero even if top is not yet correct. ok tb@
2023-02-14Fix a -0 corner case in BN_div_internal()jsing1-3/+5
If the numerator is negative, the numerator and divisor are the same length (in words) and the absolute value of the divisor > the absolute value of the numerator, the "no_branch" case produces -0 since negative has already been set. Call BN_set_negative() at the end of the function to avoid this. ok tb@
2023-02-14Reimplement BN_num_bits_word().jsing1-20/+25
Provide a simpler and more readable bn_word_clz() function that returns the number of leading zeros for a given BN_ULONG, then implement BN_num_bits_word() using bn_word_clz(). This is a hot path and bn_word_clz() can now be replaced with architecture specific versions where possible. ok tb@
2023-02-14Make BN_set_negative() closer to constant time.jsing1-2/+3
ok tb@
2023-02-14Provide bn_ct_{eq,ne}_zero{,_mask}() inline functions.jsing1-1/+33
These will be used to test a BN_ULONG in cases where constant time style behaviour is required. ok tb@
2023-02-14Add regress coverage for BN_num_bits_word()tb1-1/+25
2023-02-13asn1x509 test: Remove unnecessary line continuationstb1-24/+24
2023-02-13Merge dsa_sign.c and dsa_vrf.c into dsa_ossl.ctb4-166/+37
discussed with jsing
2023-02-13dsa/dsa_sign.c: unindent by inverting logic for DSA_SIG_free(NULL)tb1-6/+7
2023-02-13dsa/dsa_sign.c: shuffle functions into a more sensible ordertb1-13/+13
2023-02-13Revise for negative zero changes.jsing1-2/+2
2023-02-13Avoid negative zero.jsing10-36/+40
Whenever setting negative to one (or when it could potentially be one), always use BN_set_negative() since it checks for a zero valued bignum and will not permit negative to be set in this case. Since BN_is_zero() currently relies on top == 0, call BN_set_negative() after top has been set (or bn_correct_top() has been called). This fixes a long standing issue where -0 and +0 have been permitted, however multiple code paths (such as BN_cmp()) fail to treat these as equivalent. Prompted by Guido Vranken who is adding negative zero fuzzing to oss-fuzz. ok tb@
2023-02-13Simplify BN_set_negative().jsing1-6/+3
ok tb@
2023-02-13Add currently failing negative zero check to BN_rshift() regress.jsing1-1/+5
2023-02-11Remove bn_exp2.c, which is now empty.jsing2-118/+1
2023-02-11Bye bye x86_64-gcc.c.jsing1-559/+0
This is no longer used, since we're now using s2n-bignum functions instead.
2023-02-09Use .section .rodata instead of a plain .rodatatb14-15/+15
At least gcc 12 on Fedora is very unhappy about a plain .rodata and throws Error: unknown pseudo-op: `.rodata'. So add a .section in front of it to make it happy. ok deraadt miod
2023-02-09Pull in bn_internal.h for the generic version of bn_umul_hilo()jsing1-1/+2
2023-02-09Clean up bn_sqr_words()jsing2-53/+10
Currently there are two versions of bn_sqr_words(), which call the sqr or sqr64 macro. Replace this with a single version that calls bn_umul_hilo() and remove the various implementations of the sqr macro. The only slight downside is that sqr64 does three multiplications instead of four, given that the second and third terms are identical. However, this is a minimal gain for the amount of duplication and entanglement it introduces. ok tb@
2023-02-08openssl(1) pkcs7 avoid crash on malformed filestb1-5/+9
When printing certificates or CRLs, check signed and signedAndEnveloped before dereferencing them. Prevents crash on inspecting malformed PKCS7 files. ok jsing
2023-02-07Fix arbitrary memory read in GENERAL_NAME_cmp()tb1-2/+3
The ASN.1 template for GENERAL_NAME and its corresponding C structure disagree on the type of the x400Address member. This results in an ASN.1 string to be considered as an ASN.1 type, which allows an attacker to read (essentially) arbitrary memory. Fix this by forcing comparison as strings. While the underlying type confusion has been present since time immemorial, this particular bug came with the EdiPartyName fix (6.8/008_asn1.patch.sig). Reported by David Benjamin, fix suggested by jsing. Release date for this was set to be January 31. Unilaterally pushed back to February 7 by OpenSSL by way of announcement of many completely unrelated embargoed issues, some of which they had been sitting on since July 2020. ok beck jsing
2023-02-07libcrypto/ec: another missing point-on-curve checktb1-3/+9
Unlike in the affine/compressed/... cases, when setting projective coordinates of an elliptic curve point, there is no check whether the point is actually on the curve. Pointed out by Guido Vranken ok beck miod
2023-02-04Remove bn_sqr_words() on amd64.jsing2-11/+2
s2n-bignum's bignum_sqr() is not the same as bn_sqr_words() (which only computes a partial result, unlike the former). This went unnoticed since bn_sqr() is called directly on amd64, hence bn_sqr_words() is currently unused.
2023-02-04Fix output constraints for bn_umul_hilo().jsing4-8/+8
When bn_umul_hilo() is implemented using an instruction pair, mark the first output with a constraint that prevents the output from overlapping with the inputs ("&"). Otherwise the first instruction can overwrite the inputs, which then results in the second instruction producing incorrect value.
2023-02-03Move BN_mod_exp2_mont() to bn_exp.c.jsing2-188/+186
2023-02-03Reorder functions in bn_exp.c to be slightly sensible...jsing1-282/+279
No functional change intended.
2023-02-03Clean up and simplify BN_mod_lshift{,_quick}().jsing1-38/+34
BN_mod_lshift() already has a BN_CTX available, make use of it rather than calling BN_dup() and BN_free(). In BN_mod_lshift_quick(), BN_copy() already handles dst == src, so avoid checking this before the call. The max_shift == 0 case can also be handled without code duplication. And as with other *_quick() functions, use BN_ucmp() and BN_usub() directly given the 0 <= a < m constraint. ok tb@
2023-02-03Clean up BN_mod_mul() and simplify BN_mod_sqr().jsing1-14/+16
Use the same naming/code pattern in BN_mod_mul() as is used in BN_mul(). Note that the 'rr' allocation is unnecessary, since both BN_mul() and BN_sqr() handle the case where r == a || r == b. However, it avoids a potential copy on the exit from BN_mul()/BN_sqr(), so leave it in place for now. Turn BN_mod_sqr() into a wrapper that calls BN_mod_mul(), since it already calls BN_sqr() in the a == b. The supposed gain of calling BN_mod_ct() instead of BN_nnmod() does not really exist. ok tb@
2023-02-03Simplify BN_mod_{lshift1,sub}_quick().jsing1-13/+19
The BN_mod_.*_quick() functions require that their inputs are non-negative and are already reduced. As such, they can and should use BN_ucmp() and BN_usub() instead of BN_cmp() and BN_add()/BN_sub() (which internally call BN_uadd()/BN_usub() and potentially BN_cmp()). ok tb@
2023-02-03Simplify BN_nnmod().jsing1-13/+12
In the case that the result is negative (i.e. one of a or m is negative), the positive result can be achieved via a single BN_usub(). This simplifies BN_nnmod() and avoids indirection via BN_add()/BN_sub(), which do BN_cmp() and then call into BN_uadd()/BN_usub(). ok tb@
2023-02-03Turn BN_mod_{ct,nonct}() into symbols.jsing2-6/+19
Also use accurate/useful variables names. ok tb@
2023-02-02Remove AIX toc data after every function. NFCmiod5-71/+2
2023-02-02Refactor BN_uadd() and BN_usub().jsing3-39/+99
Unlike bn_add_words()/bn_sub_words(), the s2n-bignum bignum_add() and bignum_sub() functions correctly handle inputs with differing word lengths. This means that they can be called directly, without needing to fix up any remaining words manually. Split BN_uadd() in two - the default bn_add() implementation calls bn_add_words(), before handling the carry for any remaining words. Likewise split BN_usub() in two - the default bn_sub() implementation calls bn_sub_words(), before handling the borrow for any remaining words. On amd64, provide an implementation of bn_add() that calls s2n-bignum's bignum_add() directly, similarly with an implementation of bn_sub() that calls s2n-bignum's bignum_sub() directly. ok tb@
2023-02-02Unbreak vpaes-x86 implementation.jsing1-2/+0
Remove remnants of previous PIC handling. ok miod@
2023-02-02Move all data blocks from .text to .rodata and cleanup up and homogeneize codemiod3-18/+5
responsible from getting the proper address of those blocks.
2023-02-02Sync function prototypes and declarations to satisfy clang 15.anton1-3/+3
ok jsing@
2023-02-01Move all data blocks from .text to .rodata and cleanup up and homogeneize codemiod16-236/+248
responsible from getting the proper address of those blocks. ok tb@ jsing@
2023-02-01For xonly, move sha512-ppc.pl's table from text to rodatagkoehler1-18/+7
OpenBSD/macppc will enforce xonly on PowerPC G5, then libcrypto's sha256 would crash by SIGSEGV, because it can't read text. Use ELF relocations "@ha" and "@l" to find the table in rodata. This might break the PowerPC asm on a not-ELF platform (like AIX or Mac OS) if someone would try it there. ok kettenis@ deraadt@
2023-02-01Don't run session tests with openssl 3.0 - these tests aren't TLSv1.3 readytb1-2/+2
2023-02-01Hopefully the last one.tb1-4/+4
2023-02-01One more openssl 1.0.2 thing missed.tb1-4/+4
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-05-18 16:38:04 +0000