| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
Casting a pointer to an unsigned long discards bits on an LLP64 system.
ok deraadt@
|
|
|
|
|
|
|
|
|
| |
Several functions that need to be redefined for a Windows port are right
in the middle of other code that is relatively portable. This patch
isolates the functions that need Windows-specific implementations so
they can be built conditionally in the portable tree.
ok jsing@ deraadt@
|
|
|
|
| |
ok jsing@ deraadt@
|
|
|
|
| |
ok beck@ tedu@ miod@ guenther@ doug@ deraadt@
|
|
|
|
| |
ok beck@ tedu@ miod@
|
|
|
|
|
|
|
|
|
|
| |
Remove the remaining random casts on optval. Fixups for this can be handled by
the portability layer all in once place.
Remove remaining fake socklen_t unions, though beck@ points out that this also
removes support for socklen_t changing its length at runtime. RIP.
ok tedu@ beck@ miod@ deraadt@
|
|
|
|
| |
ok beck@ miod@ tedu@ deraadt@
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
return the number of items read of written.
When you intend to return the number of bytes actually processed, it is
wise to pass 1 as the item size and the size as the number of items.
But in *some* places, the OpenSSL does the opposite, and has extra logic
to change a successful return of 1 (item processed) into the real size.
And, guess why it does that? Because of old VMS, for they (used to) have a
substandard stdio implementation.
Note that this change causes the return values of BIO_dump_fp() and
BIO_dump_indent_fp() to no longer be useless (actual number of callback calls),
but actual bytes output. Given the irrelevance of the return value before,
it is unlikely that anything depends upon it (and if something does, it
probably has other problems in need for a fix...)
ok tedu@ beck@ jsing@
|
|
|
|
|
|
|
|
| |
arc4random_buf() is guaranteed to always succeed - it is worth noting
that a number of the replaced function calls were already missing return
value checks.
ok deraadt@
|
|
|
|
|
|
| |
only that it returns -1 on failure.
pointed out by guenther@
|
|
|
|
|
|
|
|
|
| |
Prefer this because it is the POSIX standard and has consistent behavior
across platforms.
Use BIO_socket_nbio consistently across the tree.
from Jonas 'Sortie' Termansen, ok deraadt@
|
|
|
|
|
|
|
|
|
| |
The crypto/bio/bss_dgram.c file assumes that another file indirectly
includes <stdlib.h> that includes <sys/time.h>.
from Jonas 'Sortie' Termansen
ok deraadt@ tedu@
|
|
|
|
|
|
| |
Remove unnecessary NULL check.
ok miod@
|
|
|
|
| |
ok bcook@
|
|
|
|
| |
locked throughout.
|
|
|
|
|
|
| |
intrinsics. This is the easy ones, a few left to check one at
a time.
ok miod@ deraadt@
|
|
|
|
| |
ok jsing@
|
|
|
|
|
|
|
| |
while we can take it out in portable at compile time, it is still a problem
when we install this header file on a system that doesn't support __bounded__
if this is unguarded.
ok miod@ bcook@
|
|
|
|
| |
PR #3439 via OpenSSL trunk
|
|
|
|
| |
OpenSSL trunk
|
|
|
|
|
|
|
|
| |
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@
|
|
|
|
|
|
|
|
|
| |
an OPENSSL_NO_* define. This avoids relying on something else pulling it
in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is
never going to do anything, since OPENSSL_NO_XYZ will never defined, due
to the fact that opensslconf.h has not been included.
This also includes some miscellaneous sorting/tidying of headers.
|
| |
|
|
|
|
|
|
| |
are needed in the source files that actually require them.
ok beck@ miod@
|
| |
|
|
|
|
| |
ok jsing@
|
|
|
|
|
|
|
| |
Also remove <sys/filio.h> added from previous commit.
This was the wrong way to get FIONBIO.
ok jsing@
|
|
|
|
| |
ok beck@
|
|
|
|
| |
ok beck@
|
|
|
|
| |
ok beck@
|
| |
|
|
|
|
|
|
| |
getservbyname(). While here, provide a common/single return path.
ok deraadt@
|
|
|
|
|
|
| |
correct types and fewer casts.
ok deraadt@ miod@
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handrolled version could not even make use of sscanf(), since that would
not work with a certain antiquated compiler.
It is worth noting that there is a tiny change in behaviour - previously
calling BIO_get_host_ip() with something that looked like it might be a
valid IP address (for example, "1." or even ".") would result in it
returning failure rather than trying a BIO_gethostbyname() - now we'll
always try a BIO_gethostbyname() if it was not a valid IPv4 address.
ok beck@ miod@ deraadt@
|
|
|
|
|
|
| |
appear by itself.
ok beck@ miod@
|
| |
|
| |
|
|
|
|
|
|
|
| |
an atoi() followed by an unsigned short cast. This stops things like "-1"
and "66536" from being considered to be "valid" port numbers.
ok beck@ deraadt@
|
| |
|
| |
|
|
|
|
| |
ok beck
|
| |
|
|
|
|
| |
discussed with tedu, ok jsing
|
|
|
|
|
|
| |
(From Martin Brejcha)
OK from tedu@, miod@ and deraadt@
|
|
|
|
|
|
| |
in this file directly use __attribute__.
ok deraadt@
|
|
|
|
| |
gets rid of the second last use of the awful DECIMAL_SIZE.
|
|
|
|
| |
ok tedu guenther
|
| |
|
|
|
|
| |
ok to firebomb from tedu@
|