summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/dsa/dsa_key.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2017-01-17Correctly tls_config_set_ca_file() return value (no effective change).jsing1-2/+2
Spotted by inoguchi@
2017-01-13whitespacederaadt1-3/+3
2017-01-12Inline strlen() call to reduce/simplify code.jsing1-5/+2
2017-01-12Inline tls_get_new_cb_bio() from the only place that it gets called,jsing1-22/+11
simplifying the code. Also check the provided read and write callbacks before assigning to the context.
2017-01-12If tls_set_cbs() fails an error will already be specified, so do notjsing2-8/+4
replace it with a less specific one.
2017-01-12change two trailing Xr to Fn; ok schwarzejmc2-6/+6
2017-01-12Simplify the TLS callback BIO code - a pointer to the tls context can bejsing1-66/+7
stored directly in bio->ptr, rather than allocating and deallocating an intermediate struct. Diff from Marko Kreen <markokr at gmail dot com> - thanks!
2017-01-12If tls_get_new_cb_bio() fails, an error will already be set.jsing1-5/+2
2017-01-12If no callbacks are specified, return after setting an error rather thanjsing1-2/+4
continuing on. Also noticed by Marko Kreen.
2017-01-12Add regress tests for libtls, which currently cover handshakes and closesjsing3-1/+356
using callbacks, file descriptors and sockets.
2017-01-11Add support for AArch64.patrick2-0/+182
2017-01-09Avoid leaking conninfo servername.jsing1-1/+3
Issue found by and fix from Shuo Chen <chenshuo at chenshuo dot com>.
2017-01-09Provide TLS_INT for consistency with libssl/libcrypto.jsing2-2/+4
2017-01-07add missing comma in the NAME sectionschwarze1-3/+3
2017-01-07fix a typo in an .Xr reported by jmc@schwarze1-3/+3
2017-01-07Add and remove some blank lines, in order to make X509_verify_cert()jsing1-6/+4
(slightly) more readable.
2017-01-07a little more cleanup;jmc5-23/+23
2017-01-07Revert part of r1.54 as there are at least two situations where we are stilljsing1-4/+2
returning ok == 1, with ctx->error not being X509_V_OK. Hopefully we can restore this behaviour once these are ironed out. Discussed with beck@
2017-01-07correctly mark all documented macros found in <openssl/bn.h>schwarze3-9/+11
2017-01-07Use .Fn rather than .Xr for X509_VERIFY_PARAM_lookup(),schwarze1-3/+3
fixing a dead link reported by jmc@. Only about half of X509_VERIFY_PARAM is documented so far, and the extensible lookup table feels like one of the more arcane features and probably not the next thing to document.
2017-01-07Document X509_NAME_hash(3), listed in <openssl/x509.h>;schwarze1-3/+20
jmc@ reported that X509_LOOKUP_hash_dir(3) references it. Even though OpenSSL does not document it, given that it is used for file names that users have to create, it is sufficiently exposed to users to be worth documenting.
2017-01-07Write a new manual page X509_STORE_load_locations(3) from scratch.schwarze2-1/+119
Not documented by OpenSSL, but listed in <openssl/x509_vfy.h> and referenced from X509_LOOKUP_hash_dir(3), and clearly more important than the latter. Fixes three dead links reported by jmc@. Most of the information from SSL_CTX_load_verify_locations(3) should probably be moved here, but not all, since the SSL page also talks about SSL servers and clients and the like. As i'm not completely sure regarding the boundaries, i'm leaving that as it is for now.
2017-01-06Remove cross references to the undocumented functions X509_STORE_new(3)schwarze2-7/+4
and X509_STORE_add_lookup(3) reported by jmc@. Even though these functions are public, they seem more useful internally than for application programs, so now is not the time to document them.
2017-01-06Delete a sentence containing a cross reference to an undocumentedschwarze1-6/+2
function that had the the sole purpose of discouraging its use. Not talking about it at all discourages using it even more. Dangling cross reference reported by jmc@.
2017-01-06resolve duplication of names and prototypes in manuals related to ex_dataschwarze5-67/+23
and sprinkle cross references instead; more work is obviously needed here
2017-01-06Replace two dangling .Xrs to sk_*() macros with .Fn; reported by jmc@.schwarze1-4/+6
The safestack stuff is the most ill-designed user interface i have seen so far in OpenSSL. It looks positively undocumentable. At least i'm not trying to document it right now.
2017-01-06Delete a cross reference to the undocumented function X509_check_purpose(3)schwarze1-3/+2
that wasn't accompanied by any related information. Reported by jmc@. There are a dozen functions handling X509_PURPOSE objects, all undocumented, a host of defines, and it seems that a callback is required. So this seems complicated, i doubt that is much used in practice, and i'm not diving into it at this point in time.
2017-01-06Remove bogus cross reference to ui_create(3) reported by jmc@schwarze1-6/+8
and refer readers to the header file instead. I'm not convinced customized prompting is such a bright idea, it feels somewhat like overengineering, so i'm not documenting it right now. People who really feel compelled to roll their own prompting can go read the source code.
2017-01-06Remove dangling .Xrs to PKCS7_final(3) reported by jmc@schwarze2-6/+5
and just use .Fn for now. Not counting constructors, destructors, decoders, encoders, and debuggers, six out of 24 public functions operating on PKCS7 objects are currently documented. I'm not documenting the remaining 18 ones at this point in time.
2017-01-06Remove a dangling .Xr to PKCS7_SIGNER_INFO_sign(3) reported by jmc@schwarze1-3/+3
and just use .Fn for now. There are about two dozen interfaces dealing with PKCS7_SIGNER_INFO objects and none but the constructor, destructor, decoder, and encoder are documented so far. It makes no sense to document one random one, and i'm not going to document all of PKCS7_SIGNER_INFO right now.
2017-01-06Remove a dangling cross reference reported by jmc@.schwarze1-5/+8
I'm not convinced documenting EVP_MD_CTX_set_flags(3) would be wise. Instead, refer people to the header file to make it more obvious that they are tinkering with internals when using such flags.
2017-01-06Add EVP_read_pw_string(3) to NAME and SYNOPSIS,schwarze1-14/+29
resolving a dangling cross reference reported by jmc@. Sort NAME and SYNOPSIS to agree with .Dt and DESCRIPTION. Unify parameter names. Delete a sentence about an implementation detail that is no longer true. Mention the length limitation of the *_string() variants.
2017-01-06Delete a cross reference to the non-existent manual page BIO_set_flags(3),schwarze1-11/+8
reported by jmc@. Documenting that function would be a bad idea. All other flags are used internally and should better not be tampered with. It looks like an internal function that was made public by mistake, then abused for an unrelated user interface purpose: a classic case of botched user interface design. Instead, only show how to use this function for this one specific purpose. While here, delete a sentence from the DESCRIPTION that merely duplicated content from the BUGS section.
2017-01-06Delete a sentence that attempted to explain an implementation detailschwarze1-4/+2
by referencing a non-existent manual page. Broken .Xr reported by jmc@.
2017-01-06fix typos in cross references reported by jmc@schwarze2-6/+6
2017-01-06Delete bogus cross reference reported by jmc@.schwarze1-5/+6
Documenting these trivial PKCS7_type_is_*() macros does not seem useful, at least not right now.
2017-01-06delete bogus cross references reported by jmc@schwarze1-11/+7
and add some missing escaping of backslashes while here
2017-01-06tweak previous;jmc1-11/+13
2017-01-05Also document the weird d2i_ASN1_UINTEGER(3), listed in <openssl/asn1.h>schwarze1-1/+16
and in OpenSSL doc/man3/d2i_X509.pod (with wrong prototype).
2017-01-05Write new d2i_ASN1_OCTET_STRING(3) manual page from scratch.schwarze3-2/+373
All 36 functions listed in <openssl/asn1.h> and in OpenSSL doc/man3/d2i_X509.pod, six of them with wrong prototypes.
2017-01-05Avoid a side-channel cache-timing attack that can leak the ECDSA privatejsing1-1/+3
keys when signing. This is due to BN_mod_inverse() being used without the constant time flag being set. This issue was reported by Cesar Pereida Garcia and Billy Brumley (Tampere University of Technology). The fix was developed by Cesar Pereida Garcia.
2017-01-05minor tweaks;jmc2-5/+5
2017-01-05Complete rewrite, documenting 16 additional constructor/destructor pairs.schwarze1-98/+189
While OpenSSL does not document them, they are public in <openssl/asn1.h>, and OpenSSL does document the related decoders and encoders. It makes no sense to me to document object methods without documenting the public constructors as well. While here: Bugfix: The type assigned by ASN1_STRING_new() was wrong. Remove implementation details. Add small amounts of useful auxiliary information.
2017-01-04Convert ARM assembly to unified syntax. Clang demands it, binutilspatrick1-4/+5
supports it as long as it's marked as unified syntax. ok bcook@ kettenis@
2017-01-04Write new d2i_ASN1_SEQUENCE_ANY(3) manual page from scratch.schwarze2-1/+87
All four functions are listed in <openssl/asn1.h> and in OpenSSL doc/man3/d2i_X509.pod. Note that in the OpenSSL documentation, three of the four prototypes are incorrect.
2017-01-04Remove superfluous datatype that is 32 by default. Clang complainspatrick1-1/+1
about it and it's ok to remove it. This only came up as our clang is targeted at armv7 which enables the NEON instructions. ok kettenis@
2017-01-04Remove unnecessary casts of 'a' to char * since 'a' is already char *.millert1-10/+10
This is a remnant from the original 4.4BSD code that had 'a' as void * in the function args. No binary change. OK bluhm@
2017-01-04Complete rewrite:schwarze1-58/+72
Better one-line description. Specify the correct header file. Same parameter names as in ASN1_item_d2i(3). Lots of new information. The ASN1_OBJECT interfaces appear specifically designed to maximize the number and subtlety of traps, maybe in order to trap the wary along with the unwary. All the quirks, caveats, and bugs of ASN1_item_d2i(3) apply, and there are three additional ones on top in this page. It looks like that design approach was so successful that the designers managed to trap even themselves: see the new BUGS section.
2017-01-04Describe what ASN1_OBJECT_new(3), ASN1_OBJECT_free(3), OBJ_dup(3),schwarze2-34/+105
and OBJ_create(3) really do rather than making broad and incomplete statements that are only true in some cases. Improve the one-line descriptions. Some minor wording improvements while here. There is obviously more work to do in the vicinity...
2017-01-03Document d2i_ASN1_TYPE(3) and i2d_ASN1_TYPE(3),schwarze1-9/+46
both listed in <openssl/asn1.h> and in OpenSSL doc/man3/d2i_X509.pod. Minor wording improvements while here.