summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/dsa/dsa_lib.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2018-08-24Remove DSA from TODO list and add RSA-PSS back.tb1-2/+2
2018-08-24Also test DSA with the DER encoded key. Lots of help from jsing, thanks!tb1-1/+27
2018-08-24Clean up handshake message start/finish functions.jsing6-76/+38
Now that all handshake messages are created using CBB, remove the non-CBB ssl3_handshake_msg_start()/ssl3_handshake_msg_finish() functions. Rename the CBB variants by dropping the _cbb suffix. ok bcook@ inoguchi@ tb@
2018-08-23Run our DSA against wycheproof test vectors.tb1-1/+129
2018-08-23Add license header.inoguchi1-0/+17
2018-08-23Check reusing SSL/TLS session ticket by regression testinoguchi1-8/+38
- Added checking for session ticket reusing with using openssl(1) s_server and s_client command in appstest.sh - Confirm certificate verification status. - Save s_server message to log file. ok tb@ and jsing@
2018-08-22Use a monotonic clock for the benchmark timeout.cheloha1-24/+9
While here, we don't need the app_timer_* wrapper function, it only obfuscates things, so delete it. Also while here, totalTime only needs to be assigned once. ok tb@
2018-08-22Correct session ticket encryption.jsing1-4/+11
The CBB conversion resulted in the ticket encryption being handled incorrectly, resulting in only the last block being used. Fix this and restore the previous behaviour. Issue found by inoguchi@ and sebastia@. ok inoguchi@ and tb@
2018-08-21fix return valuetb1-3/+3
2018-08-21Remove ChaCha20-Poly1305 from the TODO listtb1-2/+2
2018-08-21A failure to _seal() should be looked into, so turn this into antb1-7/+2
unconditional failure.
2018-08-21Factor the calls to EVP_AEAD_CTX_open() and EVP_AEAD_CTX_seal() intotb1-48/+76
their own functions to make it easier to handle failures cleanly. Discussed with jsing
2018-08-21Merge duplicate benchmark() GET/SSL_shutdown blocks into doConnection().cheloha1-41/+25
We need to then remove the shadow i from the GET block. While there, move retval's declaration to the beginning of the function. As doConnection() now executes the body of the benchmark's test, rename it to "run_test". Shadow variable spotted by tb@. ok tb@
2018-08-21typo in argument type, from Mario dot Andres dot Campos at gmail dot comschwarze1-3/+3
2018-08-20add two missing \ntb1-3/+3
2018-08-20Test EVP_AEAD_CTX_open() at the same time as EVP_AEAD_CTX_seal()tb1-5/+23
Suggested by jsing
2018-08-20remove two redundant teststb1-10/+1
2018-08-20Use sealed instead of out in a couple of places in preparation oftb1-12/+13
testing EVP_AEAD_CTX_open()
2018-08-20Shuffle the decoding of the hex strings to the top and group all lengthtb1-22/+26
tests together. Make failure of the length tests non-fatal, as these are failures of test cases, not of the program.
2018-08-20Run the Wycheproof ChaCha20-Poly1305 test vectors against libcrypto.tb1-1/+141
We currently only support nonces of length 12, so skip a few tests. With input from jsing
2018-08-19Don't leak sktmp in X509_verify_cert().tb1-5/+5
CID #118791 ok jsing mestre
2018-08-19whitespace fixtb1-2/+2
2018-08-19Don't leak db on error in RSA_padding_check_PKCS1_OAEP().tb1-7/+7
CID #183499. input & ok jsing, ok mestre on first version
2018-08-19Don't leak a strdup()'ed string on error in do_accept().tb1-1/+3
CID #154702. input & ok inoguchi, ok mestre on first version
2018-08-19Rename and collapse tls12_get_sigandhash_cbb().jsing4-39/+28
Now that all callers of tls12_get_sigandhash() have been converted to CBB, collapse tls12_get_sigandhash() and tls12_get_sigandhash_cbb() into a single function. Rename it to tls12_gethashandsig() to be representative of the actual order of the sigalgs parameters, and perform some other clean up. ok inoguchi@ tb@
2018-08-19Convert ssl3_send_newsession_ticket() to CBB.jsing1-55/+64
This removes a memorable BUF_MEM_grow() and associated comment. ok inoguchi@ tb@
2018-08-18Plug SSL object leaks in doConnection().cheloha1-32/+22
Move SSL_new/SSL_free up into benchmark() to restrict the responsibility for the SSL object to a single scope. Make doConnection() return an int, openssl-style. Some miscellaneous cleanup, too. Discussed with tb, jsing, and jca. Basic idea from jsing, lots of patch input from tb. ok deraadt on an earlier version ok tb jsing
2018-08-17Convert ssl3_send_client_verify() to CBB.jsing1-43/+50
ok inoguchi@ tb@
2018-08-17spelling;jmc1-2/+2
2018-08-17Make the wording more concise, use the imperative throughout, stateschwarze1-108/+126
more precisely which options require which other options, add many missing incompatibilities, mention the default for -e, and some macro cleanup. OK jmc@ tb@
2018-08-16Add regress coverage for CBB_add_u32().jsing1-3/+4
2018-08-16Provide CBB_add_u32(), as needed for an upcoming conversion.jsing2-2/+17
ok tb@
2018-08-16Simplify the add signature code/logic in ssl3_send_server_key_exchange().jsing1-13/+8
ok tb@
2018-08-16Convert ssl3_send_server_key_exchange() to CBB.jsing3-47/+71
ok inoguchi@ tb@
2018-08-16Convert ssl3_get_server_key_exchange() to CBS.jsing1-69/+55
ok inoguchi@ tb@
2018-08-16Revert previous, which was wrong as noted by schwarze. Also revert a hunktb1-4/+7
from r1.45 and thereby avoid a use-after-free spotted by schwarze. ok schwarze
2018-08-16Remove unused variable.rob1-5/+3
From Nan at chinadtrace dot org. Thanks!
2018-08-14Add a comment that explains what the check is doing and why len >= 1.tb1-1/+2
Prompted by a remark by jsing
2018-08-14The UI_add_{input,verify}_string() functions want a length not includingtb1-5/+8
the terminating NUL. EVP_read_pw_string_min() got this wrong, leading to a one-byte buffer overrun in all callers of EVP_read_pw_string(). Found by mestre running 'openssl passwd' with MALLOC_OPTIONS including C. Fix this by doing some basic sanity checking in EVP_read_pw_string_min(). Cap the len argument at BUFSIZ and ensure that min < len as well as 0 <= min and 1 <= len. The last two checks are important as these numbers may end up in reallocarray(). ok bcook (on previous version), jsing, mestre
2018-08-14Remove now unused variable, that got left behind from a previous change.jsing1-3/+1
2018-08-14Actually check the return values for EVP_Sign* and EVP_Verify*.jsing2-15/+23
ok bcook@ beck@ tb@
2018-08-14Don't fail by default in the -new case; ok tb jcacheloha1-19/+12
2018-08-11Refactor the nearly identical benchmark loops into a single loop.cheloha1-139/+108
Move all of the benchmark code -- loop initialization, the loops, and the report printing -- into a new function, benchmark(). Eliminates lots of duplicate code. Regressions to 1.20 caught by tb@ and inoguchi@. Tweaked by tb@. ok tb@, jsing@
2018-08-10Simplify server key exchange signature verification.jsing1-49/+18
Everything can go through the EVP_Verify* code path. ok inoguchi@ tb@
2018-08-10Simplify server kex exchange signature generation.jsing1-61/+33
Everything can go through the single EVP_Sign* code path. ok inoguchi@ tb@
2018-08-10Add glue to EVP_md5_sha1() so that it can be used with EVP_Sign* andjsing1-1/+12
EVP_Verify*. ok tb@
2018-08-10Add missing include to X25519 synopsis.jsing1-2/+3
2018-08-10In typical swiss-army style, various modes and options causederaadt1-1/+24
different unveils. Joint work with beck and florian. Let us know if you hit any corner cases.
2018-08-10Run the wycheproof ECDSA test vectors against libcrypto.jsing1-7/+147
Skip the ecdsa_webcrypto_test.json vectors for the time being, as these likely need some extra glue.
2018-08-10Run the X25519 wycheproof test vectors against libcrypto.jsing1-13/+82
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-05-05 08:28:16 +0000