summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/malloc-wrapper.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-05-31Change the actual default for returned asn1 strings to be utf8 in the code,beck2-2/+2
rather than only in the config file, to trip people up later. Found, and fix pleaded for by <spider@skuggor.se> who apparently spent hours chasing it down. ok miod@
2014-05-31BUF_MEM_grow_clean() takes a size_t as the size argument. Remove false commentsmiod4-18/+6
mentioning it's an int, bogus (int) casts and bounds checks against INT_MAX (BUF_MEM_grow_clean has its own integer bounds checks). ok deraadt@
2014-05-31Add a comment documenting where libssl depends upon the current (objectionable)miod2-0/+2
behaviour of this code, to prevent people from blindly changing it.
2014-05-31copy a comment placed in other files; req from miodderaadt2-2/+6
2014-05-31Some KNF and fix the vairable spelling.jsing2-46/+32
2014-05-31Move the cts128 and gcm128 tests to regress.jsing9-924/+530
2014-05-31More KNF.jsing2-206/+244
2014-05-31More manual OPENSSL_NO_EC and OPENSSL_NO_TLSEXT cleanup.jsing8-28/+20
2014-05-31unifdef -UDOXYGEN and manually remove the few doxygen comments that are notjsing2-62/+0
wrapped in #ifdef DOXYGEN... Requested by miod@
2014-05-31ECDH and ECDSA will not work overly well if there is no EC, so unifdefjsing16-100/+0
OPENSSL_NO_EC. ok tedu@
2014-05-31TLS would not be entirely functional without extensions, so unifdefjsing30-360/+0
OPENSSL_NO_TLSEXT. ok tedu@
2014-05-31Delete the extraneous "return" statement at the end of a void function.jca1-2/+1
From Fritjof Bornebusch.
2014-05-31KNF and other cleanup.jsing2-266/+295
2014-05-30Don't add potentially nasty stderr uses to dead CRYPTO_dbg_mem functions.deraadt2-6/+6
But do use the abort(), which we are hoping all future vendors will move towards the more modern "do not flush streams"; hint hint, if you didn't do that already, there are grave risks because much software brings risk without that behaviour. We didn't cause the change.. POSIX did... ok beck
2014-05-30Move sha256 and sha512 tests to regress and wire them up.jsing7-332/+17
2014-05-30Move the AES wrap test code into regress.jsing4-264/+182
2014-05-30More KNF.jsing2-112/+146
2014-05-30remove some #if 0 code. we don't need any more reminders that we're usingtedu38-802/+2
a not quite appropriate data structure. ok jsing
2014-05-30Make use of SSL_IS_DTLS, SSL_USE_EXPLICIT_IV, SSL_USE_SIGALGS andjsing18-128/+100
SSL_USE_TLS1_2_CIPHERS. Largely based on OpenSSL head.
2014-05-30Fix some more nasty stringyness in here by using asprintf instead of cruft.beck2-20/+14
gets rid of the second last use of the awful DECIMAL_SIZE.
2014-05-30more: no need to null check before free; ok guentherderaadt8-8/+8
2014-05-30more: no need for null check before freederaadt88-424/+206
ok tedu guenther
2014-05-30While working on another diff I ended up looking to see why on earth thejsing4-80/+12
DTLS code had a chunk that checked to see if the SSL version was *not* DTLS. Turns out that this is inside a big #if 0 block with a comment explaining why DTLS will never need this code... The DTLS code was clearly written by wholesale copying the SSLv3 code. Any code not applicable to DTLS was seemingly #if 0'd or commented out and left for others to find. d1_pkt.c is copied from s3_pkt.c and it has a do_dtls1_write() function that has the same function signature as do_ssl3_write(), except that the create_empty_fragement (yes, that is the spelling in ssl_locl.h) argument is unused for DTLS (although there is code that pretends to use it) since it uses explicit IV (as the comment notes). Instead of leaving this turd lying around, nuke the #if 0'd code (along with the check for *not* DTLS) and remove the pointless create_empty_fragment argument given the only two do_dtls1_write() calls specify zero. This kind of thing also makes you wonder how much actual peer review occurred before the code was initially committed... ok beck@
2014-05-30Rework parse_name() so that variable declaration is separate from functionjsing1-37/+50
based initialisation, use more readable variable names and use a goto rather than duplicating the frees for the error and non-error paths... ok beck@
2014-05-30remove CONST_STRICT. ok beck deraadttedu6-28/+2
2014-05-30no need for null check before free. from Brendan MacDonelltedu39-112/+57
2014-05-30Don't write out more than we have allocated in obj_txt, as the glorybeck2-2/+4
that is OBJ_obj2txt() can return a larger value.. ok tedu@
2014-05-30remove some of the bigger lies, as applicable to libressl.tedu2-18/+6
2014-05-29I do not have time to describe how bad the realloc() uses in here, nowderaadt2-8/+4
being relaced by reallocarray(). you will have to look at the diff. there can be no explanations for the extra casts. as beck says, "Don't go towards the light theo!" ok beck tedu
2014-05-29trivial realloc -> reallocarrayderaadt1-2/+1
2014-05-29the comment says RAND_pseudo_bytes should be RAND_bytes. make it so.tedu2-12/+2
ok deraadt
2014-05-29we no longer care that these aren't used for ssl2tedu2-4/+4
2014-05-29ok, next pass after review: when possible, put the reallocarray argumentsderaadt17-27/+27
in the "size_t nmemb, size_t size"
2014-05-29convert 53 malloc(a*b) to reallocarray(NULL, a, b). that is 53deraadt51-93/+109
potential integer overflows easily changed into an allocation return of NULL, with errno nicely set if need be. checks for an allocations returning NULL are commonplace, or if the object is dereferenced (quite normal) will result in a nice fault which can be detected & repaired properly. ok tedu
2014-05-29Everything sane has stdio, and FILE *. we don't need ifdefs for this.beck82-338/+0
ok to firebomb from tedu@
2014-05-29remove back compat that was already disabled back in 1998.tedu2-16/+0
from Alexander Schrijver
2014-05-29Make make includes work again without kssl.hbeck1-2/+2
2014-05-29Any sane platform has stdio. Stop pretending we will ever use a platformbeck18-64/+0
that does not. "fire bomb" tedu@
2014-05-29kssl is dead.tedu1-68/+0
2014-05-29no space before labeltedu4-54/+54
2014-05-29line up else bettertedu2-10/+4
2014-05-29define -DLIBRESSL_INTERNAL in here so we don't use nastiesbeck1-2/+2
ok deraadt@
2014-05-29consistent bracestedu2-26/+26
2014-05-29unidef DH, ECDH, and ECDSA. there's no purpose to a libssl without them.tedu26-434/+0
ok deraadt jsing
2014-05-29repair KNF indentderaadt2-2/+2
2014-05-29use calloc, from Benjamin Baiertedu2-10/+2
2014-05-29Make it substantially easier to identify protocol version requirementsjsing16-18/+164
by adding an enc_flags field to the ssl3_enc_method, specifying four flags that are used with this field and providing macros for evaluating these conditions. Currently the version requirements are identified by continually checking the version number and other criteria. This change also adds separate SSL3_ENC_METHOD data for TLS v1.1 and v1.2, since they have different enc_flags from TLS v1. Based on changes in OpenSSL head. No objection from miod@
2014-05-29When you have functions that perform specific functions, use them.jsing2-36/+18
EVP_CIPHER_CTX_free() does a NULL check, then calls EVP_CIPHER_CTX_cleanup() and frees the memory. COMP_CTX_free() also had its own NULL check, so there is no point in duplicating that here. ok beck@
2014-05-29Fix another two cases where the return value of ssl_replace_hash() isjsing2-16/+36
unchecked. In the case of tls1_change_cipher_state(), it is fairly pointless to use ssl_replace_hash(), since it does not initialise the hash and there is special handling required in the DTLS write case. Instead, just inline the part of ssl_replace_hash() that is needed and only ssl_clear_hash_ctx() the write hash in the non-DTLS case. Also add a detailed comment explaining why there needs to be specialised handling for DTLS write context and where the contexts are actually freed. ok miod@
2014-05-29Add missing NULL checks for calls to ssl_replace_hash(). This functionjsing1-2/+6
calls EVP_MD_CTX_create(), which will return NULL if it fails to allocate memory. ok miod@