summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/objects/obj_dat.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-06-07malloc() result does not need a cast.deraadt1-6/+6
ok miod
2014-06-07Remove another NULL check before a BIO_free().jsing2-8/+8
2014-06-07ssl3_free_digest_list() has its own NULL check.jsing3-13/+9
2014-06-07BIO_free has an implicit NULL check, so do not bother checking for NULLjsing7-42/+21
before calling it.
2014-06-07ssl3_release_{read,write}_buffer() handle being called with NULL buffers,jsing2-8/+6
so do not bother checking before calling.
2014-06-07The DH_free, EC_KEY_free, EVP_PKEY_free and RSA_free functions all havejsing10-158/+88
implicit NULL checks, so there is no point ensuring that the pointer is non-NULL before calling them.
2014-06-07More KNF.jsing2-12/+8
2014-06-07More KNF.jsing2-38/+44
2014-06-07Add basic regression test for modf() issue.tobiasu3-2/+40
encouraged by deraadt and miod
2014-06-06s/assember/assembler/ before someone gets offended. At the lastderaadt21-34/+34
hackathon, just saying 'ass ember' was enough to start giggles. Unfortunately far more offensive stuff remains in here...
2014-06-05Do not recurse when a 'Hello Request' message is received while gettingjsing2-2/+4
DTLS fragments. A stream of 'Hello Request' messages will result in infinite recursion, eventually crashing the DTLS client or server. Fixes CVE-2014-0221, from OpenSSL. Reported to OpenSSL by Imre Rad.
2014-06-05Ensure that sess_cert is not NULL before trying to use it.jsing2-0/+16
Fixes CVE-2014-3470, from OpenSSL. ok deraadt@
2014-06-05Avoid a buffer overflow that can be triggered by sending specially craftedjsing2-2/+14
DTLS fragments. Fix for CVE-2014-0195, from OpenSSL. Reported to OpenSSL by Juri Aedla. ok deraadt@ beck@
2014-06-05ssl_sess_cert_new() can return NULL. Fix two cases where the return valuejsing2-26/+24
is unchecked, which would result in a later null pointer dereference. While here, RSA_free, DH_free and EC_KEY_free all have implicit NULL checks, so avoid repeating them here. ok beck@
2014-06-05Ensure that we do not process a ChangeCipherSpec with an empty masterjsing2-2/+2
secret. This is an additional safeguard against early ChangeCipherSpec handling. From OpenSSL. ok deraadt@
2014-06-05Be selective as to when ChangeCipherSpec messages will be accepted.jsing8-6/+32
Without this an early ChangeCipherSpec message would result in session keys being generated, along with the Finished hash for the handshake, using an empty master secret. For a detailed analysis see: https://www.imperialviolet.org/2014/06/05/earlyccs.html This is a fix for CVE-2014-0224, from OpenSSL. This issue was reported to OpenSSL by KIKUCHI Masashi. Unfortunately the recent OpenSSL commit was the first we were made aware of the issue. ok deraadt@ sthen@
2014-06-05More KNF.jsing2-98/+64
2014-06-04Sanitize use of client_opaque_prf_input: set it to NULL immediately aftermiod2-36/+44
free()ing it, rather than in conditional code. Also do not bother setting server_opaque_prf_input (server, not client) to NULL in conditional code 10 lines after explicitely free()ing it and setting it to NULL (were the developers afraid of zombie pointers?) ok guenther@
2014-06-04Fix a leak that can occur when len == 0, and as a result we leak a \0 byte.logan2-2/+2
(From Frantisek Boranek) OK from miod@
2014-06-04without overthinking it, replace a few memcmp calls with CRYPTO_memcmptedu10-16/+16
where it is feasible to do so. better safe than sorry.
2014-06-03Fix memory leak.logan2-0/+2
(From Martin Brejcha) OK from tedu@, miod@ and deraadt@
2014-06-02Remove references to RANDFILE.jsing1-19/+2
2014-06-02Remove RANDFILE remnants.jsing3-5/+0
2014-06-02Remove details regarding -rand from the openssl man page.jsing1-123/+3
2014-06-02Stop pretending that openssl(1) applications support the -rand option.jsing15-123/+11
The underlying code has long been removed, making this a no-op. If your random subsystem actually requires that you seed it from a file, then you really should go and buy a new random subsystem that was built after 1990. Diff from Brent Cook. ok deraadt@
2014-06-02A few months back there was a big community fuss regarding direct-usederaadt15-388/+2
of the intel RDRAND instruction. Consensus was RDRAND should probably only be used as an additional source of entropy in a mixer. Guess which library bends over backwards to provide easy access to RDRAND? Yep. Guess which applications are using this support? Not even one... but still, this is being placed as a trap for someone. Send this support straight to the abyss. ok kettenis
2014-06-02Rename more variables for readability and consistency.jsing2-50/+50
2014-06-02move random bytes buffer to be part of mmaped pages; ok tedu@otto1-21/+18
2014-06-02Since pqueue is a private interface and the header defining the structguenther2-8/+6
isn't even exported, there's no (sane) way for someone else to use the typedef. Eliminate the typedef and just use "struct _pqueue *". duplicate typedef pointed out by Brent Cook (busterb (at) gmail.com) ok miod@
2014-06-01Clean up some of the nightmare of string and pointer arithmatic inbeck2-104/+72
this nasty function. This gets rid of the nasty tmp variables used to hold temporary strings and the DECIMAL_SIZE hack. it gets rid of the rather pointless null checks for buf (since the original code dereferences it before checking). It also gets rid of the insane possibility this could return -1 when stuff is using the return values to compute lengths All the failure cases now return 0 and an empty string like the first error case in the original code. ok miod@ tedu@
2014-06-01realloc with NULL is same as mallocderaadt2-8/+2
ok guenther
2014-06-01Make usage for -quiet match the manpage and fix a misspellingguenther1-2/+2
2014-06-01Overhaul the key block handling in tls1_change_cipher_state() - usejsing2-92/+132
meaningful variable names with pointer arithmitic, rather than n, i, j and p with array indexing. Based on Adam Langley's chromium diffs. ok miod@
2014-06-01In tls1_setup_key_block(), use the correct IV length for GCM mode, whichjsing2-34/+48
results in the key block length calculation also being correct. Rename a number of variables so that their purpose becomes clear and simplify some of the code. Inspired by Adam Langley's chromium diffs. ok miod@
2014-06-01There is no need for is{upper,lower}() tests before to{lower,uppper}(),deraadt4-54/+16
since all other characters are mapped through transparently. ok jsing
2014-06-01Commit this before the head-scratching leads to premature baldness:deraadt2-2/+2
memset(a->data, 0, (unsigned int)a->max); but the decl is: size_t max; size_t could be larger than int, especially in some of the systems OpenSSL purports to support. How do _intentionally truncating_ casts like enter into a codebase? Lack of understanding of C, at a minimum. Generally the objects are small, but this code is _intentionally unready_ for large objects. ok miod
2014-06-01Build with WARNINGS=Yes and Werror.miod2-12/+4
2014-06-01Remove __bio_h__attr__ wrapper around __attribute__, since earlier statementsmiod2-20/+8
in this file directly use __attribute__. ok deraadt@
2014-06-01Add a deprecated attribute to all CRYPTO_dbg_ functions.miod2-20/+20
ok deraadt@
2014-06-01Build these tests with WARNINGS=Yes and -Werror, and do the necessarymiod40-65/+143
fixes to keep building.
2014-06-01Avoid the use of an uninitialised variable. In reality, this is a non-issuejsing2-4/+2
since the calculated value is not actually used in the uninitialised case. Change the code so that we only do the calculation if we actually need it. Issue detected by clang and reported by both brad@ and Brent Cook.
2014-06-01EBCDIC support died a while ago, except in a comment.deraadt2-4/+0
2014-06-01Clean up the tls1_change_cipher_state() key length handling and use ajsing2-20/+24
single variable with a descriptive name, instead of two poorly named variables. Largely based on Adam Langley's chromium patches. ok miod@
2014-06-01Use C99 initialisers for cipher_aliases. This improves readability,jsing2-184/+664
removes the need for zero values to be specified (meaning that we usually specify two fields instead of 12), makes the field names grepable and protects from future field reordering/removal. ok beck@ miod@
2014-05-31Get the public headers from the official place with <openssl/ >deraadt12-12/+14
from Brent Cook
2014-05-31annoying whitespacederaadt2-6/+6
2014-05-31Change the actual default for returned asn1 strings to be utf8 in the code,beck2-2/+2
rather than only in the config file, to trip people up later. Found, and fix pleaded for by <spider@skuggor.se> who apparently spent hours chasing it down. ok miod@
2014-05-31BUF_MEM_grow_clean() takes a size_t as the size argument. Remove false commentsmiod4-18/+6
mentioning it's an int, bogus (int) casts and bounds checks against INT_MAX (BUF_MEM_grow_clean has its own integer bounds checks). ok deraadt@
2014-05-31Add a comment documenting where libssl depends upon the current (objectionable)miod2-0/+2
behaviour of this code, to prevent people from blindly changing it.
2014-05-31copy a comment placed in other files; req from miodderaadt2-2/+6
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-04-27 19:01:08 +0000