summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/ui/ui_util.c (unfollow)
Commit message (Collapse)AuthorFilesLines
2014-06-11c-file-style hints, begone; ok beckderaadt1-1/+1
2014-06-10Check return value of EVP_MD_CTX_copy_ex() in ssl3_handshake_mac()logan1-1/+3
to avoid potential null pointer dereference. Based on david ramos work. OK from miod@ and jsing@
2014-06-10stick with 16k buffers for a little while to avoid bufferbloat.tedu1-2/+2
atomicio writing out 64k in one direction will cause traffic in the other direction to stall until it's complete. discussion with deraadt
2014-06-10increase buffer size to 64k, and actually use it. ok deraadttedu1-3/+3
from John-Mark Gurney
2014-06-10Abandon the auto-ENGINE /dev/crypto interface. VIA 3des cbc receivesderaadt9-2738/+4
collateral damage. The syncronous nature of this mechanism has hampered performance for symmetric crypto relative to brute-force cpu. The assymetric crypto support never really materialized in drivers. So abandon the complexity. ok tedu beck mikeb some disagrement from djm but if he wants to test /dev/crypto ciphers he should do it without this this gigantic API in the way
2014-06-10KNF.jsing16-1512/+1512
2014-06-10KNF.jsing22-870/+1032
2014-06-10Remove pointless casts and use c instead of &c[0], since it is the samejsing1-9/+3
thing for an unsigned char array. ok deraadt@
2014-06-10In tls1_cert_verify_mac(), check the return value of EVP_MD_CTX_copy_ex()jsing2-6/+10
to avoid a possible NULL function call on ctx.final(). None of the callers currently check the return value of calls to cert_verify_mac(), however the function already returns 0 in another case and the MAC comparison will later fail. Issue reported by David Ramos.
2014-06-10Use C99 initialisers for EVP_MD structs, for clarity, grepability and tojsing22-360/+532
protect from future field reordering/removal. No difference in generated assembly.
2014-06-10More KNF.jsing1-19/+18
2014-06-10Avoid potential NULL pointer function calls in n_ssl3_mac() by checkingjsing1-2/+4
the return value of EVP_MD_CTX_copy_ex(). If the copy fails early then EVP_DigestUpdate() will invoke md_ctx.update(), which will be a NULL function pointer. Analysis and patch from David Ramos. ok deraadt@
2014-06-10Multiple fixes for ssl3_digest_cached_records() - if EVP_MD_CTX_create()jsing1-8/+12
fails, the NULL check will add an error but it does not abort. This will result in EVP_DigestInit_ex() being called with a NULL context. Also ensure that we check the return values from EVP_DigestInit_ex() and EVP_DigestUpdate(). ok deraadt@ miod@
2014-06-10Ensure ssl3_final_finish_mac() returns failure if either the MD5 or SHA1jsing1-5/+10
handshake MAC calculation fails. Currently, the result from both ssl3_handshake_mac() calls is added together. This means that unless both MD5 and SHA1 fail, a positive value will be returned to the caller, indicating success rather than failure. ok deraadt@ miod@ sthen@
2014-06-10mop up ifndef KERNEL goo; ok miodderaadt12-60/+12
2014-06-09use memset instead of bzeroderaadt2-4/+4
2014-06-09do not include dso.h where it is not needed; ok miodderaadt6-6/+0
2014-06-09More KNF.jsing1-11/+11
2014-06-08Add an SSL_CIPHER_ALGORITHM2_AEAD flag that is used to mark a cipher asjsing4-0/+114
using EVP_AEAD. Also provide an EVP_AEAD-only equivalent of ssl_cipher_get_evp().
2014-06-08Add a define for the SSLv3 sequence size and use it, rather than sprinklingjsing7-14/+16
magic numbers around. ok deraadt@
2014-06-08No, we will not be building with OPENSSL_NO_X509_VERIFY. Nuke it andjsing2-28/+16
do some other clean up while here. ok deraadt@
2014-06-08Clean up BIO_free() handling in bio_ssl.c - BIO_free() has its own NULLjsing2-26/+32
check, so do not duplicate it here. Make the error handling consistent by always using 'goto err' rather than returning in certain cases. Also add a missing BIO_free(ssl) in BIO_new_ssl_connect(). ok deraadt@
2014-06-08Be explicit with types. No binary change.jsing2-6/+6
2014-06-08Stop using DSO_global_lookup to reach getaddrinfo() and friendsderaadt2-80/+6
discussed with tedu, ok jsing
2014-06-08Factor out the part of tls1_change_cipher_state() that is specific tojsing6-252/+310
switching cipher states using an EVP_CIPHER. This will facilitate the addition of cipher state changes for EVP_AEAD. No functional change. Based on Adam Langley's chromium patches.
2014-06-08Factor out the sequence number reset code to aid in upcoming changes.jsing2-16/+20
2014-06-07/* on some platforms time_t may be a float */deraadt1-3/+3
In the past, time_t's type was underspecified. But a floating point type would not have worked in practice. Newer specifications effectively forbid it. While cleaning this up, get partly ready for Y2038. ok miod
2014-06-07http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=2016265dfbab162e ↵deraadt14-86/+12
c30718b5e7480add42598158 Don't know the full story, but it looks like a "can't do random perfectly, so do it god awful" problem was found in 2013, and replaced with "only do it badly if a flag is set". New flags (SSL_MODE_SEND_SERVERHELLO_TIME and SSL_MODE_SEND_SERVERHELLO_TIME) were added [Ben Laurie?] to support the old scheme of "use time_t for first 4 bytes of the random buffer". Nothing uses these flags [ecosystem scan by sthen] Fully discourage use of these flags in the future by removing support & definition of them. The buflen < 4 check is also interesting, because no entropy would be returned. No callers passed such small buffers. ok miod sthen
2014-06-07Add missing NULL check after calling EVP_PKEY_new_mac_key().jsing2-0/+4
Based on Adam Langley's chromium patches.
2014-06-07Use !is_read to imply SSL3_CC_WRITE.jsing2-6/+4
While this is not strictly correct (since the presence of SSL3_CC_READ does not guarantee the absence of SSL3_CC_WRITE), in practice only one of these flags is set at a time and there is existing logic which already relies on this behaviour.
2014-06-07Move the export label initialisation into the export handling code, sincejsing2-12/+22
this is the only place where these variables are used.
2014-06-07Remove pointless casts - no binary change.jsing2-4/+4
2014-06-07Rename variables to make it clear that these are only used in the exportjsing2-30/+36
code. Additionally, these need to be cleaned in the export case. Based on Adam Langley's chromium patches.
2014-06-07Further clean up of context handling in tls1_change_cipher_state().jsing2-42/+34
Rather than doing a complex dance to figure out if we should reuse the cipher context and clean it later on, just free it and allocate a new one. This simplifies the code path, especially in the write case where special handling is required for DTLS. Also, calling EVP_CIPHER_CTX_init() for a newly created cipher context is unnecessary, since EVP_CIPHER_CTX_new() already does this (not to mention that it was already missing from the write case).
2014-06-07Remove various test stubs. The good ones have been moved by jsingderaadt48-5814/+0
and others to the regress framework. These remaining ones just muddle us up when re-reading code repeatedly. ok jsing
2014-06-07evptests.txt lives in regress/lib/libcrypto/evpjsing2-668/+0
2014-06-07malloc() result does not need a cast.deraadt108-163/+159
ok miod
2014-06-07Remove another NULL check before a BIO_free().jsing2-8/+8
2014-06-07ssl3_free_digest_list() has its own NULL check.jsing3-13/+9
2014-06-07BIO_free has an implicit NULL check, so do not bother checking for NULLjsing7-42/+21
before calling it.
2014-06-07ssl3_release_{read,write}_buffer() handle being called with NULL buffers,jsing2-8/+6
so do not bother checking before calling.
2014-06-07The DH_free, EC_KEY_free, EVP_PKEY_free and RSA_free functions all havejsing10-158/+88
implicit NULL checks, so there is no point ensuring that the pointer is non-NULL before calling them.
2014-06-07More KNF.jsing2-12/+8
2014-06-07More KNF.jsing2-38/+44
2014-06-07Add basic regression test for modf() issue.tobiasu3-2/+40
encouraged by deraadt and miod
2014-06-06s/assember/assembler/ before someone gets offended. At the lastderaadt21-34/+34
hackathon, just saying 'ass ember' was enough to start giggles. Unfortunately far more offensive stuff remains in here...
2014-06-05Do not recurse when a 'Hello Request' message is received while gettingjsing2-2/+4
DTLS fragments. A stream of 'Hello Request' messages will result in infinite recursion, eventually crashing the DTLS client or server. Fixes CVE-2014-0221, from OpenSSL. Reported to OpenSSL by Imre Rad.
2014-06-05Ensure that sess_cert is not NULL before trying to use it.jsing2-0/+16
Fixes CVE-2014-3470, from OpenSSL. ok deraadt@
2014-06-05Avoid a buffer overflow that can be triggered by sending specially craftedjsing2-2/+14
DTLS fragments. Fix for CVE-2014-0195, from OpenSSL. Reported to OpenSSL by Juri Aedla. ok deraadt@ beck@
2014-06-05ssl_sess_cert_new() can return NULL. Fix two cases where the return valuejsing2-26/+24
is unchecked, which would result in a later null pointer dereference. While here, RSA_free, DH_free and EC_KEY_free all have implicit NULL checks, so avoid repeating them here. ok beck@
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-04-29 06:07:59 +0000