summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/x509/x509_pcons.c (unfollow)
Commit message (Collapse)AuthorFilesLines
4 daysExplicitly pass group generator to mul_double_nonct() from EC_POINT_mul().jsing4-35/+33
EC_POINT_mul() has a complex multi-use interface - there are effectively three different ways it will behave, depending on which arguments are NULL. In the case where we compute g_scalar * generator + p_scalar * point, the mul_double_nonct() function pointer is called, however only g_scalar, p_scalar and point are passed - it is expected that the lower level implementation (in this case ec_wnaf_mul()) will use the generator from the group. Change mul_double_nonct(), ec_mul_double_nonct() and ec_wnaf_mul() so that they take scalar1, point1, scalar2 and point2. This removes all knowledge of g_scalar and the generator from the multiplication code, keeping it limited to EC_POINT_mul(). While here also consistently pass scalar then point, rather than a mix of scalar/point and point/scalar. ok tb@
4 daysCheck group generator in EC_POINT_mul().jsing1-1/+6
When a non-NULL generator scalar is passed to EC_POINT_mul(), the group's generator will be used in multiplication. Add a check that ensures that the group generator is non-NULL, in order to avoid needing to handle this elsewhere (currently in the lower level point multiplication code). ok tb@
8 daysPlug a memory leak in x509_name_encode()tb1-2/+4
This is nearly identical to a leak fixed by miod 10 years ago in x509_name_canon() but was missed in r1.30. This entire file needs a metric ton of bleach, but my head currently spins too much for tackling this, so go with the cheap one-liner. From Niels Dossche
9 daysx509_param_set_hosts_internal: rename vpm to param for consistencytb1-11/+11
9 daysX509_VERIFY_PARAM_lookup(): avoid passing stack garbage aroundtb1-1/+2
ok jsing
9 daysRename pm to param, fix the type of idx and unindenttb1-8/+6
ok jsing
9 daysIntroduce and use N_DEFAULT_VERIFY_PARAMStb1-6/+9
ok jsing
9 daysX509_VERIFY_PARAM_get0(): use consistent idiom for default_table accesstb1-2/+3
ok jsing
9 daysX509_VERIFY_PARAM_lookup(): remove unnecessary braces and add empty linetb1-3/+3
ok jsing
9 daysX509_VERIFY_PARAM_get_count(): make NULL check explicittb1-2/+2
ok jsing
9 daysX509_VERIFY_PARAM_get0: avoid out of bounds access when id < 0tb1-1/+5
ok jsing
9 daysAdjust x509_name_regress to the X509_NAME_print() fix in a_strex.c r1.38tb1-15/+2
9 daysFix traditional SSLeay X509_NAME printingtb1-29/+1
The gibberish that was there before the rewrite didn't actually skip names whose SN representation was different start with /O= or /OU= (with one or two capital letters between '/' and '='), it simply failed to separate them, resulting in nonsense such as CN=Microsec e-Szigno Root CA 2009/emailAddress=info@e-szigno.hu So ditch the code doing that, simplifying this now internal function quite a bit. ok jsing
10 dayssave_index: fix some code quality issuestb1-13/+16
Error check BIO_new() both times it is used, drop unused j variable, Error check BIO_printf() call and turn the whole thing into single exit. Prompted by a diff by Niels Dossche ok jsing
10 daysPKCS7_dataVerify(): zap offensive whitespacetb1-2/+2
10 daysPKCS7_signatureVerify(): add missing free after EVP_VerifyUpdate()tb1-2/+4
From Nils Dossche
11 daysapps.c: don't leak out in error pathtb1-1/+2
From Niels Dossche
12 daysUpdate cert.pem, ok sthentb1-215/+179
Added to existing CA /C=DE/O=D-Trust GmbH/CN=D-TRUST BR Root CA 2 2023 /C=DE/O=D-Trust GmbH/CN=D-TRUST EV Root CA 2 2023 Added back: /C=AT/O=e-commerce monitoring GmbH/CN=GLOBALTRUST 2020 Deleted: /C=US/O=Entrust, Inc./OU=See www.entrust.net/legal-terms/OU=(c) 2015 Entrust, Inc. - for authorized use only/CN=Entrust Root Certification Authority - G4 /C=JP/O=Japan Certification Services, Inc./CN=SecureSign RootCA11 /C=JP/O=SECOM Trust Systems CO.,LTD./CN=Security Communication RootCA3 /C=CH/O=SwissSign AG/CN=SwissSign Silver CA - G2
13 daysRename a bunch of confusingly named variablestb1-6/+6
Variables of the type serialized or deserialized are called val_in or val_out in all other manuals, so align this page to using those rather than the confusing X509_CRL **der_out, etc.
13 daysAdd regress coverage for X509_NAME_oneline and X509_NAME_printtb2-1/+314
14 daysconst correct d2i_* prototypestb4-13/+13
2025-03-13minor libssl bump (SSL_OP_NO_RENEGOTIATION/SSL_OP_ALLOW_CLIENT_RENEGOTIATION)sthen2-2/+2
code #ifdef'ing these and compiled with new headers won't work as expected on earlier libraries minor libtls bump to match libssl bump ok tb@
2025-03-13pkey_ec_derive: fix call to ECDH_compute_key()tb1-2/+2
The last argument is a pointer to the KDF, so use NULL, not 0.
2025-03-13Simplify field and private key encodingtb1-13/+3
Reach into the group (p and order are always available) and use BN_num_bytes() rather than using clumsy and badly named API. It's shorter and more readable. ok jsing
2025-03-13Make srtp.h self-standing by including ssl.htb1-1/+3
ok miod
2025-03-12Provide an accelerated SHA-512 assembly implementation for aarch64.jsing4-2/+353
This provides a SHA-512 assembly implementation that makes use of the ARM Cryptographic Extension (CE), which is found on many arm64 CPUs. This gives a performance gain of up to 2.5x on an Apple M2 (dependent on block size). If an aarch64 machine does not have SHA512 support, then we'll fall back to using the existing C implementation. ok kettenis@ tb@
2025-03-12Test SSL_OP_NO_RENEGOTIATION and SSL_OP_ALLOW_CLIENT_RENEGOTIATION.jsing1-1/+56
Extend renegotiation tests to cover SSL_OP_NO_RENEGOTIATION and SSL_OP_ALLOW_CLIENT_RENEGOTIATION.
2025-03-12Provide SSL_OP_NO_RENEGOTIATION and SSL_OP_ALLOW_CLIENT_RENEGOTIATION.jsing4-6/+36
In January 2017 we added SSL_OP_NO_CLIENT_RENEGOTIATION, which results in a SSL_AD_NO_RENEGOTIATION fatal alert if a ClientHello message is seen on an active connection (client initiated renegotation). Then in May 2017 OpenSSL added SSL_OP_NO_RENEGOTIATION, which results in a SSL_AD_NO_RENEGOTIATION warning alert if a server receives a ClientHello on an active connection (client initiated renegotation), or a client receives a HelloRequest (server requested renegotation). This option also causes calls to SSL_renegotiate() and SSL_renegotiate_abbreviated() to fail. Then in 2021, OpenSSL also added SSL_OP_ALLOW_CLIENT_RENEGOTIATION, which trumps SSL_OP_NO_RENEGOTIATION but only for incoming ClientHello messages (apparently unsetting SSL_OP_NO_RENEGOTIATION is too hard). Provide SSL_OP_NO_RENEGOTIATION and SSL_OP_ALLOW_CLIENT_RENEGOTIATION, primarily to make life easier for ports. If SSL_OP_NO_CLIENT_RENEGOTIATION is set it will take precedence and render SSL_OP_ALLOW_CLIENT_RENEGOTIATION ineffective. The rest of the behaviour should match OpenSSL, with the exception of ClientHellos triggering fatal alerts instead of warnings. ok tb@
2025-03-12Use .arch rather than .cpu for sha2 instructions.jsing1-2/+2
We have code that targets a specific architecture level, hence .arch makes more sense here than .cpu. Suggested by kettenis@
2025-03-12Streamline X509_VERIFY_PARAM_add0_table()tb1-17/+12
Unindent, use correct type for idx (int rather than size_t) and make this mess a bit more pleasant on the eyes. ok jsing
2025-03-12x509_vpm: remove unnecessary NULL check before sk_pop_free()tb1-4/+2
ok jsing
2025-03-10ec.h: remove last SunPro pragmastb1-13/+1
With the removal of the EC_POINTs_* API, this header features no arrays anymore, so this noise can go away. ok miod
2025-03-09Disambiguate curve commentstb1-21/+21
There are three "X9.62 curve over a 239 bit prime field" and the Brainpool curves are a pair for each field size thanks to their characteristic twist. Just include the curve name for each of the curves. discussed with jsing
2025-03-09X509_NAME_print_ex: zap stray commatb1-2/+2
2025-03-09Give libtls the same bump as libcrypto and libssltb1-2/+2
2025-03-09Give libssl the same bump as libcryptotb1-1/+1
2025-03-09Bump libcrypto major after symbol removaltb1-1/+1
2025-03-09const correct tls_session_secret_cb_fn()tb4-8/+8
Various ports throw a warning since their tls_session_secret_cb's signature doesn't match what we expect. Aligns us with OpenSSL 1.1. This is only useful for RFC 4851 EAP-FAST implementations and surprisingly it's undocumented. ok jsing
2025-03-09Bump LibreSSL versiontb1-3/+3
ok jsing
2025-03-09Reinstate PKCS12_key_gen_uni()tb5-7/+10
Unfortunately, this is used in acsm-calibre-plugin, via oscrypto. Fixes https://github.com/Leseratte10/acsm-calibre-plugin/issues/112 ok jsing
2025-03-09Remove EC_POINTs_* APItb4-34/+3
And another one... Completely overengineered for the sake of academic credentials and only Ruby ever picked this garbage up. Fortunately, it's no longer used with LibreSSL since we defanged this in 2018. The latest version of ruby/openssl has completely removed this as part of their post 1.0.x cleanup. ok jsing
2025-03-09Remove Jprojective_coordinates APItb4-29/+3
There goes another implementation detail that should never have been leaked out of the library. ok jsing
2025-03-09Unexport EC_GROUP_*precompute_mult()tb4-25/+3
These have been noops for a while and as usual some Perl module was the only thing "using" it. ok jsing
2025-03-09Unexport EC_GROUP_copy()tb4-8/+4
Without EC_GROUP_new(), this API is useless. There's EC_GROUP_dup(). ok jsing
2025-03-09Unexport EC_METHOD and all API using ittb6-56/+10
This is an implementation detail and there is no reason to leak it from the library. This removes EC_GFp_{mont,simple}_method(), EC_GROUP_{method_of,new}(), EC_METHOD_get_field_type(), EC_POINT_method_of() from the public API. EC_GROUP_copy() is now quite useless, so it will go as well. ok jsing
2025-03-09Align CRYPTO_set_mem*_functions with OpenSSL 1.1tb4-20/+9
CRYPTO_set_mem_ex_functions() was renamed to CRYPTO_set_mem_functions(), replacing the latter while also correcting the arguments for the free pointer. The backstory is that a commit that was never compiled was fixed the wrong way an hour later (both committed without review, obviously), and here we are, still cleaning up the mess 23 years later. We carry patches in cjose and stunnel for this; dovecot and links+ have autoconf checks and will adapt. Oh, and then there's the mariadb configure time insanity passing wrong function pointers... ok jsing
2025-03-09const correct UI_OpenSSL()tb2-5/+5
ok jsing
2025-03-09Fix documented signature of UI_OpenSSL()tb1-3/+3
2025-03-09Fix documented signature of BN_MONT_CTX_copy()tb1-3/+3
2025-03-09const correct BN_MONT_CTX_copy()tb2-4/+4
ok jsing
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-03-28 16:12:56 +0000