| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
No change to generated assembly.
|
|
|
|
|
|
|
|
|
|
|
| |
instead of disk. OpenSSL didn't provide a built-in API from loading
certificates in a chroot'ed process that doesn't have direct access to
the files. X509_STORE_load_mem() provides a new backend that will be
used by libssl and libtls to implement such privsep-friendly
functionality.
Adopted for LibreSSL based on older code from relayd (by pyr@ and myself)
With feedback and OK bluhm@
|
|
|
|
|
|
|
|
|
|
|
| |
If X509_TRUST_add() or X509_PURPOSE_add() fail, they will leave the
object in an inconsistent state since the name is already freed.
This commit avoids changing the original name unless the *_add() call
will succeed.
Based on BoringSSL's commit: ab2815eaff6219ef57aedca2f7b1b72333c27fd0
ok miod@
|
|
|
|
| |
the function argument not being NULL
|
|
|
|
|
| |
intrinsic functions everywhere, and wrap these functions in an
#ifndef LIBRESSL_INTERNAL to make sure we don't bring their use back.
|
|
|
|
|
| |
if a NULL stack was passed as argument. Fix this by returning NULL early in
that case.
|
|
|
|
|
|
|
|
|
| |
X509_STORE_CTX_init(): do not free the X509_STORE_CTX * parameter upon
failure, for we did not allocate it and it might not come from the heap,
such as in check_crl_path() in this very same file where X509_STORE_CTX_init()
gets invoked with a stack address.
ok bcook@
|
|
|
|
|
| |
memcpy().
ok bcook@
|
|
|
|
|
| |
parameter, correctly set param->name to NULL after having freed it.
ok bcook@
|
|
|
|
| |
ok bcook@
|
|
|
|
|
|
| |
for it may be NULL. Do not leak memory upon error.
ok bcook@
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manual field fiddling to create an ASN1_INTEGER object, instead of using
M_ASN1_INTEGER_new() which will allocate sizeof(long) bytes.
That person had probably never looked into malloc(3) and never heard of
allocation size rounding.
Thus, replace the obfuscated code with M_ASN1_INTEGER_new() followed by
ASN1_INTEGER_set(), to achieve a similar result, without the need for
/* version == 0 */ comments.
ok bcook@
|
|
|
|
|
|
|
| |
X509_STORE_get1_certs(), X509_STORE_get1_crls(): check the result of
allocations.
ok tedu@
|
|
|
|
|
|
| |
the first EVP block.
ok tedu@
|
|
|
|
| |
ok tedu@
|
|
|
|
|
|
| |
strdup() to allocated directory list components.
ok jsing@
|
|
|
|
|
|
| |
Remove unnecessary NULL check.
ok miod@
|
|
|
|
|
| |
NULL before an intrinsic strdup.
ok miod@
|
|
|
|
|
|
|
|
| |
leaks.
From miod@
OK from miod@ and guenther@
|
| |
|
|
|
|
|
|
|
| |
instances. This one for OPENSSL_ALLOW_PROXY_CERTS gets turned off first,
especially since it had this special comment:
/* A hack to keep people who don't want to modify their software happy */
ok beck jsing
|
|
|
|
|
|
|
| |
Improves readability, keeps the code smaller so that it is warmer in your
cache.
review & ok deraadt@
|
|
|
|
|
| |
X509_STORE_CTX_free() accept NULL pointers as input without dereferencing them,
like all the other well-behaved *_CTX_free() functions do.
|
|
|
|
|
|
|
| |
expired or not valid yet, continue looking; only return an expired certificate
if no valid certificates have been found.
OpenSSL PR #3359 via OpenSSL trunk.
|
|
|
|
|
|
|
|
| |
Remove the openssl public includes from cryptlib.h and add a small number
of includes into the source files that actually need them. While here,
also sort/group/tidy the includes.
ok beck@ miod@
|
|
|
|
|
|
|
|
|
| |
an OPENSSL_NO_* define. This avoids relying on something else pulling it
in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is
never going to do anything, since OPENSSL_NO_XYZ will never defined, due
to the fact that opensslconf.h has not been included.
This also includes some miscellaneous sorting/tidying of headers.
|
|
|
|
|
|
| |
are needed in the source files that actually require them.
ok beck@ miod@
|
| |
|
|
|
|
|
|
| |
Also remove unused des_ver.h, which exports some of these strings, but is not installed.
ok miod@ tedu@
|
|
|
|
| |
ok logan@ beck@
|
|
|
|
|
|
|
| |
(Thanks to Brent Cook)
OK from tedu@
|
| |
|
|
|
|
| |
ok miod
|
|
|
|
|
| |
setuid applications from being fooled.
ok miod
|
| |
|
|
|
|
| |
add missing unlock in one case. ok lteo miod
|
| |
|
|
|
|
|
|
| |
OpenSSL 1.0.0.
ok miod@ (a little while back)
|
|
|
|
| |
ok miod
|
| |
|
|
|
|
|
|
|
|
|
| |
potential integer overflows easily changed into an allocation return
of NULL, with errno nicely set if need be. checks for an allocations
returning NULL are commonplace, or if the object is dereferenced
(quite normal) will result in a nice fault which can be detected &
repaired properly.
ok tedu
|
|
|
|
| |
ok to firebomb from tedu@
|
|
|
|
|
| |
that does not.
"fire bomb" tedu@
|
| |
|
|
|
|
|
|
|
| |
including it they get <openssl/opensslconf.h>. So instead of pulling in
<openssl/e_os2.h>, just pull in <openssl/opensslconf.h>.
"go ahead" miod@
|
|
|
|
|
|
|
|
| |
This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@
|
| |
|
| |
|
| |
|
| |
|