| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
|
|
| |
Moving forward, software should expect that LIBRESSL_VERSION_TEXT and
LIBRESSL_VERSION_NUMBER will increment for each LibreSSL-portable release.
ok deraadt@, beck@
|
|
|
|
|
| |
from OpenSSL (RT #3683)
ok doug@ jsing@
|
|
|
|
|
|
|
| |
its original state instead of blindly turning echo on.
problem reported on the openssl-dev list by William Freeman
ok miod@ beck@
|
|
|
|
|
|
|
|
|
|
|
| |
this would promote it to int for the shift, and then cast to unsigned long,
sign-extending it if sizeof(long) > sizeof(int).
This was not a problem because the computed value was explicitely range
checked afterwards, with an upper bound way smaller than 1U<<31, but it's
better practice to cast correctly.
ok beck@
|
|
|
|
| |
Coverity CID 78796; ok beck@
|
|
|
|
|
| |
applied to all code paths.
ok beck@ bcook@ doug@ guenther@
|
|
|
|
| |
we did not notice my fingers slipping. Noticed by bcook@
|
|
|
|
| |
ok beck@
|
|
|
|
|
|
|
|
| |
have seriously corrupted your memory; Coverity CID 21708 and 21721.
While there, plug a memory leak upon error in x509_name_canon().
ok bcook@ beck@
|
|
|
|
| |
ok miod@
|
|
|
|
| |
ok beck@
|
|
|
|
|
| |
Coverity CID 21739 and more.
ok bcook@
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
int_TS_RESP_verify_token(). Coverity CID 21710.
Looking further, int_TS_RESP_verify_token() will only initialize signer to
something non-NULL if TS_VFY_SIGNATURE is set in ctx->flags. But guess what?
TS_REQ_to_TS_VERIFY_CTX() in ts/ts_verify_ctx.c, which is the TS_VERIFY_CTX
constructor, explicitely clears this bit, with:
ret->flags = TS_VFY_ALL_IMPRINT & ~(TS_VFY_TSA_NAME | TS_VFY_SIGNATURE);
followed by more conditional flag clears.
Of course, nothing prevents the user to fiddle with ctx->flags afterwards. This
is exactly what ts.c in usr.bin/openssl does. This is gross, mistakes will
happen.
ok beck@
|
|
|
|
|
|
| |
seed_in == NULL case. Since this situation is an error anyway, bail out
early.
with and ok beck@
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
|
|
|
| |
bcook@ notes that this check really only impacted 64-bit Windows. Also,
changed the check to be unsigned for consistency.
ok bcook@
|
| |
|
|
|
|
|
|
| |
From OpenSSL.
ok miod@ (a while ago)
|
|
|
|
|
|
| |
From OpenSSL.
ok miod@ (a while ago).
|
|
|
|
|
|
|
|
| |
From OpenSSL.
Rides libcrypto bump.
ok miod@ (a while ago)
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
|
|
|
| |
Old gcc warns when parameters have the same names as functions. Noticed
by deraadt@.
ok deraadt@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok deraadt@ jsing@ miod@
|
|
|
|
|
| |
Noted by doug@ in an earlier revision of the dynamic engine removal patch, but
I had forgotten to include it in the latest version.
|
|
|
|
|
|
|
| |
We do not build, test or ship any dynamic engines, so we can remove the dynamic
engine loader as well. This leaves a stub initialization function in its place.
ok beck@, reyk@, miod@
|
|
|
|
|
|
| |
"O=Digital Signature Trust Co., CN=DST Root CA X3". This CA is cross signing
the issuing intermediates for letsencrypt.org so is expected to be important
for at least ports distfile fetching in the future. ok ajacoutot@ juanfra@
|
|
|
|
|
|
|
|
|
| |
jsg@ noticed that some of the lines in libssl and libcrypto are not
indented properly. At a quick glance, it looks like it has a different
control flow than it really does. I checked the history in our tree and
in OpenSSL to make sure these were simple mistakes.
ok miod@ jsing@
|
|
|
|
| |
This only provides the sysctl wrapper in glibc, which we do not use and is not available in other libc implementations for Linux. Thanks to ncopa from github.
|
|
|
|
|
|
|
|
|
|
| |
unknown hash function OID.
Diff based on OpenSSL.
Fixes CVE-2015-1792 (however, this code is not enabled/built in LibreSSL).
ok doug@ miod@
|
|
|
|
|
|
|
|
|
|
| |
length checks.
Diff based on changes in OpenSSL.
Fixes CVE-2015-1789.
ok doug@
|
|
|
|
|
|
|
|
|
|
|
| |
ECParameters structure that has a specially malformed binary polynomial
field.
Issue reported by Joseph Barr-Pixton and fix based on OpenSSL.
Fixes CVE-2015-1788.
ok doug@ miod@
|
|
|
|
|
|
|
| |
Since RAND_egd has been removed from LibreSSL, simplify porting software that
relies on it. See https://github.com/libressl-portable/openbsd/pull/34
from Bernard Spil, ok deraadt@
|
|
|
|
|
|
| |
starts helping with the pod2mdoc(1)-based conversion
of LibreSSL crypto manuals from perlpod(1) to mdoc(7).
Here comes the first file, slightly tweaked by me.
|
|
|
|
| |
ok deraadt@
|
|
|
|
| |
pointer for NULL the line above; ok doug@
|
| |
|
|
|
|
| |
ok doug@
|
| |
|
|
|
|
| |
ok doug millert
|
|
|
|
|
|
|
|
| |
After calling BN_CTX_start(), there must be a BN_CTX_end() before
returning. There were missing BN_CTX_end() calls in error paths. One diff
chunk was simply removing redundant code related to this.
ok deraadt@
|
|
|
|
| |
Include it if we have the sysctl syscall.
|
|
|
|
| |
From Michael Felt.
|
|
|
|
|
|
|
|
|
| |
Based on this upstream commit: bff9ce4db38b297c72a6d84617d71ae2934450f7
which didn't make it into a release until 1.0.2.
Thanks to william at 25thandclement dot com for reporting this!
ok deraadt@ jsing@ beck@
|
| |
|
|
|
|
|
|
|
|
| |
i2d_X509_PKEY is a "needs to implement" and d2i_X509_PKEY is broken.
Removed upstream in commit b1f3442857c1fd76e91941141bf671d19e90a79d.
ok deraadt@, jsing@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issetugid() API is supposed to make a strong promise where "0
means it is safe to look at the environment". Way back in the past
someone on the OpenSSL team responded to the environment access danger
by creating a wrapper called OPENSSL_issetugid, and went to use it a
number of places. However, by default on systems lacking true
issetugid(), OPENSSL_issetugid returns 0. 0 indicating safely. False
safety. Which means OPENSSL_issetugid() fails to make any sort of
promise about safety, in fact it is just the opposite.
Can you believe the OpenSSL team?
This nastiness was noticed over the years, however noone could gain traction
and get it fixed in OpenSSL. Also see a paragraph about this in
http://www.tedunangst.com/flak/post/worst-common-denominator-programming
ok jsing
|