| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
| |
EVP_AES_GCM_CTX, leaving the AES key untouched - clean the entire context,
rather than just part of it.
ok beck@ miod@
|
|
|
|
| |
ok miod@
|
| |
|
|
|
|
|
|
|
|
|
| |
manual page strictly. Return -2 if the strings are not strict numbers.
The numbers remain in the range of "int". Range checking for these parameters
is done later in the pkey_*_ctl() functions, or sometimes in functions much
further downstream... but not always!!!
ok millert miod mikeb
|
| |
|
|
|
|
|
|
| |
OpenSSL 1.0.0.
ok miod@ (a little while back)
|
| |
|
|
|
|
| |
ok beck
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
collateral damage.
The syncronous nature of this mechanism has hampered performance for
symmetric crypto relative to brute-force cpu. The assymetric crypto
support never really materialized in drivers.
So abandon the complexity.
ok tedu beck mikeb
some disagrement from djm but if he wants to test /dev/crypto ciphers
he should do it without this this gigantic API in the way
|
| |
|
| |
|
|
|
|
|
|
| |
protect from future field reordering/removal.
No difference in generated assembly.
|
| |
|
| |
|
|
|
|
| |
discussed with tedu, ok jsing
|
|
|
|
|
|
| |
and others to the regress framework. These remaining ones just
muddle us up when re-reading code repeatedly.
ok jsing
|
|
|
|
| |
ok miod
|
|
|
|
|
| |
hackathon, just saying 'ass ember' was enough to start giggles.
Unfortunately far more offensive stuff remains in here...
|
|
|
|
|
|
| |
(From Frantisek Boranek)
OK from miod@
|
|
|
|
|
|
| |
(From Martin Brejcha)
OK from tedu@, miod@ and deraadt@
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the intel RDRAND instruction. Consensus was RDRAND should probably
only be used as an additional source of entropy in a mixer.
Guess which library bends over backwards to provide easy access to
RDRAND? Yep. Guess which applications are using this support? Not
even one... but still, this is being placed as a trap for someone.
Send this support straight to the abyss.
ok kettenis
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this nasty function.
This gets rid of the nasty tmp variables used to hold temporary strings
and the DECIMAL_SIZE hack. it gets rid of the rather pointless null checks
for buf (since the original code dereferences it before checking). It also
gets rid of the insane possibility this could return -1 when stuff is
using the return values to compute lengths All the failure cases now
return 0 and an empty string like the first error case in the original
code.
ok miod@ tedu@
|
|
|
|
| |
ok guenther
|
|
|
|
|
| |
since all other characters are mapped through transparently.
ok jsing
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
memset(a->data, 0, (unsigned int)a->max);
but the decl is:
size_t max;
size_t could be larger than int, especially in some of the systems OpenSSL
purports to support.
How do _intentionally truncating_ casts like enter into a codebase?
Lack of understanding of C, at a minimum. Generally the objects are
small, but this code is _intentionally unready_ for large objects.
ok miod
|
|
|
|
|
|
| |
in this file directly use __attribute__.
ok deraadt@
|
|
|
|
| |
ok deraadt@
|
|
|
|
|
|
|
| |
since the calculated value is not actually used in the uninitialised case.
Change the code so that we only do the calculation if we actually need it.
Issue detected by clang and reported by both brad@ and Brent Cook.
|
| |
|
|
|
|
| |
from Brent Cook
|
| |
|
|
|
|
|
|
|
| |
rather than only in the config file, to trip people up later.
Found, and fix pleaded for by <spider@skuggor.se> who apparently
spent hours chasing it down.
ok miod@
|
|
|
|
| |
behaviour of this code, to prevent people from blindly changing it.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
But do use the abort(), which we are hoping all future vendors will move
towards the more modern "do not flush streams"; hint hint, if you didn't
do that already, there are grave risks because much software brings risk
without that behaviour. We didn't cause the change.. POSIX did...
ok beck
|
| |
|
| |
|
|
|
|
| |
gets rid of the second last use of the awful DECIMAL_SIZE.
|
| |
|
|
|
|
| |
ok tedu guenther
|
| |
|
| |
|
|
|
|
|
| |
that is OBJ_obj2txt() can return a larger value..
ok tedu@
|
| |
|
|
|
|
|
|
|
| |
being relaced by reallocarray(). you will have to look at the diff.
there can be no explanations for the extra casts. as beck says,
"Don't go towards the light theo!"
ok beck tedu
|
|
|
|
| |
in the "size_t nmemb, size_t size"
|
|
|
|
|
|
|
|
|
| |
potential integer overflows easily changed into an allocation return
of NULL, with errno nicely set if need be. checks for an allocations
returning NULL are commonplace, or if the object is dereferenced
(quite normal) will result in a nice fault which can be detected &
repaired properly.
ok tedu
|
|
|
|
| |
ok to firebomb from tedu@
|