| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
This patch is originally from master branch of OpenSSL.
- 2198b3a crypto/evp: harden AEAD ciphers.
- 8e20499 crypto/evp: harden RC4_MD5 cipher.
ok tom@
|
|
|
|
| |
jsing@ confirmed that these are public and worth documenting.
|
| |
|
|
|
|
| |
jsing@ confirmed that these macros are public and worth documenting.
|
|
|
|
|
|
|
| |
and BN_RECP_CTX_init(3). They are not only deprecated but so
dangerous that they are almost unusable. I found these scary
traps while reading the code in order to document BN_set_flags(3).
While here, delete ERR_get_error(3) from SEE ALSO.
|
|
|
|
|
|
| |
as was done earlier in libssl. Thanks inoguchi@ for noticing
libssl had more reacharounds into this.
ok jsing@ inoguchi@
|
|
|
|
|
| |
using it anymore
ok jsing@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
jsing@ confirmed that this function is public and worth documenting.
This page needs much more work, it is outrageously incomplete and
unclear. For example, it remains unexplained what error strings
are, what "registering" means and what the benefit for the application
is, what happens if it is not done, or what happens if an error
occurs after calling ERR_free_strings(3). I tried to read the code,
but it is so contorted that i postponed that work. For example,
it looks like there are hooks for applications to replace the
functions used for registering strings by other, application-supplied
functions, and, of course, there are many levels of macro and
function wrappers.
For now, i only documented the most obvious BUGS.
|
|
|
|
| |
jsing@ confirmed that it is a public function worth documenting
|
|
|
|
|
|
|
|
|
|
|
| |
by Alejandro Cabrera <aldaya@gmail.com> to avoid the possibility of a
sidechannel timing attack during RSA private key generation.
Modify BN_gcd to become not visible under LIBRESSL_INTERNAL and force
the use of the _ct or _nonct versions of the function only within
the library.
ok jsing@
|
|
|
|
| |
ok guenther@
|
|
|
|
| |
ok jsing@
|
|
|
|
| |
ok jsing@
|
|
|
|
|
|
|
|
|
|
|
|
| |
matter for constant time, and make the public interface only used
external to the library.
This moves us to a model where the important things are constant time
versions unless you ask for them not to be, rather than the opposite.
I'll continue with this method by method.
Add regress tests for same.
ok jsing@
|
|
|
|
| |
LIBRESSL_INTERNAL.
|
|
|
|
| |
No change to generated assembly excluding line numbers.
|
|
|
|
|
| |
with some style cleanup after. no binary change
ok jsing@
|
|
|
|
| |
No change to generated assembly excluding line numbers.
|
|
|
|
| |
ok jsing@
|
|
|
|
|
|
| |
with the caveat that we force V_OK when a user provided callback has
us returning success.
ok inoguchi@ jsing@
|
|
|
|
|
| |
towards cleaning up the V_OK stuff.
ok kinichiro@
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
(slightly) more readable.
|
| |
|
|
|
|
|
|
|
| |
returning ok == 1, with ctx->error not being X509_V_OK. Hopefully we can
restore this behaviour once these are ironed out.
Discussed with beck@
|
| |
|
|
|
|
|
|
|
|
| |
fixing a dead link reported by jmc@.
Only about half of X509_VERIFY_PARAM is documented so far,
and the extensible lookup table feels like one of the more
arcane features and probably not the next thing to document.
|
|
|
|
|
|
|
| |
jmc@ reported that X509_LOOKUP_hash_dir(3) references it.
Even though OpenSSL does not document it, given that it is used for
file names that users have to create, it is sufficiently exposed
to users to be worth documenting.
|
|
|
|
|
|
|
|
|
|
|
| |
Not documented by OpenSSL, but listed in <openssl/x509_vfy.h>
and referenced from X509_LOOKUP_hash_dir(3), and clearly more
important than the latter. Fixes three dead links reported by jmc@.
Most of the information from SSL_CTX_load_verify_locations(3) should
probably be moved here, but not all, since the SSL page also talks
about SSL servers and clients and the like. As i'm not completely
sure regarding the boundaries, i'm leaving that as it is for now.
|
|
|
|
|
|
|
| |
and X509_STORE_add_lookup(3) reported by jmc@.
Even though these functions are public, they seem more useful internally
than for application programs, so now is not the time to document them.
|
|
|
|
|
|
|
| |
function that had the the sole purpose of discouraging its use.
Not talking about it at all discourages using it even more.
Dangling cross reference reported by jmc@.
|
|
|
|
| |
and sprinkle cross references instead; more work is obviously needed here
|
|
|
|
|
|
| |
The safestack stuff is the most ill-designed user interface i have
seen so far in OpenSSL. It looks positively undocumentable.
At least i'm not trying to document it right now.
|
|
|
|
|
|
|
|
|
| |
that wasn't accompanied by any related information. Reported by jmc@.
There are a dozen functions handling X509_PURPOSE objects, all
undocumented, a host of defines, and it seems that a callback is
required. So this seems complicated, i doubt that is much used
in practice, and i'm not diving into it at this point in time.
|
|
|
|
|
|
|
|
|
| |
and refer readers to the header file instead.
I'm not convinced customized prompting is such a bright idea, it
feels somewhat like overengineering, so i'm not documenting it right
now. People who really feel compelled to roll their own prompting
can go read the source code.
|
|
|
|
|
|
|
|
|
| |
and just use .Fn for now.
Not counting constructors, destructors, decoders, encoders, and
debuggers, six out of 24 public functions operating on PKCS7 objects
are currently documented. I'm not documenting the remaining 18 ones
at this point in time.
|
|
|
|
|
|
|
|
|
| |
and just use .Fn for now.
There are about two dozen interfaces dealing with PKCS7_SIGNER_INFO
objects and none but the constructor, destructor, decoder, and encoder
are documented so far. It makes no sense to document one random one,
and i'm not going to document all of PKCS7_SIGNER_INFO right now.
|
|
|
|
|
|
| |
I'm not convinced documenting EVP_MD_CTX_set_flags(3) would be wise.
Instead, refer people to the header file to make it more obvious
that they are tinkering with internals when using such flags.
|
|
|
|
|
|
|
|
|
| |
resolving a dangling cross reference reported by jmc@.
Sort NAME and SYNOPSIS to agree with .Dt and DESCRIPTION.
Unify parameter names.
Delete a sentence about an implementation detail that is no longer true.
Mention the length limitation of the *_string() variants.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reported by jmc@. Documenting that function would be a bad idea. All
other flags are used internally and should better not be tampered with.
It looks like an internal function that was made public by mistake,
then abused for an unrelated user interface purpose: a classic case
of botched user interface design.
Instead, only show how to use this function for this one specific purpose.
While here, delete a sentence from the DESCRIPTION that merely
duplicated content from the BUGS section.
|
|
|
|
|
| |
by referencing a non-existent manual page.
Broken .Xr reported by jmc@.
|
| |
|
|
|
|
|
| |
Documenting these trivial PKCS7_type_is_*() macros
does not seem useful, at least not right now.
|
|
|
|
| |
and add some missing escaping of backslashes while here
|
| |
|
|
|
|
| |
and in OpenSSL doc/man3/d2i_X509.pod (with wrong prototype).
|
|
|
|
|
|
| |
All 36 functions listed in <openssl/asn1.h>
and in OpenSSL doc/man3/d2i_X509.pod,
six of them with wrong prototypes.
|