| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
| |
OpenSSL stopped building it last year and removed it this year.
Based on OpenSSL commit c436e05bdc7f49985a750df64122c960240b3ae1.
Also cranked major version in libcrypto, libssl and libtls.
"fine with me" bcook@ miod@
|
|
|
|
|
| |
not 16-bit MS-DOS anymore.
ok bcook@ tedu@
|
|
|
|
| |
ok bcook@ doug@
|
|
|
|
|
| |
type.
ok guenther@ doug@
|
|
|
|
|
| |
fails, check its return value and correctly mop up after ourselves.
ok beck@ doug@
|
|
|
|
| |
ok bcook@ doug@
|
|
|
|
|
|
|
|
|
| |
raw byte sequences. The toolchains have had some time to update and assemble
the instructions correctly (except for p{ins,ext}rd which are not supported
yet by as(1) under OpenBSD, but will be fixed shortly).
Inspired by a discussion between tedu@ and John-Mark Gurney.
Verified to still work on Mac OS X and average Linux distros by bcook@
|
|
|
|
| |
same four bytes, unobfuscated.
|
|
|
|
|
|
|
| |
The current version is not safe with stack variables because it may
return prematurely with a partially constructed object on error.
ok miod@ a while back
|
|
|
|
|
|
|
| |
It's a little convoluted due to gotos, but at that point, pci is always
NULL. Spotted by Coverity 21702.
ok miod@ beck@ bcook@
|
|
|
|
| |
ok doug@
|
|
|
|
| |
ok doug@, beck@
|
|
|
|
| |
ok doug@
|
|
|
|
| |
ok doug@
|
|
|
|
| |
ok bcook@ doug@
|
|
|
|
|
|
|
|
|
|
| |
lease worst alternative and do nothing rather than dereference NULL, but having
a function with fundamentally broken API to simply make a list of strings, sort them,
and call a function with each string as an argument is really quite silly....
and of course it was exposed API that the ecosystem uses that we can't delete.. yet.
ok miod@ doug@
|
|
|
|
|
| |
memory. Coverity CID 24810, 24846.
ok bcook@ doug@
|
|
|
|
|
|
| |
light that the child counting was broken in the original code.
this is still fugly, but this preserves all the existing goo.
ok doug@
|
|
|
|
| |
patch from Theo Buehler <theo at math dot ethz dot ch>
|
| |
|
|
|
|
|
|
|
| |
Moving forward, software should expect that LIBRESSL_VERSION_TEXT and
LIBRESSL_VERSION_NUMBER will increment for each LibreSSL-portable release.
ok deraadt@, beck@
|
|
|
|
|
| |
from OpenSSL (RT #3683)
ok doug@ jsing@
|
|
|
|
|
|
|
| |
its original state instead of blindly turning echo on.
problem reported on the openssl-dev list by William Freeman
ok miod@ beck@
|
|
|
|
|
|
|
|
|
|
|
| |
this would promote it to int for the shift, and then cast to unsigned long,
sign-extending it if sizeof(long) > sizeof(int).
This was not a problem because the computed value was explicitely range
checked afterwards, with an upper bound way smaller than 1U<<31, but it's
better practice to cast correctly.
ok beck@
|
|
|
|
| |
Coverity CID 78796; ok beck@
|
|
|
|
|
| |
applied to all code paths.
ok beck@ bcook@ doug@ guenther@
|
|
|
|
| |
we did not notice my fingers slipping. Noticed by bcook@
|
|
|
|
| |
ok beck@
|
|
|
|
|
|
|
|
| |
have seriously corrupted your memory; Coverity CID 21708 and 21721.
While there, plug a memory leak upon error in x509_name_canon().
ok bcook@ beck@
|
|
|
|
| |
ok miod@
|
|
|
|
| |
ok beck@
|
|
|
|
|
| |
Coverity CID 21739 and more.
ok bcook@
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
int_TS_RESP_verify_token(). Coverity CID 21710.
Looking further, int_TS_RESP_verify_token() will only initialize signer to
something non-NULL if TS_VFY_SIGNATURE is set in ctx->flags. But guess what?
TS_REQ_to_TS_VERIFY_CTX() in ts/ts_verify_ctx.c, which is the TS_VERIFY_CTX
constructor, explicitely clears this bit, with:
ret->flags = TS_VFY_ALL_IMPRINT & ~(TS_VFY_TSA_NAME | TS_VFY_SIGNATURE);
followed by more conditional flag clears.
Of course, nothing prevents the user to fiddle with ctx->flags afterwards. This
is exactly what ts.c in usr.bin/openssl does. This is gross, mistakes will
happen.
ok beck@
|
|
|
|
|
|
| |
seed_in == NULL case. Since this situation is an error anyway, bail out
early.
with and ok beck@
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
|
|
|
| |
bcook@ notes that this check really only impacted 64-bit Windows. Also,
changed the check to be unsigned for consistency.
ok bcook@
|
| |
|
|
|
|
|
|
| |
From OpenSSL.
ok miod@ (a while ago)
|
|
|
|
|
|
| |
From OpenSSL.
ok miod@ (a while ago).
|
|
|
|
|
|
|
|
| |
From OpenSSL.
Rides libcrypto bump.
ok miod@ (a while ago)
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
|
|
|
| |
Old gcc warns when parameters have the same names as functions. Noticed
by deraadt@.
ok deraadt@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok deraadt@ jsing@ miod@
|
|
|
|
|
| |
Noted by doug@ in an earlier revision of the dynamic engine removal patch, but
I had forgotten to include it in the latest version.
|
|
|
|
|
|
|
| |
We do not build, test or ship any dynamic engines, so we can remove the dynamic
engine loader as well. This leaves a stub initialization function in its place.
ok beck@, reyk@, miod@
|
|
|
|
|
|
| |
"O=Digital Signature Trust Co., CN=DST Root CA X3". This CA is cross signing
the issuing intermediates for letsencrypt.org so is expected to be important
for at least ports distfile fetching in the future. ok ajacoutot@ juanfra@
|
|
|
|
|
|
|
|
|
| |
jsg@ noticed that some of the lines in libssl and libcrypto are not
indented properly. At a quick glance, it looks like it has a different
control flow than it really does. I checked the history in our tree and
in OpenSSL to make sure these were simple mistakes.
ok miod@ jsing@
|