| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
Remove unnecessary NULL check.
ok miod@
|
|
|
|
|
|
|
| |
up and return failure, be sure the cleanup work does NOT free objects which
are still being referenced by other objects.
ok guenther@
|
|
|
|
|
|
|
| |
within libcrypto are safe, but until we can change this function prototype to
use size_t instead of int, better be safe than sorry.
tweaks and ok guenther@
|
|
|
|
|
|
| |
value is happily dereferenced without checking it for being non-NULL).
ok beck@
|
|
|
|
|
|
|
| |
EVP_CTRL_RAND_KEY method handlers, rather than generating a random odd key and
not even checking it against the weak keys list.
ok beck@
|
|
|
|
|
|
|
|
|
|
|
| |
it is not one of the weak and semi-weak keys.
Even though the probability of generating a weak key with incorrect parity is
abysmally small, there is no reason to be correct (although, if you're in a
need for fresh DES keys nowadays, you should seriously consider switching to
a stronger symmetric cipher algorithm).
ok beck@
|
|
|
|
|
| |
NULL before an intrinsic strdup.
ok miod@
|
| |
|
| |
|
|
|
|
|
|
|
| |
Also, zero the SHA256 context.
suggested by "eric" in a comment on an opensslrampage.org post
ok miod@ deraadt@
|
| |
|
|
|
|
|
|
|
|
| |
Move <sys/mman.h> and raise(SIGKILL) calls to OS-specific headers.
On OpenBSD, move thread_private.h as well to arc4random.h.
On Windows, use TerminateProcess on getentropy failure.
ok deraadt@
|
|
|
|
|
| |
It may make sense to later replace this with a Critical Section later.
ok guenther@
|
|
|
|
|
|
| |
it shows up in libraries. Even the system call is probably not finalized.
Bit dissapointed it has turned out to be a descriptor-less read() with
EINVAL and EINTR error conditions, but we can work with it.
|
|
|
|
| |
ok bcook@
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
into one if a system has an awesome getentropy(). In that case it
is valid to totally throw away the rsx state in the child. If the
getentropy() is not very good and has a lazy reseed operation, this
combining is a bad idea, and the reseed should probably continue to
use the "something old, something new" mix. _rs_allocate() can
accomodate either method, but not on the fly.
ok matthew
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Use "len" parameter instead of sizeof(*rs).
2. Simplify the atfork handler to be strictly async signal safe by
simply writing to a global volatile sig_atomic_t object, and then
checking for this in _rs_forkdetect(). (Idea from discussions with
Szabolcs Nagy and Rich Felker.)
3. Use memset(rs, 0, sizeof(*rs)) to match OpenBSD's MAP_INHERIT_ZERO
fork semantics to avoid any skew in behavior across platforms.
ok deraadt
|
|
|
|
|
| |
making it much easier for libressl -portable to fill in the gaps.
ok bcook beck
|
| |
|
|
|
|
|
|
|
|
| |
leaks.
From miod@
OK from miod@ and guenther@
|
|
|
|
|
|
|
| |
Linux (such as Ubuntu 12.04LTS) that don't have it yet. Seems the AT_XXX
defines are pulled in by <link.h> now.
ok beck@
|
|
|
|
| |
locked throughout.
|
|
|
|
| |
ok tedu
|
|
|
|
|
|
| |
intrinsics. This is the easy ones, a few left to check one at
a time.
ok miod@ deraadt@
|
|
|
|
| |
OK from beck@ and miod@
|
| |
|
|
|
|
| |
ok jsing@
|
|
|
|
|
|
|
| |
into the hash; hoping the system has some ASLR or PIE. This replaces and
substantially improves upon &main which proved problematic with some picky
linkers.
Work with kettenis, testing by beck
|
|
|
|
| |
ok beck
|
|
|
|
| |
EVP_MD_CTX_cleanup() to be called.
|
| |
|
|
|
|
|
|
| |
appropriate function. Checking for privkey != NULL is not enough since
privkey points to a member of ndsa if ndsa != NULL.
dsa_priv_encode(): possible double free in error path.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to reinitialize all of it, especially if it is used with the same MD algorithm.
However, when the MD algorithm changes, it needs to perform more cleanups.
Make that code more closer to what EVP_MD_CTX_cleanup() does by:
- only freeing md_data if EVP_MD_CTX_FLAG_REUSE is not set
- performing an explicit_bzero of md_data before freeing it
- making sure we call EVP_PKEY_CTX_free on the pctx if the allocation for the
new md_data fails.
ok tedu@
|
| |
|
|
|
|
|
|
|
| |
while we can take it out in portable at compile time, it is still a problem
when we install this header file on a system that doesn't support __bounded__
if this is unguarded.
ok miod@ bcook@
|
| |
|
|
|
|
|
|
| |
distractions to people testing and seeing link errors in some setups.
This will come back in another form
ok deraadt@
|
| |
|
| |
|
|
|
|
|
|
|
| |
``The probability that a randomly generated key is weak is -1/2^52,
so it is not really worth checking for them.''
This kind of naively optimistic attitude is not compatible with security.
|
| |
|
|
|
|
| |
OK: beck@
|
|
|
|
|
|
| |
add a function to use function pointers that does not take sizeof(fptr).
OK beck@
|
|
|
|
|
|
| |
build on pre-EVP_CIPH_FLAG_DEFAULT_ASN1 codebases.
ok jsing@
|