| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
ok miod@
|
|
|
|
| |
ok beck@
|
|
|
|
|
| |
Coverity CID 21739 and more.
ok bcook@
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
int_TS_RESP_verify_token(). Coverity CID 21710.
Looking further, int_TS_RESP_verify_token() will only initialize signer to
something non-NULL if TS_VFY_SIGNATURE is set in ctx->flags. But guess what?
TS_REQ_to_TS_VERIFY_CTX() in ts/ts_verify_ctx.c, which is the TS_VERIFY_CTX
constructor, explicitely clears this bit, with:
ret->flags = TS_VFY_ALL_IMPRINT & ~(TS_VFY_TSA_NAME | TS_VFY_SIGNATURE);
followed by more conditional flag clears.
Of course, nothing prevents the user to fiddle with ctx->flags afterwards. This
is exactly what ts.c in usr.bin/openssl does. This is gross, mistakes will
happen.
ok beck@
|
|
|
|
|
|
| |
seed_in == NULL case. Since this situation is an error anyway, bail out
early.
with and ok beck@
|
|
|
|
|
|
|
|
| |
Unlike the other conversions, this only partially converts the function
for now. This is the second to last function which still uses the n2l3
macro. That macro is deprecated since we're using CBS.
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
|
|
|
| |
Link in the new 'unit' regress and expand the invalid tests to include
some that would fail before the CBS conversion.
input + ok miod@ jsing@
|
|
|
|
|
|
|
| |
bcook@ notes that this check really only impacted 64-bit Windows. Also,
changed the check to be unsigned for consistency.
ok bcook@
|
| |
|
|
|
|
|
|
| |
spelt malloc+memcpy, which is what is used in all except two places.
ok deraadt@ doug@
|
|
|
|
|
|
|
| |
Previously, CBS_dup() had its own offset. However, it is more consistent
to copy everything.
ok miod@ jsing@
|
|
|
|
| |
From BoringSSL commit 3fa65f0f05f67615d9daf48940e07f84d094ac6e.
|
|
|
|
| |
tweak + ok miod@ jsing@
|
|
|
|
| |
tweak + ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
|
|
| |
From OpenSSL.
ok miod@ (a while ago)
|
|
|
|
|
|
| |
From OpenSSL.
ok miod@ (a while ago).
|
|
|
|
|
|
|
|
| |
From OpenSSL.
Rides libcrypto bump.
ok miod@ (a while ago)
|
|
|
|
| |
ok deraadt@ doug@ millert@ miod@ sthen@
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
| |
ok doug@ deraadt@
|
|
|
|
| |
ok miod@, tweak + ok jsing@
|
|
|
|
|
|
| |
Suggested by jsing@.
ok jsing@ miod@
|
|
|
|
|
|
|
| |
Old gcc warns when parameters have the same names as functions. Noticed
by deraadt@.
ok deraadt@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok deraadt@ jsing@ miod@
|
|
|
|
|
| |
Noted by doug@ in an earlier revision of the dynamic engine removal patch, but
I had forgotten to include it in the latest version.
|
|
|
|
|
|
|
| |
We do not build, test or ship any dynamic engines, so we can remove the dynamic
engine loader as well. This leaves a stub initialization function in its place.
ok beck@, reyk@, miod@
|
|
|
|
| |
tweak + ok miod@ jsing@
|
|
|
|
|
|
|
| |
This is useful for when you need to check the data ahead and then continue
on from the same spot.
input + ok jsing@ miod@
|
|
|
|
|
|
|
|
|
| |
While the previous types were correct, they can silently accept bad data
via truncation or signed conversion. We now take size_t as input for
CBB_add_u*() and do a range check.
discussed with deraadt@
input + ok jsing@ miod@
|
|
|
|
|
|
|
|
|
| |
Another relic due to the old US crypto policy.
From OpenSSL commit 63eab8a620944a990ab3985620966ccd9f48d681 and
95275599399e277e71d064790a1f828a99fc661a.
ok jsing@ miod@
|
|
|
|
|
|
|
|
| |
DTLS currently doesn't check whether a client cert is expected. This
change makes the logic in dtls1_accept() match that from ssl3_accept().
From OpenSSL commit c8d710dc5f83d69d802f941a4cc5895eb5fe3d65
input + ok jsing@ miod@
|
| |
|
| |
|
| |
|
|
|
|
| |
ok miod@, tweak + ok jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|
|
|
|
| |
ok miod@ jsing@
|