Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | define OPENSSL_NO_DTLS1_1 since we no longer have that either. | beck | 2023-07-06 | 1 | -2/+5 | |
| | | | | ok tb@ | |||||
* | Define the 'standard' OPENSSL_NO_BLAHBLAH's for no tls 1.0 or 1.1 | beck | 2023-07-06 | 1 | -3/+4 | |
| | | | | | | | | | | We have no tls 1.0 or 1.1 or methods for them. These "in theory" will make things that check the openssl #ifdef soup for all the floating eyeballs make the correct decisions, or if they do not they at least can not blame us. ok tb@ | |||||
* | Hide symbols in asn1 and bio | beck | 2023-07-05 | 80 | -80/+1511 | |
| | | | | ok jsing@ | |||||
* | upstream hidden file #include_next workaround for MS C compilers | bcook | 2023-07-05 | 10 | -10/+50 | |
| | | | | ok beck@, tb@ | |||||
* | don't return in a void function | bcook | 2023-07-05 | 1 | -2/+2 | |
| | | | | ok tb@ | |||||
* | Merge bio.h patch from libressl-portable | tb | 2023-07-05 | 1 | -1/+15 | |
| | | | | ok beck@ | |||||
* | whitespace | tb | 2023-07-05 | 1 | -4/+4 | |
| | ||||||
* | Correct formatting | beck | 2023-07-05 | 1 | -17/+9 | |
| | | | | ok jsing@ | |||||
* | Mop up last uses of ECDHerror() and ECDSAerror() | tb | 2023-07-05 | 4 | -25/+33 | |
| | | | | ok jsing | |||||
* | Hide symbols in chacha | beck | 2023-07-05 | 3 | -1/+43 | |
| | | | | ok jsing@ | |||||
* | One more ECDSAerror goes. | tb | 2023-07-05 | 1 | -2/+2 | |
| | ||||||
* | ECDHerror() and ECDSAerror will go away | tb | 2023-07-05 | 2 | -45/+45 | |
| | | | | | | Move some trivial ones to ECerror(). discussed with jsing | |||||
* | Adjust the public declaration of OpenSSLDie to use a portable | bcook | 2023-07-05 | 1 | -2/+10 | |
| | | | | | | method of indicating that the function does not return. ok tb@ | |||||
* | Drop an incorrect part from a comment | tb | 2023-07-05 | 1 | -2/+2 | |
| | ||||||
* | Missing . in comment | tb | 2023-07-05 | 1 | -2/+2 | |
| | ||||||
* | Fix #includes | tb | 2023-07-05 | 1 | -2/+6 | |
| | ||||||
* | Remove local prototypes for public API (?!) | tb | 2023-07-05 | 1 | -6/+1 | |
| | ||||||
* | Improve BN_bn2bin() error check for readability | tb | 2023-07-05 | 1 | -2/+2 | |
| | ||||||
* | Merge ECDH code that will stay into ecdh.c | tb | 2023-07-05 | 3 | -125/+65 | |
| | ||||||
* | Move ECDSA_size() to a more sensible place in this file | tb | 2023-07-05 | 1 | -28/+28 | |
| | ||||||
* | Merge ECDSA code that will stay into ecdsa.c | tb | 2023-07-05 | 3 | -160/+97 | |
| | | | | discussed with jsing | |||||
* | Rename ecs_local.h into ecdsa_local.h | tb | 2023-07-05 | 7 | -13/+13 | |
| | ||||||
* | Make variables in prototypes match function declarations | tb | 2023-07-05 | 1 | -6/+6 | |
| | ||||||
* | Drop useless ossl_ prefixes | tb | 2023-07-05 | 8 | -40/+52 | |
| | | | | discussed with jsing | |||||
* | Avoid outputting invalid signatures | tb | 2023-07-04 | 1 | -1/+11 | |
| | | | | | | | | | | | | The caller can provide an r which will be added to the ECDSA_SIG unchecked. This can happen via ECDSA_{,do_}sign_ex() or ECDSA_sign_setup() or else via a custom sign_sig() handler. Therefore add a check that it is in the bounds required. Since k was long thrown away, there's no way to check kinv, so it needs to be trusted. Misdesigned APIs that will output garbage everywhere... ok jsing | |||||
* | Clean up ECDSA verification | tb | 2023-07-04 | 1 | -14/+29 | |
| | | | | | | | | Use variable names that correspond more closely to the standard. Use an additional variable for s^-1 for readability. Annotate the code with the corresponding steps from FIPS 186-5. ok jsing | |||||
* | ECDSA signing: annotate code with steps corresponding to FIPS 185-6. | tb | 2023-07-04 | 1 | -3/+25 | |
| | | | | ok jsing | |||||
* | Extract private key and group order in s computation | tb | 2023-07-04 | 1 | -19/+18 | |
| | | | | | | | This pushes a few variables no longer needed in ossl_ecdsa_sign_sig() into ecdsa_compute_s() separating API logic and pure computation a bit more. ok beck | |||||
* | Use key for the EC_KEY everywhere | tb | 2023-07-04 | 1 | -39/+38 | |
| | ||||||
* | Some more consistency in variable names | tb | 2023-07-04 | 1 | -15/+15 | |
| | ||||||
* | Normalize ECDSA_SIG to be sig everywhere | tb | 2023-07-04 | 1 | -11/+11 | |
| | ||||||
* | Normalize on digest and digest_len rather than dgst dlen dgstlen, etc. | tb | 2023-07-04 | 1 | -28/+34 | |
| | ||||||
* | Rework ecdsa_prepare_digest() | tb | 2023-07-04 | 1 | -35/+35 | |
| | | | | | | | | Make it take an EC_KEY instead of a group order in preparation for further cleanup. Rename m into e to match the standard better. Also buy some vowels for jsing. ok beck jsing | |||||
* | Factor the computation of ECDSA s into a function | tb | 2023-07-04 | 1 | -69/+88 | |
| | | | | | | | | ossl_ecdsa_sign_sig() is already complicated enough. The math bit is entirely self contained and does not need to obfuscate control flow and logic. with feedback from and ok jsing | |||||
* | sign_sig: drop ckinv | tb | 2023-07-03 | 1 | -5/+7 | |
| | | | | | | | | The only reason ckinv exists is to be able to avoid a copy. This copy leaks some timing info, that will be mitigated in a subsequent step. It is an unused or at least uncommonly used codepath. ok jsing | |||||
* | Rework the logic in ECDSA sign_sig() | tb | 2023-07-03 | 1 | -24/+30 | |
| | | | | | | | | | | | If the caller supplied both kinv and r, we don't loop but rather throw an undocumented error code that no one uses, which is intended to tell the caller to run ECDSA_sign_setup() and try again. Use a boolean that indicates this situation so that the logic becomes a bit more transparent. ok jsing | |||||
* | Delete some more references to dead policy code. | tobhe | 2023-07-03 | 1 | -12/+1 | |
| | | | | | | Fixes -DNAMESPACE ok tb@ | |||||
* | sign_sig: test on assignment | tb | 2023-07-03 | 1 | -5/+6 | |
| | ||||||
* | sign_setup: split another check into two | tb | 2023-07-03 | 1 | -2/+6 | |
| | ||||||
* | typo | tobhe | 2023-07-03 | 1 | -1/+1 | |
| | ||||||
* | Split range checks for ECDSA r and ECDSA s | tb | 2023-07-03 | 1 | -3/+8 | |
| | | | | requested by jsing | |||||
* | Switch a couple of test from ucmp to cmp | tb | 2023-07-03 | 1 | -4/+4 | |
| | | | | | | | | This is confusing, as both sides involved should be unsigned. The ec code is undecided on whether the group order can be negative. It should never be, so lets see what happen with this slightly stricter check. discussed with jsing | |||||
* | ossl_ecdsa_verify_sig(): simplify range checks | tb | 2023-07-03 | 1 | -6/+4 | |
| | | | | | | | The checks whether r and s lie in the interval [1, order) were a bit uglier than necessary. Clean this up. ok beck jsing | |||||
* | List variables in a somewhat more sensible order | tb | 2023-07-03 | 1 | -4/+4 | |
| | ||||||
* | In ossl_ecdsa_verify_sig() use BN_CTX more idiomatically | tb | 2023-07-03 | 1 | -8/+10 | |
| | | | | ok beck jsing | |||||
* | Split a bunch of unrelated checks | tb | 2023-07-03 | 1 | -3/+10 | |
| | | | | ok beck jsing | |||||
* | Make ossl_ecdsa_verify_sig() single exit | tb | 2023-07-03 | 1 | -4/+4 | |
| | | | | ok beck jsing | |||||
* | Switch ossl_ecdsa_verify() to timingsafe_memcmp() | tb | 2023-07-03 | 1 | -2/+2 | |
| | | | | Requested by jsing | |||||
* | Streamline ossl_ecdsa_verify() | tb | 2023-07-03 | 1 | -7/+13 | |
| | | | | | | | Make it single exit and use API more idiomatically and some other cosmetics. ok beck jsing | |||||
* | Explicit parameter printing can also use get0_order() | tb | 2023-07-03 | 1 | -5/+6 | |
| | | | | ok beck jsing |