summaryrefslogtreecommitdiff
path: root/src/lib (follow)
Commit message (Collapse)AuthorAgeFilesLines
* After reading a password with terminal echo off, restore the terminal toguenther2015-07-162-12/+10
| | | | | | | its original state instead of blindly turning echo on. problem reported on the openssl-dev list by William Freeman ok miod@ beck@
* Explicitely cast a char into unsigned long before shifting it left by 24, formiod2015-07-162-4/+4
| | | | | | | | | | | this would promote it to int for the shift, and then cast to unsigned long, sign-extending it if sizeof(long) > sizeof(int). This was not a problem because the computed value was explicitely range checked afterwards, with an upper bound way smaller than 1U<<31, but it's better practice to cast correctly. ok beck@
* Check return value of all used functions in OCSP_REQUEST_print(); coversmiod2015-07-162-10/+18
| | | | Coverity CID 78796; ok beck@
* Make sure the `reject negative sizes' logic introduced in 1.34 is actuallymiod2015-07-162-6/+8
| | | | | applied to all code paths. ok beck@ bcook@ doug@ guenther@
* check n before cbs_init, coverity - ID 125063beck2015-07-152-6/+18
| | | | ok bcook@ miod@
* test for n<0 before use in CBS_init - mostly to shut up coverity.beck2015-07-156-22/+66
| | | | reluctant ok miod@
* Flense out dead code, we don't do ecdhe_clnt_cert.beck2015-07-154-374/+150
| | | | | coverity ID's 21691 21698 ok miod@, "Fry it" jsing@
* Fix inverted test in previous. Commit message told what we intended, butmiod2015-07-152-4/+4
| | | | we did not notice my fingers slipping. Noticed by bcook@
* Remove dead code. Coverity CID 21688miod2015-07-152-8/+2
| | | | ok beck@
* Fix two theoretical NULL pointer dereferences which can only happen if youmiod2015-07-152-8/+18
| | | | | | | | have seriously corrupted your memory; Coverity CID 21708 and 21721. While there, plug a memory leak upon error in x509_name_canon(). ok bcook@ beck@
* Fix possible 32 byte buffer overrun, found by coverity, CID 78869beck2015-07-152-4/+4
| | | | ok miod@
* Memory leak; Coverity CID 78836miod2015-07-152-12/+16
| | | | ok beck@
* Unchecked allocations, and make sure we do not leak upon error. Fixesmiod2015-07-152-42/+72
| | | | | Coverity CID 21739 and more. ok bcook@
* Avoid leaking objects upon error; tweaks & ok doug@miod2015-07-152-36/+36
|
* Do not allow TS_check_signer_name() with signer == NULL frommiod2015-07-152-2/+8
| | | | | | | | | | | | | | | | | int_TS_RESP_verify_token(). Coverity CID 21710. Looking further, int_TS_RESP_verify_token() will only initialize signer to something non-NULL if TS_VFY_SIGNATURE is set in ctx->flags. But guess what? TS_REQ_to_TS_VERIFY_CTX() in ts/ts_verify_ctx.c, which is the TS_VERIFY_CTX constructor, explicitely clears this bit, with: ret->flags = TS_VFY_ALL_IMPRINT & ~(TS_VFY_TSA_NAME | TS_VFY_SIGNATURE); followed by more conditional flag clears. Of course, nothing prevents the user to fiddle with ctx->flags afterwards. This is exactly what ts.c in usr.bin/openssl does. This is gross, mistakes will happen. ok beck@
* Previous fix for Coverity CID 21785 did not cope correctly with seed_len != 0,miod2015-07-152-2/+6
| | | | | | seed_in == NULL case. Since this situation is an error anyway, bail out early. with and ok beck@
* Partially convert ssl3_get_message to CBS.doug2015-07-142-12/+30
| | | | | | | | Unlike the other conversions, this only partially converts the function for now. This is the second to last function which still uses the n2l3 macro. That macro is deprecated since we're using CBS. ok miod@ jsing@
* Convert dtls1_get_hello_verify to CBS.doug2015-07-142-34/+46
| | | | ok miod@ jsing@
* Convert ssl3_get_cipher_by_char to CBS.doug2015-07-142-4/+16
| | | | ok miod@ jsing@
* Convert ssl3_get_client_certificate to CBS.doug2015-07-142-30/+38
| | | | ok miod@ jsing@
* Convert ssl3_get_finished to CBS.doug2015-07-142-12/+18
| | | | ok miod@ jsing@
* Convert ssl_parse_clienthello_use_srtp_ext to CBS.doug2015-07-144-84/+50
| | | | ok miod@ jsing@
* Convert ssl3_get_cert_status to CBS.doug2015-07-142-34/+52
| | | | ok miod@ jsing@
* Convert ssl3_get_server_certificate to CBS.doug2015-07-142-34/+36
| | | | ok miod@
* fix the build on arm after the recent addition of -Wundefjsg2015-06-292-4/+4
| | | | ok doug@ deraadt@
* Convert ssl_bytes_to_cipher_list to CBS.doug2015-06-284-20/+40
| | | | | | | Link in the new 'unit' regress and expand the invalid tests to include some that would fail before the CBS conversion. input + ok miod@ jsing@
* Fix pointer to unsigned long conversion.doug2015-06-274-10/+14
| | | | | | | bcook@ notes that this check really only impacted 64-bit Windows. Also, changed the check to be unsigned for consistency. ok bcook@
* Put BUF_memdup() and BUF_reverse() under #ifndef LIBRESSL_INTERNAL.jsing2015-06-242-6/+4
|
* Stop using BUF_memdup() within the LibreSSL code base - it is correctlyjsing2015-06-244-12/+14
| | | | | | spelt malloc+memcpy, which is what is used in all except two places. ok deraadt@ doug@
* Change CBS_dup() to also sync the offset.doug2015-06-232-2/+4
| | | | | | | Previously, CBS_dup() had its own offset. However, it is more consistent to copy everything. ok miod@ jsing@
* Check for failure with CBB_init() in bs_ber.c.doug2015-06-212-4/+6
| | | | From BoringSSL commit 3fa65f0f05f67615d9daf48940e07f84d094ac6e.
* Just return if nmemb is 0. Avoids a NULL dereference and ismillert2015-06-211-1/+4
| | | | | consistent with the behavior of the other libc sort functions. OK deraadt@
* Convert ssl3_get_new_session_ticket to CBS.doug2015-06-202-48/+48
| | | | tweak + ok miod@ jsing@
* Convert ssl3_get_next_proto to CBS.doug2015-06-202-28/+38
| | | | tweak + ok miod@ jsing@
* Convert ssl_parse_serverhello_renegotiate_ext to CBS.doug2015-06-204-38/+42
| | | | ok miod@ jsing@
* Handle NIST curve names.jsing2015-06-202-4/+8
| | | | | | From OpenSSL. ok miod@ (a while ago)
* Have ECPKParameters_print() include the NIST curve name, if known.jsing2015-06-202-2/+20
| | | | | | From OpenSSL. ok miod@ (a while ago).
* Provide EC_curve_nid2nist() and EC_curve_nist2nid().jsing2015-06-204-4/+114
| | | | | | | | From OpenSSL. Rides libcrypto bump. ok miod@ (a while ago)
* Make SSL_OP_ALL readable.jsing2015-06-202-4/+18
| | | | ok deraadt@ doug@ millert@ miod@ sthen@
* Put CRYPTO_memcmp() under #ifndef LIBRESSL_INTERNAL.jsing2015-06-202-2/+6
| | | | ok doug@ deraadt@
* Replace remaining CRYPTO_memcmp() calls with timingsafe_memcmp().jsing2015-06-206-12/+12
| | | | ok doug@ deraadt@
* Convert ssl_parse_clienthello_renegotiate_ext to CBS.doug2015-06-204-30/+28
| | | | ok miod@, tweak + ok jsing@
* Replace internal call to CRYPTO_memcmp with timingsafe_memcmp.doug2015-06-202-4/+4
| | | | | | Suggested by jsing@. ok jsing@ miod@
* Fix warning on vax due to old gcc.doug2015-06-202-8/+8
| | | | | | | Old gcc warns when parameters have the same names as functions. Noticed by deraadt@. ok deraadt@ jsing@
* Crank major for libcrypto, ssl and tls due to MDC-2DES removal.doug2015-06-205-6/+6
| | | | ok miod@ jsing@
* Remove obsolete MDC-2DES from libcrypto.doug2015-06-2038-1062/+45
| | | | ok deraadt@ jsing@ miod@
* Remove needless casts. There's no reason to cast delim to char *millert2015-06-191-5/+4
| | | | when we can just make spanp const char * to match it. OK deraadt@
* Return the failing engine ID in the error stack.bcook2015-06-192-4/+8
| | | | | Noted by doug@ in an earlier revision of the dynamic engine removal patch, but I had forgotten to include it in the latest version.
* Add standard headers, C++ support to tls.h.bcook2015-06-191-1/+12
| | | | | | | | | | | | | | | | | This makes using libtls easier to include by including dependent headers, making something like this work as expected: #include <iostream> #include <tls.h> int main() { std::cout << "tls_init: " << tls_init() << "\n"; } This also makes building a standalone libtls-portable simpler. ok doug@, jsing@
* Disable ENGINE_load_dynamic (dynamic engine support).bcook2015-06-1934-1060/+22
| | | | | | | We do not build, test or ship any dynamic engines, so we can remove the dynamic engine loader as well. This leaves a stub initialization function in its place. ok beck@, reyk@, miod@
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-08-20 11:15:27 +0000