| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
configured.
Discussed with several.
ok bcook@
|
|
|
|
|
|
| |
than rerolling our own key clearing code.
ok tedu@
|
|
|
|
|
|
|
|
|
| |
X509_STORE_CTX_init(): do not free the X509_STORE_CTX * parameter upon
failure, for we did not allocate it and it might not come from the heap,
such as in check_crl_path() in this very same file where X509_STORE_CTX_init()
gets invoked with a stack address.
ok bcook@
|
|
|
|
|
| |
memcpy().
ok bcook@
|
|
|
|
|
| |
parameter, correctly set param->name to NULL after having freed it.
ok bcook@
|
| |
|
|
|
|
| |
ok jsing@ miod@
|
|
|
|
|
|
|
|
|
| |
Now that ressl config takes copies of the keys passed to it, the keys need
to be explicitly cleared. While this can be done by calling the appropriate
functions with a NULL pointer, it is simpler and more obvious to call one
function that does this for you.
ok tedu@
|
|
|
|
|
|
|
|
|
|
|
| |
read the PEM-encoded certificate chain from memory instead of a file.
This idea is derived from an older implementation in relayd that was
needed to use the function with a privep'ed process in a chroot. Now
it is time to get it into LibreSSL to make the API more privsep-
friendly and to make it available for other programs and the ressl
library.
ok jsing@ miod@
|
|
|
|
| |
ok bcook@
|
|
|
|
|
|
| |
for it may be NULL. Do not leak memory upon error.
ok bcook@
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manual field fiddling to create an ASN1_INTEGER object, instead of using
M_ASN1_INTEGER_new() which will allocate sizeof(long) bytes.
That person had probably never looked into malloc(3) and never heard of
allocation size rounding.
Thus, replace the obfuscated code with M_ASN1_INTEGER_new() followed by
ASN1_INTEGER_set(), to achieve a similar result, without the need for
/* version == 0 */ comments.
ok bcook@
|
|
|
|
|
|
| |
caller worrying about leaks or lifetimes.
after feedback from jsing
|
|
|
|
| |
fixed.
|
|
|
|
| |
the 64-bit code has to be disabled under OpenBSD/hppa.
|
|
|
|
|
| |
cases and breaks TLS 1.2; crank libcrypto.so minor version out of safety and
to be able to tell broken versions apart easily.
|
|
|
|
| |
ok miod@
|
|
|
|
|
|
| |
Based on OpenSSL.
ok miod@
|
|
|
|
|
|
|
| |
X509_STORE_get1_certs(), X509_STORE_get1_crls(): check the result of
allocations.
ok tedu@
|
|
|
|
|
|
| |
the first EVP block.
ok tedu@
|
|
|
|
| |
ok tedu@
|
|
|
|
|
|
|
|
| |
for the server hello.
From OpenSSL.
ok miod@
|
|
|
|
|
|
| |
strdup() to allocated directory list components.
ok jsing@
|
|
|
|
|
|
|
|
|
| |
effectively built two "static" data structures - instead of doing this,
just use static data structures to start with.
From OpenSSL (part of a larger commit).
ok miod@
|
|
|
|
|
|
| |
ssl3_send_finished(). While this previously checked against a zero return
value (which could occur on failure), we may as well test against the
expected length, since we already know what that is.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
end up with a value of zero, primarily since ssl3_take_mac() fails to check
the return value from the final_finish_mac() call. This would then mean that
an SSL finished message with a zero-byte payload would successfully match
against the calculated finish MAC.
Avoid this by checking the length of peer_finish_md_len and the SSL
finished message payload, against the known length already stored in
the SSL3_ENC_METHOD finish_mac_length field (making use of a previously
unused field).
ok miod@ (a little while back)
|
|
|
|
| |
From OpenSSL.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is off by default (instead of being enabled unconditionally).
The TLS padding extension was added as a workaround for a bug in F5 SSL
terminators, however appears to trigger bugs in IronPort SMTP appliances.
Now the SSL client gets to choose which of these devices it wants to
trigger bugs in...
Ported from OpenSSL.
Discussed with many.
ok miod@
|
|
|
|
|
|
|
|
| |
some changes an a_int.c did not get applied to a_enum.c; despite style
changes, make sure BN_to_ASN1_ENUMERATED() correctly handles a zero value
the same way BN_to_ASN1_INTEGER() does.
ok bcook@ beck@ jsing@
|
|
|
|
|
|
|
| |
Replace an if() posse with a switch() statement in traverse_string().
Remove unnecessary casts in cpy_*(),
with tweaks from guenther@; ok bcook@ jsing@ guenther@
|
|
|
|
| |
From Ming <gzchenym at 126.com>
|
| |
|
| |
|
|
|
|
|
|
|
| |
of the resulting FILE *), then pass fopen() the 'e' mode letter to
mark it close-on-exec.
ok miod@
|
|
|
|
|
|
|
| |
Mention that invalid bases do set EINVAL (as required by POSIX);
this part of the change uses part of an earlier patch by millert@.
Minor mdoc(7) cleanup and sync between the two pages while here.
Feedback and ok jmc@ and millert@.
|
|
|
|
|
|
|
|
|
|
| |
required by the C standard when called with an invalid base:
strtoll(), strtoimax(), strtoul(), strtoull(), and strtoumax().
Same behaviour for strtoq() and strtouq() even though not standardized.
No functional change in strtol(), it was the only one already correct.
While here, simplify the conditional expression for checking the base
and sync whitespace and comments among the six files.
ok millert@
|
|
|
|
|
| |
found with the new mandoc(1) MANDOCERR_AN_MISSING warning;
no text changes
|
|
|
|
|
|
| |
nor do we plan on supporting them.
ok guenther@
|
|
|
|
| |
OK aja@ mikeb@
|
|
|
|
|
| |
in kernel and user land.
OK florian@ mpi@
|
|
|
|
| |
ok millert@ manpage feedback jmc@
|
|
|
|
|
| |
If getrandom returns a temporary failure, make sure errno is not polluted when
it succeeds. Thanks to deraadt@ for pointing it out.
|
|
|
|
|
|
| |
non-standard ECDH curve by name or to disable it by passing NULL.
OK jsing@
|
|
|
|
|
|
|
|
| |
a system/superuser binary. At the same time, move the source code from its
current lib/libssl/src/apps location to a more appropriate home under
usr.bin/openssl.
ok deraadt@ miod@
|
|
|
|
|
|
|
|
|
| |
There is no intention to modify the string returned by strerror and
doing so is forbidden by the standard.
from Jonas 'Sortie' Termansen
ok tedu@ deraadt@
|
|
|
|
|
|
|
|
|
| |
The crypto/bio/bss_dgram.c file assumes that another file indirectly
includes <stdlib.h> that includes <sys/time.h>.
from Jonas 'Sortie' Termansen
ok deraadt@ tedu@
|
|
|
|
|
|
|
|
|
| |
These files currently depends on the wrapper <stdlib.h> file indirectly
including a header that provides select().
from Jonas 'Sortie' Termansen
ok deraadt@ tedu@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than passing in a fixed size buffer.
This is yet another example of a horribly designed API - if the given
buffer is NULL then SSL_CIPHER_description() allocates one for us (great!),
which we then need to free (no problem). However, if this allocation fails
it returns a pointer to a static string "OPENSSL_malloc Error" - obviously
bad things happen if we call free() with this pointer.
Unfortunately, there is no way of knowing that the function failed, other
than comparing the returned string against the string literal - so do that
before calling free()...
Joint work with beck@ during g2k14.
|
|
|
|
|
|
|
| |
ssl3_cipher_get_value() helper function, which returns the cipher suite
value for the given cipher.
ok miod@
|
|
|
|
|
|
| |
currently).
From Dmitry Eremin-Solenikov.
|