summaryrefslogtreecommitdiff
path: root/src/regress/lib/libcrypto/bn (unfollow)
Commit message (Collapse)AuthorFilesLines
2025-01-22Use simpler (if a bit weird) dup instead of new + copytb1-5/+2
ok jsing
2025-01-22bn_recp: Avoid complication for negative modulitb2-13/+5
Instead of doing a weird dance, set the sign on N in BN_RECP_CTX_create(). Since we're not exposing a general purpose calculator API, we can simplify. ok jsing
2025-01-22Adjust for BN_div_recp() -> BN_div_reciprocal()tb1-3/+3
2025-01-22Rename BN_div_recp() into BN_div_reciprocal()tb2-7/+7
Requested by jsing
2025-01-22Split BN_mod_sqr_reciprocal() out of BN_mod_mul_reciprocal()tb3-23/+19
There's no need for BN_mod_mul_reciprocal() to have this complication. The caller knows when x == y, so place the burden on the caller. This simplifies both the caller side and the implementation in bn_recp.c. ok jsing
2025-01-22Remove the mul_generator_ct function pointer from EC_METHOD.jsing3-24/+8
There's no need for a separate mul_generator_ct() function pointer - we really only need mul_single_ct() and mul_double_nonct(). And rather than calling ec_mul_ct() and having it figure out which point to use, explicitly pass the generator point when calling mul_single_ct(). ok tb@
2025-01-22Expand the SM4_ROUNDS macro.jsing1-25/+83
This macro references variable names that are in the consuming function and are not actually passed to the macro. Expanding it makes the logic clearer. If we wanted to reduce code the middle six group of rounds could be implemented using a for loop (which the compiler can then choose to unroll). ok tb@
2025-01-22Replace {load,store}_u32_be() with crypto_{load,store}_be32toh().jsing1-39/+25
load_u32_be() and store_u32_be() are not symmetrical, with load_u32_be() having a rather unexpected indexing interface. Fix up the callers to perform their own indexing and use crypto_{load,store}_be32toh() instead. ok tb@
2025-01-22Pull the family key and constant key tables out of SM4_set_key().jsing1-28/+27
ok tb@
2025-01-22BN_mod_mul_reciprocal: remove y == NULL complicationtb1-14/+11
No caller ever passes y == NULL, so remove the corresponding contortions and unindent the relevant bits. ok jsing
2025-01-22Replace rotl() with crypto_rol_u32().jsing1-15/+10
ok tb@
2025-01-22Ensure the cyclic subgroup cycles in the expected number of iterations.jsing1-9/+14
Also print the iteration number and fix some indentation.
2025-01-22ectest: heed long forgotten XXX and switch back to BN_one()tb1-3/+2
2025-01-21EC_GROUP_check(): use accessor rather than reaching into the grouptb1-3/+4
The API will be removed soon. This prepares moving it to its only consumer.
2025-01-21ec/Makefile: remove excess tabstb1-9/+9
2025-01-21bn_test: use BN_RECP_CTX_create() rather than _new()/_set()tb1-5/+3
2025-01-21Move BN_RECP_CTX to the heaptb3-67/+48
This introduces a BN_RECP_CTX_create() function that allocates and populates the BN_RECP_CTX in a single call, without taking an unused BN_CTX argument. At the same time, make the N and Nr members BIGNUMs on the heap which are allocated by BN_RECP_CTX_create() and freed by BN_RECP_CTX_free() and remove the unnecessary flags argument. Garbage collect the now unused BN_RECP_CTX_{new,init,set}(). ok jsing
2025-01-20crypto.h: zap some offensive whitespacetb1-2/+2
2025-01-20Annotate why EVP_PKEY_CTX_ctrl_str() will stay for a whiletb1-1/+6
2025-01-19openssl x509: zap extra whitespace in usagetb1-2/+2
2025-01-19appstest: remove the two tests exercising -C minimallytb1-3/+3
2025-01-19Remove -C option from "apps"tb6-436/+12
As far as I can tell, this way of generating "C code" was only used to add stuff to pretty regress and even prettier speed "app" and otherwise it just served to make the library maintainer's lives even more miserable. ok jsing
2025-01-19md_test: switch from 2<<28 to 1<<29tb1-2/+2
discussed with jsing
2025-01-19Improve bit counter handling in MD5.jsing3-19/+18
Like most hashes, MD5 needs to keep count of the number of bits in the message being processed. However, rather than using a 64 bit counter this is implemented using two 32 bit values (which is exposed in the public API). Even with this hurdle, we can still use 64 bit math and let the compiler figure out how to best handle the situation (hopefully avoiding compiler warnings on 16 bit platforms in the process!). On amd64 this code now requires two instructions, instead of the previous five. While here remove a comment that is excessively visible and no longer completely accurate (and if you're going to redefine types like MD5_WORD you kinda need to know what you're doing). ok tb@ (who's going to miss the dear diary style comments)
2025-01-19ecparam: remove GF2m remnanttb1-14/+4
This removes the last in-tree dependency on EC_METHOD_get_field_type() and EC_GROUP_method_of() and removes some dead code which would generate code that wouldn't compile if it was reachable. ok jsing
2025-01-19Add regress coverage that checks the MD5 message bit counter handling.jsing1-1/+66
2025-01-18Simplify tls1_check_ec_key()tb1-7/+7
It doesn't need to have optional arguments anymore, so we can pass in values and don't need NULL checks and dereferencing. ok jsing
2025-01-18Rename grp to group like almost everywhere elsetb1-4/+4
2025-01-18Remove parentheses in return statementstb1-14/+14
ok cc + sha256
2025-01-18Remove two pointless NULL checkstb1-8/+1
The only caller ensures that the EC_KEY is not NULL and passes the address of comp_id on its stack, so neither will be NULL.
2025-01-18Drop field determination dancetb1-9/+2
If we get here, we're in a server and have managed to load the cert. The public key is therefore a point on a built-in curve, and we know the group is defined over some prime field. Now it is just a matter of figuring out whether we support the group in libssl. ok jsing
2025-01-18Stop pretending we support arbirary explicit groupstb1-3/+2
ok jsing
2025-01-18Remove SSL_DES and SSL_IDEA remnantstb2-6/+2
ok jsing
2025-01-18SSL_CTX_set_cipher_list: stop mentioning ancient cipherstb1-11/+1
Support was removed nearly a decade ago. No need to mention this anymore. ok jsing
2025-01-18Remove last uses of SSL_aDSStb2-14/+2
ok jsing
2025-01-18ssl_seclevel: remove comment pertaining to DSA certstb1-6/+1
ok jsing
2025-01-18Stop mentioning DSA/DSStb6-23/+16
Support for this went away in 2017, but a few things still mentioned DSA in various contexts. Replace DSA with ECDSA where appropriate and otherwise delete this. It won't work. ok jsing
2025-01-18Use name instead of register.jsing1-3/+3
2025-01-17ssl_local.h: does not need to include dsa.htb1-2/+1
2025-01-17rsa_pmeth: unify strcmp return checkstb1-12/+10
ok jsing
2025-01-17Replace the remaining group->meth->field_{mul,sqr}tb1-13/+13
These somehow escaped a prior pass.
2025-01-17ecp_methods: remove p = group->p indirectiontb1-37/+34
This helped a bit with readability when we needed to do &group->p, but now that's no longer needed. discussed with jsing
2025-01-17ecp_methods: rework field_{mul,sqr}() handlingtb1-93/+83
Add wrapper functions that call the methods so that we can get rid of inconsistent use of ugly function pointers with massively overlong lines and other ways of reaching into the methods. ok jsing
2025-01-17Fix two incorrect strtonum() conversionstb1-3/+13
The atoi() would also accept the magic negative values and old openssl releases would expose these as arguments to -pkeyopt rsa_pss_saltlen:-1 in the openssl pkeyutl "app". While modern openssl switched to having readable alternatives to these, the oseid component of opensc would use the old syntax until yesterday. Still, this is our bug and we need to keep accepting the magic values as such, so do so. Everything below -3 will be rejected by the RSA_ctrl() handler later. Debugged by Doug Engert in https://github.com/OpenSC/OpenSC/issues/3317 ok jsing op
2025-01-17dh_ameth: explcitly -> explicitlytb1-2/+2
2025-01-17asn_mime: deteched -> detached + a knf nittb1-2/+3
2025-01-15Interop tests for openssl 3.3 and 3.4, retire 3.2, 1.1 (and 3.1 remnants)tb12-191/+130
OpenSSL 1.1 and 3.2 will be removed from the ports tree, so test the two remaining versions. Unfortunately, this requires a lot more manual massaging than there should be.
2025-01-15Default to eopenssl33 for other_openssl_bintb1-2/+2
OpenSSL 1.1 is dead and will soon be removed from the ports tree. At the same time OpenSSL 3.3 will become the default openssl.
2025-01-11Fix another awful comment in ec_point_cmp()tb1-4/+3
2025-01-11Align vertical backslashes in a macrotb1-2/+2
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-04-21 06:23:18 +0000