| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Spotted by egcc and probably clang 13. ok tb@
|
|
|
|
| |
ok beck jsing
|
|
|
|
| |
the vicinity.
|
|
|
|
| |
ok beck jsing
|
|
|
|
| |
ok beck jsing
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
get_cert_chain() needs some error checking. return X509_V_ errors
instead of trying to overload the NULL and then whine in a comment that
this won't really work.
Fix a bug that printed only the first attribute by factoring out the
thing that did the actual printing.
Sprinkle a few changes to accessors here and there.
This is loosely based on what OpenSSL did with some simplifications by
jsing.
ok beck jsing
|
|
|
|
| |
"just commit it" beck
|
|
|
|
|
|
| |
encoders many moons ago. OpenSSL removed it in 2015.
ok beck jsing
|
|
|
|
| |
ok jsing
|
| |
|
| |
|
|
|
|
| |
ok inoguchi
|
| |
|
| |
|
|
|
|
|
|
|
| |
This allows multiple entries without a subject even if unique_subject == yes.
Referred to OpenSSL commit 5af88441 and arranged for our codebase.
ok tb@
|
|
|
|
|
|
| |
Referred to OpenSSL commit 4881d849 and arranged for our codebase.
comment and ok from tb@
|
|
|
|
|
|
| |
Referred to OpenSSL commit a8d8e06b and arranged for our codebase.
comment and ok from tb@
|
| |
|
| |
|
|
|
|
|
|
| |
Referred to OpenSSL commit 2cedf794 and arranged for our codebase.
ok tb@
|
|
|
|
| |
suggested from tb@
|
|
|
|
| |
ok tb@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Even if the buffer is guaranteed to be NUL-terminated in a particular
case, it is still setting a bad example. Besides, it is unclear
to me whether there is any such guarantee in the case at hand.
Checking that would require auditing all of d2i_X509_bio(3),
ASN1_item_d2i_bio(&NETSCAPE_X509_it, ...), PEM_read_bio_X509_AUX(3),
and PKCS12_parse(3), since no such guarantee is documented for any
of these functions, and even then it would remain fragile with
respect to later changes of implementation details.
In the worst case, this could potentially result in a read buffer
overrun.
OK tb@ on an earlier version of this patch.
While we are here, deraadt@ requested to not use the word "string" in the
name of a variable that is not a string in the sense of the C language.
|
|
|
|
| |
noted by inoguchi
|
|
|
|
|
| |
doc fixes/ok jmc
ok beck
|
| |
|
| |
|
|
|
|
|
| |
suggested from tb@ for do_updatedb(),
and applied the same for do_body() and do_revoke().
|
|
|
|
| |
comments from tb@
|
|
|
|
| |
suggested from tb@
|
|
|
|
| |
pointed out by tb@
|
|
|
|
|
|
|
|
|
| |
Some functions are used without verifying the return value in openssl(1) ca.
This diff adds checking for the function return value.
With this diff, I changed return value of the write_new_certificate from void
to int to return the condition to the caller.
ok and comments from tb@
|
| |
|
|
|
|
| |
missed with r1.32
|
| |
|
| |
|
| |
|
|
|
|
| |
input from jsing@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New option handling for openssl(1) ca.
This diff is just replacing with new option handling, no functional change.
I'm using the word DN or RDN in description as manual uses them, rather than
replacing with "Distinguished Name" or "Relative Distinguished Name".
I would like to add another fixes below by follow-up diffs.
- remove space between '*' and pointer variable
- wrap 80+ long lines
- explicitly check pointer variable if it is NULL or not
comments and ok from jsing@
|
|
|
|
|
|
|
|
|
| |
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.
Work done and verified by Ashton Fagg <ashton@fagg.id.au>
ok deraadt@ semarie@ claudio@
|
|
|
|
| |
EC_GROUP_get_curve() and remove no longer needed prototypes.
|
| |
|
|
|
|
| |
These will be removed once EC_GROUP_get_curve() is public.
|
|
|
|
| |
input from bcook@, ok and comments from tb@
|
|
|
|
| |
ok and input from tb@
|
|
|
|
| |
ok jsing@ tb@
|
| |
|
|
|
|
|
|
| |
diff from robert scheck
discussed with and tweaked by sthen
|
|
|
|
| |
Reminded by inoguchi jsing
|
|
|
|
|
|
|
|
|
|
| |
Currently, SSL_is_dtls exists in both libssl and apps.c,
and one in libssl is guarded by LIBRESSL_INTERNAL and not exposed yet.
This causes portable build broke with openssl(1) and optionstest.
To solve this temporarily, rename SSL_is_dtls by apps.h.
This temporary renaming will be removed when the SSL_is_dtls() is exposed.
ok jsing@
|