Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fourth batch of perlpod(1) to mdoc(7) conversion | schwarze | 2015-02-23 | 37 | -1276/+2521 |
| | |||||
* | While slick, this isn't accessing multiple directories concurrently, so | guenther | 2015-02-22 | 1 | -29/+35 |
| | | | | | | | | using *at functions is equivalent to chdir()ing, which eases portability. Tested with mixes of absolute and relative paths. Eliminate a FILE leak too. prodded by jsing@ | ||||
* | Bump libcrypto and libssl majors, due to various recent churn. | jsing | 2015-02-22 | 4 | -4/+4 |
| | | | | Discussed with/requested by deraadt@ at the conclusion of s2k15. | ||||
* | Reluctantly add server-side support for TLS_FALLBACK_SCSV. | jsing | 2015-02-22 | 15 | -25/+159 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | This allows for clients that willingly choose to perform a downgrade and attempt to establish a second connection at a lower protocol after the previous attempt unexpectedly failed, to be notified and have the second connection aborted, if the server does in fact support a higher protocol. TLS has perfectly good version negotiation and client-side fallback is dangerous. Despite this, in order to maintain maximum compatability with broken web servers, most mainstream browsers implement this. Furthermore, TLS_FALLBACK_SCSV only works if both the client and server support it and there is effectively no way to tell if this is the case, unless you control both ends. Unfortunately, various auditors and vulnerability scanners (including certain online assessment websites) consider the presence of a not yet standardised feature to be important for security, even if the clients do not perform client-side downgrade or the server only supports current TLS protocols. Diff is loosely based on OpenSSL with some inspiration from BoringSSL. Discussed with beck@ and miod@. ok bcook@ | ||||
* | There is not much point constructing an SSL_CIPHER, then calling | jsing | 2015-02-22 | 2 | -14/+6 |
| | | | | | ssl3_cipher_get_value() to get the cipher suite value that we just put in the struct - use the cipher suite value directly. | ||||
* | Remove IMPLEMENT_STACK_OF noops. | jsing | 2015-02-22 | 4 | -8/+4 |
| | |||||
* | Update for recent verify related naming changes. | jsing | 2015-02-22 | 2 | -28/+28 |
| | |||||
* | Bump libtls major due to symbol removal. | jsing | 2015-02-22 | 1 | -3/+2 |
| | |||||
* | Rename tls_config_insecure_noverifyhost() to | jsing | 2015-02-22 | 4 | -21/+20 |
| | | | | | | | tls_config_insecure_noverifyname(), so that it is more accurate and keeps inline with the distinction between DNS hostname and server name. Requested by tedu@ during s2k15. | ||||
* | Check return values when setting dheparams and ecdhecurve for the default | jsing | 2015-02-22 | 1 | -11/+14 |
| | | | | configuration. | ||||
* | In the interests of being secure by default, make the default TLS ciphers | jsing | 2015-02-22 | 2 | -2/+17 |
| | | | | | | | be those that are TLSv1.2 with AEAD and PFS. Provide a "compat" mode that allows the previous default ciphers to be selected. Discussed with tedu@ during s2k15. | ||||
* | explain how tls_accept_socket works. | tedu | 2015-02-21 | 1 | -2/+9 |
| | |||||
* | tls_config_set_protocols is really void. Greg Martin. | tedu | 2015-02-21 | 1 | -3/+3 |
| | |||||
* | fill out docs a bit more, notably the read/write again behaviors. | tedu | 2015-02-21 | 1 | -3/+27 |
| | | | | ok jsing | ||||
* | If BN_rand() or BN_pseudo_rand() are called with a NULL rnd argument, | jsing | 2015-02-19 | 2 | -6/+16 |
| | | | | | | | | | BN_bin2bn() will helpfully allocate a BN which is then leaked. Avoid this by explicitly checking for NULL at the start of the bnrand() function. Fixes Coverity ID 78831. ok miod@ | ||||
* | BN_free() has its own NULL check. | jsing | 2015-02-19 | 1 | -14/+7 |
| | |||||
* | KNF. | jsing | 2015-02-19 | 1 | -766/+834 |
| | |||||
* | fix coverity 105350 and 10345 | beck | 2015-02-18 | 1 | -1/+2 |
| | | | | ok miod@, doug@ | ||||
* | Memory leak in error path. Coverity CID 78822. | miod | 2015-02-17 | 2 | -16/+18 |
| | | | | ok doug@ | ||||
* | Amend documentation for AI_ADDRCONFIG | jca | 2015-02-16 | 1 | -2/+4 |
| | | | | ok jmc@ | ||||
* | third batch of perlpod(1) to mdoc(7) conversion | schwarze | 2015-02-16 | 25 | -1367/+2121 |
| | |||||
* | Add more error checking and free resources in bytestringtest. | doug | 2015-02-16 | 1 | -26/+47 |
| | |||||
* | Avoid calling BN_CTX_end() on a context that wasn't started. | doug | 2015-02-15 | 2 | -8/+8 |
| | | | | | | | | | | | In dsa_builtin_paramgen(), if BN_MONT_CTX_new() fails, the BN_CTX_new() call above it will have allocated a ctx without calling BN_CTX_start() on it. The error handling calls BN_CTX_end() when ctx is allocated. Move the BN_MONT_CTX_new() call up so it will fail first without splitting up the BN_CTX_new() and BN_CTX_start(). tweak + ok miod@, ok bcook@ | ||||
* | Use "In" to mark up include files, instead of wrongly wrapping with Aq. | bentley | 2015-02-15 | 1 | -3/+3 |
| | | | | | | | Aq is not the same as <> in non-ASCII situations, so this caused incorrect output in some places. And it provided no semantics besides. ok schwarze@ | ||||
* | Regen | miod | 2015-02-15 | 6 | -528/+564 |
| | |||||
* | s/tls_load_keys/tls_load_file/ | jsing | 2015-02-15 | 1 | -2/+2 |
| | |||||
* | Document tls_config_parse_protocols() and update documentation for | jsing | 2015-02-15 | 2 | -5/+27 |
| | | | | tls_config_set_protocols(). | ||||
* | Fix various memory leaks by not exiting so abruptly from failed tests. | miod | 2015-02-15 | 1 | -579/+507 |
| | |||||
* | Remove ancient gcc workaround on mips. | miod | 2015-02-15 | 1 | -3/+2 |
| | |||||
* | Memory leak. Coverity CID 78865 | miod | 2015-02-15 | 1 | -2/+3 |
| | |||||
* | Wrong logic; Coverity CID 78894 | miod | 2015-02-15 | 1 | -1/+1 |
| | |||||
* | If we decide to discard the provided seed buffer because its size is not | miod | 2015-02-15 | 2 | -16/+12 |
| | | | | | | | | large enough, do it correctly so that the local seed buffer on the stack gets properly initialized in the first iteration of the loop. While there, remove an outdated and bogus comment. Coverity CID 21785 ok doug@ jsing@ | ||||
* | Check ASN1_OCTET_STRING_new() for failure. Coverity CID 78904 | miod | 2015-02-15 | 2 | -12/+16 |
| | | | | ok doug@ | ||||
* | In ec_wNAF_mul(), move the declaration of tmp_wNAF higher in scope, so that | miod | 2015-02-15 | 2 | -12/+10 |
| | | | | | all the function's exit paths can make sure it gets freed. Coverity CID 78861 tweaks & ok doug@ jsing@ | ||||
* | lsearch and lfind return void * | tedu | 2015-02-15 | 1 | -4/+4 |
| | |||||
* | Support for nc -T on IPv6 addresses. | jca | 2015-02-14 | 1 | -7/+16 |
| | | | | ok sthen@ | ||||
* | Remove asn1_ex_i2c() prototype, now that this function has been made static; | miod | 2015-02-14 | 2 | -4/+2 |
| | | | | reminded by bcook@ | ||||
* | Words read better when they are separated by spaces. | miod | 2015-02-14 | 2 | -2/+2 |
| | |||||
* | 1.18 would introduce a possible out-of-bounds access in the error path; | miod | 2015-02-14 | 2 | -14/+10 |
| | | | | | Coverity CID 105346 ok doug@ | ||||
* | Remove DEBUG_PKCS5V2 code. | miod | 2015-02-14 | 2 | -50/+2 |
| | |||||
* | Unchecked allocations in x509_name_canon(). | miod | 2015-02-14 | 2 | -2/+10 |
| | | | | ok doug@ jsing@ | ||||
* | Memory leak upon error in X509_add1_{trust,reject}_object. | miod | 2015-02-14 | 2 | -14/+46 |
| | | | | ok doug@ | ||||
* | Manually expand IMPLEMENT_EXTERN_ASN1 macro (the only occurence in crypto). | jsing | 2015-02-14 | 2 | -6/+20 |
| | | | | Only change to generated assembly is due to line numbers. | ||||
* | Remove IMPLEMENT_COMPAT_ASN1() and related support code. Nothing uses it in | miod | 2015-02-14 | 10 | -282/+14 |
| | | | | | | libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded copies of OpenSSL. ok jsing@ | ||||
* | Make asn1_ex_i2c() static. ok jsing@ | miod | 2015-02-14 | 2 | -4/+8 |
| | |||||
* | Memory leak in `should not happen' condition; Coverity CID 78889. | miod | 2015-02-14 | 2 | -8/+8 |
| | | | | ok doug@ jsing@ | ||||
* | Memory leak upon error; Coverity CID 78857 | miod | 2015-02-14 | 2 | -2/+8 |
| | | | | | ok doug@ jsing@ CVy: Committing in . | ||||
* | Check i2d_name_canon() for failure (negative return). Coverity CID 78888. | miod | 2015-02-14 | 2 | -12/+16 |
| | | | | ok doug@ jsing@ | ||||
* | Possible NULL pointer dereferences. Coverity CID 21719, 21732. | miod | 2015-02-14 | 4 | -6/+14 |
| | | | | ok doug@ jsing@ | ||||
* | Potential NULL dereference in the error path; Coverity CID 21720 | miod | 2015-02-14 | 2 | -4/+4 |
| | | | | ok doug@ jsing@ |