| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
ok jsing
|
|
|
|
|
|
|
|
| |
Remove unnecessary ret parameter and freeing of obj (which looks like
a double free or freeing of unallocated memory but actually isn't due
to various magic flags). Also make this const correct.
ok jsing
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another brilliancy straight out of muppet labs. Overeager and
misguided sprinkling of NULL checks, going through the trademark poor
code review, made this have semantics not matching what almost every
other function with this signature would be doing in OpenSSL land.
This is a long standing mistake we can't fix without introducing
portability traps, but at least annotate it. Simplify the elaborate
dance steps and make this resemble actual code.
ok jsing
|
|
|
|
|
|
| |
Drop unnecessary checks that are part of the stack API.
ok jsing
|
|
|
|
|
|
| |
Plus, replace a manual check with a call to X509_EXTENSION_get_critical().
ok jsing
|
|
|
|
|
|
|
|
| |
Like most of its siblings, this function can be simplified significantly
by making proper use of the API that is being built. Drop unnecessary NULL
checks and other weirdness and add some const correctness.
ok jsing
|
|
|
|
|
|
| |
remove the re-arming in the handler. Better than using siginterrupt(),
and avoids the errno saving requirement in the handler also.
ok guenther millert
|
|
|
|
|
|
| |
different asm stanzas to produce strong aliases.
This unbreaks libssl on hppa after the recent switch to LIBRESSL_NAMESPACE.
|
|
|
|
|
|
|
| |
different asm stanzas to produce strong aliases.
This unbreaks libcrypto (and thus ssh, among other things) on hppa after the
recent switch to LIBRESSL_CRYPTO_NAMESPACE.
|
| |
|
|
|
|
|
|
|
|
| |
Use better argument names, add a link to the relevant standards and add
CAVEATS and BUGS sections pointing out a few pitfalls.
discussed with davidben
ok beck
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SSL_select_next_poto() was written with NPN in mind. NPN has a weird
fallback mechanism which is baked into the API. This is makes no sense
for ALPN, where the API behavior is undesirable since it a server
should not end up choosing a protocol it doesn't (want to) support.
Arguably, ALPN should simply have had its own API for protocol selection
supporting the proper semantics, instead of shoehorning an NPN API into
working for ALPN.
Commit https://boringssl-review.googlesource.com/c/boringssl/+/17206/
renamed the arguments to work for both NPN and ALPN, with the slight
downside of honoring client preference instead of the SHOULD in
RFC 7301, section 3.2. This grates for most consumers in the wild,
but so be it. The behavior is saner and safer.
discussed with davidben
ok beck
|
|
|
|
|
| |
The comment probably made sense before guenther restricted the symbols
exported by libc in 2015.
|
|
|
|
|
|
| |
symbols from symbols.list now that we have everything hidden
ok tb@
|
|
|
|
|
|
| |
This ensures that when adding public symbols, the magic is not omitted.
with/ok beck
|
| |
|
| |
|
|
|
|
|
| |
With only slight application of color to this entelodont's lips. It's the
usual deal - hard to say what's worse, the code or its docs...
|
|
|
|
|
| |
It will be a cold day in hell before I see an OpenSSL manpage without
mistakes in it.
|
| |
|
| |
|
|
|
|
|
| |
requested by jsing on review
ok beck
|
| |
|
| |
|
|
|
|
| |
suggested by jsing on review
|
|
|
|
| |
noticed by jsing on review
|
|
|
|
| |
This is simpler, if slightly more expensive
|
|
|
|
|
|
| |
This is basically a copy of the libssl unit tests, moved to libcrypto to
avoid starting the infection of libssl with this particular piece of EVP
garbage.
|
| |
|
|
|
|
| |
no functional change
|
|
|
|
| |
Also avoid an unnecessary NULL check.
|
|
|
|
| |
ok jsing
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This reverts to the license added in OpenSSL's initial import of this
file in commit 1eff3485b63f84956b5f212aa4d853783bf6c8b5
|