|  | Commit message (Collapse) | Author | Age | Files | Lines | 
|---|
| ... |  | 
| | |  | 
| | |  | 
| | |  | 
| | |  | 
| | 
| 
| 
| | using parts of the text from SMIME_read_CMS(3) and SMIME_read_PKCS7(3) | 
| | 
| 
| 
| 
| | certainly not perfect, but arguably better than the even terser
PEM_write_bio_CMS_stream(3) and PEM_write_bio_PKCS7_stream(3) | 
| | 
| 
| 
| 
| 
| | From Stephen Henson, OpenSSL 564df0dd
ok jsing | 
| | 
| 
| 
| 
| 
| | Convert these to templated ASN.1, given we already have ASN1_BOOLEAN_it.
ok inoguchi@ tb@ | 
| | 
| 
| 
| 
| | in particular, NULL is also in <stdlib.h> according to the C99 standard;
"free commit" tb@ | 
| | 
| 
| 
| 
| 
| 
| 
| | With this we get simpler code, overflow checking and more sensible
memory ownership. Also switch the free_cont case to freezero() since this
could contain secrets.
ok inoguchi@ tb@ | 
| | 
| 
| 
| | still vague in various respects, but it's a start | 
| | 
| 
| 
| 
| 
| | also whack some sys/cdefs.h early includes which is such a brutally
bad pattern
ok bluhm mbuhl | 
| | 
| 
| 
| 
| 
| | parsing MASK: strings in ASN1_STRING_set_default_mask_asc(3).
Issue noticed by tb@, patch by me, two additional #include lines from tb@.
OK tb@. | 
| | |  | 
| | 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| | in an upcoming bump.  This omits EVP_AEAD_CTX which will be dealt with
separately. EVP_CIPHER_INFO internals are still publicly visible in
OpenSSL, so it won't be moved.
Move typedefs for HMAC_CTX and EVP_ENCODE_CTX to ossl_typ.h.  These
typedefs will be visible by files including only hmac.h or evp.h since
hmac.h includes evp.h and evp.h includes ossl_typ.h.
ok inoguchi | 
| | 
| 
| 
| 
| 
| | evp.h will be moved to evp_locl.h in an upcoming bump.
ok inoguchi | 
| | 
| 
| 
| 
| 
| 
| | from hmac.h will be moved there in an umpcoming bump. Include this
file where it will be needed.
ok inoguchi | 
| | 
| 
| 
| | ok inoguchi | 
| | 
| 
| 
| | ok inoguchi | 
| | 
| 
| 
| | ok inoguchi | 
| | 
| 
| 
| | tweak/ok inoguchi | 
| | 
| 
| 
| | ok inoguchi | 
| | |  | 
| | 
| 
| 
| 
| 
| | X509_get_pubkey()
ok inoguchi | 
| | 
| 
| 
| | ok inoguchi | 
| | 
| 
| 
| | ok inoguchi | 
| | 
| 
| 
| | ok inoguchi | 
| | |  | 
| | |  | 
| | 
| 
| 
| 
| 
| 
| | The API surrounding this is so complicated and streaming is so rarely
used in practice that describing this in more detail is not a priority
right now.  The documentation of the wrapper BIO_new_CMS(3) is also
rather vague, and BIO_new_PKCS7() isn't described at all so far. | 
| | 
| 
| 
| | ok inoguchi schwarze | 
| | 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| 
| | from the OpenSSL 1.1.1 branch, which is still under a free license,
mostly this commit:
commit d35c0ff30b31be9fd5dcf3d552a16feb8de464bc
Author: Dr. Stephen Henson <steve@openssl.org>
Date: Fri Oct 19 15:06:31 2012 +0000
fix ASN1_STRING_TABLE_add so it can override existing string table values
This fixes a segfault in ASN1_STRING_TABLE_add(3), which tried to change a
static const entry when called with an nid already in the default table,
and it switches the precedence of the two tables in ASN1_STRING_TABLE_get(3).
In addition, it changes behaviour in the following minor ways:
* Ignore negative minsize and maxsize arguments, not just -1.
* Ignore a zero mask and zero flags.
It's unclear whether these additional changes make the API absolutely
better, but we want compatibility with OpenSSL in these functions.
Tweaks & OK tb@. | 
| | 
| 
| 
| 
| 
| 
| | and some style improvements from the OpenSSL 1.1.1 branch,
which is still under a free license.
No functional change.
OK and additional tweaks tb@. | 
| | 
| 
| 
| 
| | mention which argument values can be used to not change the respective fields,
and tweak a few additional wordings | 
| | |  | 
| | 
| 
| 
| 
| 
| 
| | are unused in the end anyway and occupies needless space, especially in ftp(1)
shipped with the ramdisk.
ok tb@ | 
| | |  | 
| | 
| 
| 
| 
| | B_ASN1_DIRECTORYSTRING, B_ASN1_PRINTABLE, B_ASN1_DISPLAYTEXT, B_ASN1_TIME,
DIRSTRING_TYPE, PKCS9STRING_TYPE | 
| | |  | 
| | |  | 
| | |  | 
| | 
| 
| 
| 
| | Seeing the symbolic names in addition to the magic numbers
makes it esier to understand the text. | 
| | |  | 
| | 
| 
| 
| 
| 
| | While here, tweak some wordings a bit to make it less likely that
readers confuse the type held by an ASN1_TYPE object with the type
of the ASN1_TYPE object itself, which is always V_ASN1_ANY. | 
| | |  | 
| | |  | 
| | |  | 
| | |  | 
| | 
| 
| 
| | ok inoguchi jsing | 
| | 
| 
| 
| | ok inoguchi jsing |