Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | ec_print.c: Unwrap a line | tb | 2023-11-21 | 1 | -3/+2 |
| | |||||
* | Inline a better version of print_bin() in only caller | tb | 2023-11-21 | 1 | -42/+27 |
| | | | | | | | | | | Instead of printing to a temporary buffer with weird gymnastics, we can simply write things out to the BIO using proper indent. This still isn't perfect since we have a CBS version of this in ecx_buf_print(), which is basically what used to be ASN1_buf_print(). Annotate this with an XXX for future cleanup. ok beck | ||||
* | Make a few purpose things const | tb | 2023-11-21 | 4 | -11/+11 |
| | | | | | This should allow us to constify a sizable table in libcrypto in an upcoming bump. | ||||
* | Fix a <= 5-byte buffer overwrite in print_bin() | tb | 2023-11-21 | 1 | -2/+3 |
| | | | | | | | | | | | | If the offset is > 124, this function would overwrite between 1 and 5 bytes of stack space after str[128]. So for a quick fix extend the buffer by 5 bytes. Obviously this is the permanent fix chosen elswehere. The proper fix will be to rewrite this function from scratch. Reported in detail by Masaru Masuda, many thanks! Fixes https://github.com/libressl/openbsd/issues/145 begrudging ok from beck | ||||
* | Still need engine.h for ENGINE_free() | tb | 2023-11-20 | 1 | -1/+2 |
| | | | | But do away with the OPENSSL_NO_ENGINE dance. | ||||
* | Mark up an occurrence of ENGINE | tb | 2023-11-19 | 1 | -2/+3 |
| | |||||
* | ENGINE can no longer have ex_data attached to it | tb | 2023-11-19 | 1 | -3/+3 |
| | |||||
* | Remove musings how ENGINE may or may not screw everything up. | tb | 2023-11-19 | 1 | -23/+2 |
| | |||||
* | Remove ENGINE mention in RSA_new() | tb | 2023-11-19 | 1 | -14/+6 |
| | |||||
* | OPENSSL_config() no longer calls ENGINE_load_builtin_engines() | tb | 2023-11-19 | 1 | -5/+4 |
| | |||||
* | ENGINE_add_conf_module() no longer exists | tb | 2023-11-19 | 1 | -8/+2 |
| | |||||
* | Remove ENGINE Xr that I left behind | tb | 2023-11-19 | 1 | -2/+1 |
| | |||||
* | zap stray comma | tb | 2023-11-19 | 1 | -2/+2 |
| | |||||
* | Unifdef OPENSSL_NO_ENGINE in libssl | tb | 2023-11-19 | 5 | -69/+5 |
| | | | | | | As usual, a few manual fixes to avoid duplicate lines. ok jsing | ||||
* | Manually unifdef OPENSSL_NO_ENGINE in ssl_clnt.c | tb | 2023-11-19 | 1 | -17/+4 |
| | | | | | | This allows us to simplify ssl_do_client_cert_cb() a bit. ok jsing | ||||
* | Rename an ENGINE from e to engine for consistency | tb | 2023-11-19 | 1 | -2/+2 |
| | |||||
* | Unifdef OPENSSL_NO_ENGINE in libcrypto | tb | 2023-11-19 | 21 | -431/+21 |
| | | | | | | | This is mechanical apart from a few manual edits to avoid doubled empty lines. ok jsing | ||||
* | Unifdef OPENSSL_NO_ENGINE in pmeth_lib.c | tb | 2023-11-19 | 1 | -41/+3 |
| | | | | | | | This includes a manual intervention for the call to EVP_PKEY_meth_find() which ended up in the middle of nowhere. ok jsing | ||||
* | Unifdef OPENSSL_NO_ENGINE in engine.h | tb | 2023-11-19 | 1 | -566/+8 |
| | | | | | | | Also rip out all the gross, useless comments. There's still too much garbage in here... ok jsing | ||||
* | Also mention ENGINE_{cleanup,{ctrl_cmd{,_string}() | tb | 2023-11-19 | 1 | -3/+29 |
| | |||||
* | Remove last OPENSSL_NO_ENGINE from libssl regress | tb | 2023-11-19 | 1 | -7/+1 |
| | |||||
* | Unifdef OPENSSL_NO_ENGINE in libcrypto regress | tb | 2023-11-19 | 8 | -68/+8 |
| | |||||
* | Missing period | tb | 2023-11-19 | 1 | -2/+2 |
| | |||||
* | fix grammar | tb | 2023-11-19 | 1 | -2/+2 |
| | |||||
* | Remove remaining ENGINE manuals | tb | 2023-11-19 | 11 | -1988/+1 |
| | | | | They document functionality that no longer exists. | ||||
* | Strip mention of ENGINE out of *_set_method.3 | tb | 2023-11-19 | 3 | -98/+26 |
| | |||||
* | Strip out mentions of ENGINE_load_builtin_engines() | tb | 2023-11-19 | 1 | -7/+4 |
| | | | | | There's probably more that needs to be updated here, but that can be done another day. | ||||
* | ex data for ENGINEs is no longer a thing | tb | 2023-11-19 | 1 | -9/+2 |
| | |||||
* | Remove section explaining how great and flexible ENGINE is and | tb | 2023-11-19 | 1 | -28/+2 |
| | | | | remove two Xr to ENGINE manuals. | ||||
* | Remove obsolete engine configuration section | tb | 2023-11-19 | 1 | -106/+2 |
| | |||||
* | Document the remaining ENGINE stubs in a single manual | tb | 2023-11-19 | 1 | -146/+103 |
| | |||||
* | EVP_PKEY_encrypt() simplify example | tb | 2023-11-19 | 1 | -6/+4 |
| | | | | In particular, do not use an uninitialized engine, simply pass NULL. | ||||
* | openssl pkcs12: rewrite without reaching into X509_ALGOR | tb | 2023-11-19 | 1 | -7/+10 |
| | | | | | | | | | We can call ASN1_item_unpack() which will end up stuffing the same arguments into ASN1_item_d2i() as d2i_PBEPARAM(). This eliminates the last struct access into X509_ALGOR outside libcrypto in the base tree. ok jsing | ||||
* | openssl ts: convert to X509_ALGOR_set0() | tb | 2023-11-19 | 1 | -5/+8 |
| | | | | ok jsing | ||||
* | Check for negative EVP_CIPHER_CTX_iv_length() return in libssl | tb | 2023-11-18 | 2 | -9/+13 |
| | | | | ok beck | ||||
* | Forgot to fix one unsigned int vs int confusion | tb | 2023-11-18 | 1 | -3/+3 |
| | | | | CID 468015 | ||||
* | Check for negative IV length | tb | 2023-11-18 | 5 | -27/+45 |
| | | | | | | | | | | | | A recent change in EVP_CIPHER_CTX_iv_length() made it possible in principle that this function returns -1. This can only happen for an incorrectly set up EVP_CIPHER. Still it is better form to check for negative lengths before stuffing it into a memcpy(). It would probably be desirable to cap the iv_length to something large enough. This can be done another time. ok beck | ||||
* | Mention which functions are implemented as macros in the few cases | schwarze | 2023-11-16 | 13 | -34/+76 |
| | | | | where that information was missing. | ||||
* | drop some duplicate statements about macros | schwarze | 2023-11-16 | 4 | -23/+10 |
| | |||||
* | fix wrong macro | schwarze | 2023-11-16 | 1 | -3/+3 |
| | |||||
* | delete lots of stuff that no longer exists | schwarze | 2023-11-16 | 1 | -300/+17 |
| | |||||
* | fix typo: exdata -> ex_data | schwarze | 2023-11-16 | 1 | -4/+4 |
| | |||||
* | Minimal fix to unbreak OPENSSL_{gmtime,timegm}(3) | tb | 2023-11-16 | 1 | -15/+18 |
| | | | | | | I was told not to look since it will magically get fixed. Fine. I'd still have expected a minimal amount of care so that the manpage isn't totally dysfunctional and missing text in the right places. Sigh. | ||||
* | Drop some unnecessary parentheses | tb | 2023-11-15 | 1 | -19/+19 |
| | |||||
* | Shuffle getters and adders down a bit | tb | 2023-11-15 | 1 | -34/+30 |
| | | | | These use static helper functions which don't need prototypes this way. | ||||
* | Make X509_certificate_type() less bad | tb | 2023-11-13 | 1 | -24/+29 |
| | | | | | | | This converts to proper single exit and undoes a number of unnecessarily silly muppet antics. ok beck | ||||
* | Garbage collect an incoherent export crypto check | tb | 2023-11-13 | 1 | -4/+1 |
| | | | | | | | | | | | | Contrast "#define EVP_PKT_EXP 0x1000 /* <= 512 bit key */" with the diff: - /* /8 because it's 1024 bits we look for, not bytes */ - if (EVP_PKEY_size(pk) <= 1024 / 8) - ret |= EVP_PKT_EXP; EVP_PKT_EXP will be nuked at the next opportunity. discussed with jsing | ||||
* | Use a sensible variable name (i.e. nid) instead of i for a NID | tb | 2023-11-13 | 1 | -5/+6 |
| | |||||
* | Use X509_get_signature_nid() instead of inlining it | tb | 2023-11-13 | 1 | -2/+2 |
| | | | | ok beck jsing | ||||
* | X509_certificate_type() needs to know about RSA-PSS | tb | 2023-11-13 | 1 | -1/+4 |
| | | | | | | | This doesn't do much right now, but is part of the tangle that is adding RSA-PSS support. ok beck jsing |