From 207ad0ebbc1371cabc99dd9599f264886bba4d1a Mon Sep 17 00:00:00 2001 From: miod <> Date: Thu, 16 Jul 2015 02:16:19 +0000 Subject: Check return value of all used functions in OCSP_REQUEST_print(); covers Coverity CID 78796; ok beck@ --- src/lib/libcrypto/ocsp/ocsp_prn.c | 14 +++++++++----- src/lib/libssl/src/crypto/ocsp/ocsp_prn.c | 14 +++++++++----- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/src/lib/libcrypto/ocsp/ocsp_prn.c b/src/lib/libcrypto/ocsp/ocsp_prn.c index 362d480926..37d033adb6 100644 --- a/src/lib/libcrypto/ocsp/ocsp_prn.c +++ b/src/lib/libcrypto/ocsp/ocsp_prn.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ocsp_prn.c,v 1.7 2014/06/12 15:49:30 deraadt Exp $ */ +/* $OpenBSD: ocsp_prn.c,v 1.8 2015/07/16 02:16:19 miod Exp $ */ /* Written by Tom Titchener for the OpenSSL * project. */ @@ -174,11 +174,15 @@ OCSP_REQUEST_print(BIO *bp, OCSP_REQUEST* o, unsigned long flags) inf->requestExtensions, flags, 4)) goto err; if (sig) { - X509_signature_print(bp, sig->signatureAlgorithm, - sig->signature); + if (X509_signature_print(bp, sig->signatureAlgorithm, + sig->signature) == 0) + goto err; for (i = 0; i < sk_X509_num(sig->certs); i++) { - X509_print(bp, sk_X509_value(sig->certs, i)); - PEM_write_bio_X509(bp, sk_X509_value(sig->certs, i)); + if (X509_print(bp, sk_X509_value(sig->certs, i)) == 0) + goto err; + if (PEM_write_bio_X509(bp, + sk_X509_value(sig->certs, i)) == 0) + goto err; } } return 1; diff --git a/src/lib/libssl/src/crypto/ocsp/ocsp_prn.c b/src/lib/libssl/src/crypto/ocsp/ocsp_prn.c index 362d480926..37d033adb6 100644 --- a/src/lib/libssl/src/crypto/ocsp/ocsp_prn.c +++ b/src/lib/libssl/src/crypto/ocsp/ocsp_prn.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ocsp_prn.c,v 1.7 2014/06/12 15:49:30 deraadt Exp $ */ +/* $OpenBSD: ocsp_prn.c,v 1.8 2015/07/16 02:16:19 miod Exp $ */ /* Written by Tom Titchener for the OpenSSL * project. */ @@ -174,11 +174,15 @@ OCSP_REQUEST_print(BIO *bp, OCSP_REQUEST* o, unsigned long flags) inf->requestExtensions, flags, 4)) goto err; if (sig) { - X509_signature_print(bp, sig->signatureAlgorithm, - sig->signature); + if (X509_signature_print(bp, sig->signatureAlgorithm, + sig->signature) == 0) + goto err; for (i = 0; i < sk_X509_num(sig->certs); i++) { - X509_print(bp, sk_X509_value(sig->certs, i)); - PEM_write_bio_X509(bp, sk_X509_value(sig->certs, i)); + if (X509_print(bp, sk_X509_value(sig->certs, i)) == 0) + goto err; + if (PEM_write_bio_X509(bp, + sk_X509_value(sig->certs, i)) == 0) + goto err; } } return 1; -- cgit v1.2.3-55-g6feb