From 2e39f4f9ad2b7c91dccfb7b2fb1b6237fef520f5 Mon Sep 17 00:00:00 2001 From: deraadt <> Date: Thu, 27 Jun 2019 18:03:37 +0000 Subject: Some asprintf() calls were checked < 0, rather than the precise == -1. ok millert nicm tb, etc --- src/usr.bin/nc/netcat.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/usr.bin/nc/netcat.c b/src/usr.bin/nc/netcat.c index 048502bd1e..26288560b0 100644 --- a/src/usr.bin/nc/netcat.c +++ b/src/usr.bin/nc/netcat.c @@ -1,4 +1,4 @@ -/* $OpenBSD: netcat.c,v 1.203 2019/02/26 17:32:47 jsing Exp $ */ +/* $OpenBSD: netcat.c,v 1.204 2019/06/27 18:03:37 deraadt Exp $ */ /* * Copyright (c) 2001 Eric Jackson * Copyright (c) 2015 Bob Beck. All rights reserved. @@ -1453,12 +1453,12 @@ build_ports(char *p) for (x = 0; x <= hi - lo; x++) { cp = arc4random_uniform(x + 1); portlist[x] = portlist[cp]; - if (asprintf(&portlist[cp], "%d", x + lo) < 0) + if (asprintf(&portlist[cp], "%d", x + lo) == -1) err(1, "asprintf"); } } else { /* Load ports sequentially. */ for (cp = lo; cp <= hi; cp++) { - if (asprintf(&portlist[x], "%d", cp) < 0) + if (asprintf(&portlist[x], "%d", cp) == -1) err(1, "asprintf"); x++; } -- cgit v1.2.3-55-g6feb