From 426abf469a8a759606fd33455b084cff18fa71a2 Mon Sep 17 00:00:00 2001
From: deraadt <>
Date: Mon, 7 Mar 2005 20:00:15 +0000
Subject: fd leak; andrushock@korovino.net

---
 src/lib/libc/net/rcmd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lib/libc/net/rcmd.c b/src/lib/libc/net/rcmd.c
index b99a35b38c..4aa3261133 100644
--- a/src/lib/libc/net/rcmd.c
+++ b/src/lib/libc/net/rcmd.c
@@ -29,7 +29,7 @@
  */
 
 #if defined(LIBC_SCCS) && !defined(lint)
-static char *rcsid = "$OpenBSD: rcmd.c,v 1.49 2004/11/17 01:42:26 itojun Exp $";
+static char *rcsid = "$OpenBSD: rcmd.c,v 1.50 2005/03/07 20:00:15 deraadt Exp $";
 #endif /* LIBC_SCCS and not lint */
 
 #include <sys/param.h>
@@ -213,8 +213,10 @@ rcmd_af(ahost, rport, locuser, remuser, cmd, fd2p, af)
 		if (s2 < 0)
 			goto bad;
 		readsp = (fd_set *)malloc(fdssize);
-		if (readsp == NULL)
+		if (readsp == NULL) {
+			close(s2);
 			goto bad;
+		}
 		listen(s2, 1);
 		(void)snprintf(num, sizeof(num), "%d", lport);
 		if (write(s, num, strlen(num)+1) != strlen(num)+1) {
-- 
cgit v1.2.3-55-g6feb