From 52a29ff38f224919bb97c3cc22ec08682b47cb94 Mon Sep 17 00:00:00 2001 From: deraadt <> Date: Thu, 20 Jun 2019 14:19:25 +0000 Subject: sockatmark(3), recv(2), getsockopt(2), and connect(2) return specifically -1 to mark failure, not arbitrary values < 0. I believe manual pages should follow the described contract precisely and accurately. --- src/lib/libc/net/sockatmark.3 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/lib/libc/net/sockatmark.3 b/src/lib/libc/net/sockatmark.3 index 6a94b84390..524536c12b 100644 --- a/src/lib/libc/net/sockatmark.3 +++ b/src/lib/libc/net/sockatmark.3 @@ -22,9 +22,9 @@ .\" SUCH DAMAGE. .\" .\" From FreeBSD: r108087 2002-12-19 01:40:28 -0800 -.\" $OpenBSD: sockatmark.3,v 1.1 2014/08/31 02:27:37 guenther Exp $ +.\" $OpenBSD: sockatmark.3,v 1.2 2019/06/20 14:19:25 deraadt Exp $ .\" -.Dd $Mdocdate: August 31 2014 $ +.Dd $Mdocdate: June 20 2019 $ .Dt SOCKATMARK 3 .Os .Sh NAME @@ -66,7 +66,7 @@ oob() char waste[BUFSIZ]; for (;;) { - if ((mark = sockatmark(rem)) < 0) { + if ((mark = sockatmark(rem)) == -1) { perror("sockatmark"); break; } @@ -74,7 +74,7 @@ oob() break; (void) read(rem, waste, sizeof (waste)); } - if (recv(rem, &mark, 1, MSG_OOB) < 0) { + if (recv(rem, &mark, 1, MSG_OOB) == -1) { perror("recv"); ... } -- cgit v1.2.3-55-g6feb