From 70850c047f141cf86dd9dc4ed010b2a352b5036b Mon Sep 17 00:00:00 2001 From: tb <> Date: Tue, 29 Oct 2024 06:36:58 +0000 Subject: eckey_compute_pubkey: don't leak the public key EC_KEY_set_public_key() sets a copy, so it doesn't take ownership and hence pub_key must not be nulled out on success. --- src/lib/libcrypto/ec/ec_ameth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/libcrypto/ec/ec_ameth.c b/src/lib/libcrypto/ec/ec_ameth.c index 246da22450..754fabfb4d 100644 --- a/src/lib/libcrypto/ec/ec_ameth.c +++ b/src/lib/libcrypto/ec/ec_ameth.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ec_ameth.c,v 1.71 2024/10/28 18:01:26 tb Exp $ */ +/* $OpenBSD: ec_ameth.c,v 1.72 2024/10/29 06:36:58 tb Exp $ */ /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL * project 2006. */ @@ -328,7 +328,6 @@ eckey_compute_pubkey(EC_KEY *eckey) goto err; if (!EC_KEY_set_public_key(eckey, pub_key)) goto err; - pub_key = NULL; ret = 1; -- cgit v1.2.3-55-g6feb